Skip to contentSkip to conversation

Add a driver for Silvaco I3C Dual-Role Master IP

PATCH In review Conor Culhane 2 participants 2 messages Feb 17, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add a driver for Silvaco I3C Dual-Role Master IP

---
 drivers/i3c/master/Kconfig          |    8 +
 drivers/i3c/master/Makefile         |    1 +
 drivers/i3c/master/svc-i3c-master.c | 2863 +++++++++++++++++++++++++++
 3 files changed, 2872 insertions(+)
 create mode 100644 drivers/i3c/master/svc-i3c-master.c
drivers/i3c/master/Kconfig +8 -0
index 4e80a1fcbf91..032b4de14277 100644
@@ -21,3 +21,11 @@ config DW_I3C_MASTER
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called dw-i3c-master.
+
+config SVC_I3C_MASTER
+	tristate "Silvaco I3C Dual-Role Master driver"
+	depends on I3C
+	depends on HAS_IOMEM
+	depends on !(ALPHA || PARISC)
+	help
+	  Support for Silvaco I3C Dual-Role Master Controller.
drivers/i3c/master/Makefile +1 -0
index 7eea9e086144..4efd244fdfb1 100644
@@ -1,3 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0-only
 obj-$(CONFIG_CDNS_I3C_MASTER)		+= i3c-master-cdns.o
 obj-$(CONFIG_DW_I3C_MASTER)		+= dw-i3c-master.o
+obj-$(CONFIG_SVC_I3C_MASTER)		+= svc-i3c-master.o
\ No newline at end of file
drivers/i3c/master/svc-i3c-master.c new file +2863 -0

2,863 lines not on this page · raw message

Signature · 7 lines
2.17.1


_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c
#1 lore raw

Hello Conor,

On Tue, 11 Feb 2020 10:43:32 -0500
Conor Culhane <[email protected]> wrote:

Can you add a commit message here?

Quoted 5 lines
---
 drivers/i3c/master/Kconfig          |    8 +
 drivers/i3c/master/Makefile         |    1 +
 drivers/i3c/master/svc-i3c-master.c | 2863 +++++++++++++++++++++++++++

There are several coding-style issues (camel case, use of typedefs, ...). Can you please run 'scripts/checkpatch.pl --strict' on your patch and post a new version with all those coding-style issues fixed?

Thanks,

Boris

_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c