Skip to contentSkip to conversation

bitbake: fetch2: svn: care for path_spec

PATCH In review Jens Rehsack 2 participants 2 messages Feb 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitbake: fetch2: svn: care for path_spec

From: Jens Rehsack <[email protected]>

Documentation says:
"path_spec": A specific directory in which to checkout the specified svn module.
but existing svn fetcher uses "module" always as path of checked out svn-module, regardless whether path_spec was given or not.

---
 bitbake/lib/bb/fetch2/svn.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
bitbake/lib/bb/fetch2/svn.py +1 -1
index 6c8caf5fb9..385a6b2cf1 100644
@@ -47,7 +47,7 @@ class Svn(FetchMethod):
         svndir = d.getVar("SVNDIR") or (d.getVar("DL_DIR") + "/svn")
         relpath = self._strip_leading_slashes(ud.path)
         ud.pkgdir = os.path.join(svndir, ud.host, relpath)
-        ud.moddir = os.path.join(ud.pkgdir, ud.module)
+        ud.moddir = os.path.join(ud.pkgdir, ud.path_spec)
         # Protects the repository from concurrent updates, e.g. from two
         # recipes fetching different revisions at the same time
         ud.svnlock = os.path.join(ud.pkgdir, "svn.lock")
Signature · 1 line
2.17.1
#1 lore raw

✗ patchtest: failure for bitbake: fetch2: svn: care for path_spec

== Series Details ==

Series: bitbake: fetch2: svn: care for path_spec
Revision: 1
URL : https://patchwork.openembedded.org/series/22713/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series sent to the wrong mailing list or some patches from the series correspond to different mailing lists [test_target_mailing_list]

  Suggested fix    Send the series again to the correct mailing list (ML)
  Suggested ML     [email protected] [http://git.openembedded.org/bitbake/]
  Patch's path:    bitbake/lib/bb/fetch2/svn.py

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at c9b5802bbe)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe