fstests: add perf to the list of test directories
PATCH 1/1 fstests: add perf to the list of test directories
I noticed that despite having PERF_CONFIGNAME set I wasn't getting the perf/ tests run when I used -g auto. This is because it's not included in the list of directories to look at. Fix this so that perf tests get run as well.
--- check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
check +1 -1
@@ -44,7 +44,7 @@ timestamp=${TIMESTAMP:=false} rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.* -SRC_GROUPS="generic shared" +SRC_GROUPS="generic shared perf" export SRC_DIR="tests" usage()
Signature · 1 line
2.24.1
Quoted 15 lines · Josef Bacik
I noticed that despite having
PERF_CONFIGNAMEset I wasn't getting the perf/ tests run when I used -g auto. This is because it's not included in the list of directories to look at. Fix this so that perf tests get run as well.Signed-off-by Josef Bacik <[email protected]>--- check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)check +0
-0
check timestamp=${TIMESTAMP:=false} · line 47
Quoted 5 lines
check +1
-1@@ -44,7 +44,7 @@ timestamp=${TIMESTAMP:=false} rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.* -SRC_GROUPS="generic shared" +SRC_GROUPS="generic shared perf"
Looks good to me, if the maintainer won't prefer moving perf/001 to generic/ :)
Thanks,
Zorro
Quoted 6 lines
check +0
-0export SRC_DIR="tests" usage()Signature · 1 line
2.24.1
Quoted 6 lines · Josef Bacik
I noticed that despite having
PERF_CONFIGNAMEset I wasn't getting the perf/ tests run when I used -g auto. This is because it's not included in the list of directories to look at. Fix this so that perf tests get run as well.Signed-off-by Josef Bacik <[email protected]>
I don't think the perf test infra is widely used by developers and testers yet, so adding perf tests to default 'auto' tests would bring unexpected failures.
So I think it's better to keep it not run by default for now, and if you want to run perf tests in your test env, you could do it easily by adding "-g perf/auto" option to "./check", e.g.
./check -g auto -g perf/auto
And if there're frequent users of the perf infra, please reply this thread and let us know, it'd be interesting to know how many users are there.
Thanks,
Eryu
Quoted 20 lines
--- check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)check +1
-1@@ -44,7 +44,7 @@ timestamp=${TIMESTAMP:=false} rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.* -SRC_GROUPS="generic shared" +SRC_GROUPS="generic shared perf" export SRC_DIR="tests" usage()Signature · 1 line
2.24.1