Skip to contentSkip to conversation

fio: remove disabling of compiler optimizations

PATCH In review Jonathan Richardson 2 participants 2 messages Feb 18, 2020 – Feb 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fio: remove disabling of compiler optimizations

Disabling compiler optimizations affects fio performance by 25-30% so remove this from EXTRA_OECONF. Disabling of optimizations should be machine specific if there are bugs in the code instead of the default.

Optimizations were removed in this commit:
https://git.openembedded.org/meta-openembedded/commit/?id=739349da0826221f98648b64b693f9ae33e7d4ea

---
 meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 -
 1 file changed, 1 deletion(-)
meta-oe/recipes-benchmark/fio/fio_3.18.bb +0 -1
index b6484290f..2c461b8c5 100644
@@ -33,7 +33,6 @@ S = "${WORKDIR}/git"
 DISABLE_STATIC = ""
 
 EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
-EXTRA_OECONF = "--disable-optimizations"
 
 do_configure() {
     ./configure ${EXTRA_OECONF}
Signature · 1 line
2.17.1
#1 lore raw
Quoted 18 lines · Jonathan Richardson via Openembedded-devel

Disabling compiler optimizations affects fio performance by 25-30% so remove this from EXTRA_OECONF. Disabling of optimizations should be machine specific if there are bugs in the code instead of the default.

Optimizations were removed in this commit:
https://git.openembedded.org/meta-openembedded/commit/?id=739349da0826221f98648b64b693f9ae33e7d4ea

---
 meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 -
 1 file changed, 1 deletion(-)
meta-oe/recipes-benchmark/fio/fio_3.18.bb +0 -0
index b6484290f..2c461b8c5 100644

meta-oe/recipes-benchmark/fio/fio_3.18.bb S = "${WORKDIR}/git" · line 36

Quoted 5 lines
meta-oe/recipes-benchmark/fio/fio_3.18.bb +0 -1
@@ -33,7 +33,6 @@ S = "${WORKDIR}/git"
 DISABLE_STATIC = ""
 
 EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
-EXTRA_OECONF = "--disable-optimizations"
 

I think Mingli disabled it and I would like to get his feedback before we revert this change

Quoted 10 lines
meta-oe/recipes-benchmark/fio/fio_3.18.bb +0 -1
 do_configure() {
     ./configure ${EXTRA_OECONF}
--

2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel