Convert QCOM watchdog timer bindings to YAML

PATCH Superseded Sai Prakash Ranjan 4 participants 11 messages Feb 11, 2020 – Jun 26, 2020

Subsystems (3)

Device tree bindings Arm Qualcomm mailing list Watchdog device drivers

lore

Share & tools

lore

Sai Prakash Ranjan

author

2020-02-11 22:24 UTC #0 lore raw

v3 cover Convert QCOM watchdog timer bindings to YAML

This series converts QCOM watchdog timer bindings to YAML. Also it adds the missing SoC-specific compatible for QCS404, SC7180, SDM845 and SM8150 SoCs.

v1: https://lore.kernel.org/lkml/[email protected]/
v2: https://lore.kernel.org/lkml/[email protected]/

Changes since v2:
* Add missing compatibles to enum.

Changes since v1:
As per Rob's suggestion:
* Replaced oneOf+const with enum.
* Removed timeout-sec and included watchdog.yaml.
* Removed repeated use of const:qcom,kpss-wdt and made use of enum.

Sai Prakash Ranjan (2):
dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,

    SM8150

 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
 .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml

Signature · 2 lines

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Sai Prakash Ranjan

author

2020-02-11 22:24 UTC #1 lore raw

PATCH v3 1/2 dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML

Convert QCOM watchdog timer bindings to DT schema format using json-schema.

Signed-off-by Sai Prakash Ranjan <[email protected]>

Reviewed-by Stephen Boyd <[email protected]>

Reviewed-by Rob Herring <[email protected]>

---
 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 ------------
 .../bindings/watchdog/qcom-wdt.yaml           | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml

Documentation/devicetree/bindings/watchdog/qcom-wdt.txt deleted +0 ~~-28~~

deleted file mode 100644
index 41aeaa2ff0f8..000000000000
@@ -1,28 +0,0 @@
-Qualcomm Krait Processor Sub-system (KPSS) Watchdog
----------------------------------------------------
-
-Required properties :
-- compatible : shall contain only one of the following:
-
-			"qcom,kpss-wdt-msm8960"
-			"qcom,kpss-wdt-apq8064"
-			"qcom,kpss-wdt-ipq8064"
-			"qcom,kpss-wdt-ipq4019"
-			"qcom,kpss-timer"
-			"qcom,scss-timer"
-			"qcom,kpss-wdt"
-
-- reg : shall contain base register location and length
-- clocks : shall contain the input clock
-
-Optional properties :
-- timeout-sec : shall contain the default watchdog timeout in seconds,
-                if unset, the default timeout is 30 seconds
-
-Example:
-	watchdog@208a038 {
-		compatible = "qcom,kpss-wdt-ipq8064";
-		reg = <0x0208a038 0x40>;
-		clocks = <&sleep_clk>;
-		timeout-sec = <10>;
-	};

Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml new file +44 -0

44 lines not on this page · raw message

Signature · 2 lines

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Sai Prakash Ranjan

author

2020-02-11 22:25 UTC #2 lore raw

PATCH v3 2/2 dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150

In reply to Sai Prakash Ranjan

Add missing compatible for watchdog timer on QCS404, SC7180, SDM845 and SM8150 SoCs.

Signed-off-by Sai Prakash Ranjan <[email protected]>

Reviewed-by Stephen Boyd <[email protected]>

---
 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +4 -0

index 5448cc537a03..0709ddf0b6a5 100644
@@ -15,6 +15,10 @@ allOf:
 properties:
   compatible:
     enum:
+      - qcom,apss-wdt-qcs404
+      - qcom,apss-wdt-sc7180
+      - qcom,apss-wdt-sdm845
+      - qcom,apss-wdt-sm8150
       - qcom,kpss-timer
       - qcom,kpss-wdt
       - qcom,kpss-wdt-apq8064

Signature · 2 lines

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Rob Herring

maintainer Acked-by on v3 2/2

2020-02-18 23:03 UTC #3 lore raw

Re: [PATCHv3 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150

Quoted 9 lines · Sai Prakash Ranjan

Add missing compatible for watchdog timer on QCS404, SC7180, SDM845 and SM8150 SoCs.
Signed-off-by Sai Prakash Ranjan <[email protected]>
Reviewed-by Stephen Boyd <[email protected]>
---
 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Acked-by Rob Herring <[email protected]>

Sai Prakash Ranjan

author

2020-06-17 06:56 UTC #4 lore raw

In reply to Sai Prakash Ranjan

Hi Bjorn,

Quoted 23 lines · Sai Prakash Ranjan

This series converts QCOM watchdog timer bindings to YAML. Also it adds the missing SoC-specific compatible for QCS404, SC7180, SDM845 and SM8150 SoCs.
v1:
https://lore.kernel.org/lkml/[email protected]/
v2:
https://lore.kernel.org/lkml/[email protected]/
Changes since v2:
* Add missing compatibles to enum.
Changes since v1:
As per Rob's suggestion:
* Replaced oneOf+const with enum.
* Removed timeout-sec and included watchdog.yaml.
* Removed repeated use of const:qcom,kpss-wdt and made use of enum.
Sai Prakash Ranjan (2):
dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
    SM8150

Quoted 7 lines

 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
 .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644 
Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644

Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml

Gentle ping!

Thanks,
Sai

Signature · 2 lines

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Bjorn Andersson

2020-06-21 07:36 UTC #5 lore raw

Quoted 2 lines · Sai Prakash Ranjan

Hi Bjorn,

Hi Sai,

Quoted 33 lines · Sai Prakash Ranjan

Quoted 23 lines
This series converts QCOM watchdog timer bindings to YAML. Also it adds the missing SoC-specific compatible for QCS404, SC7180, SDM845 and SM8150 SoCs.
v1:
https://lore.kernel.org/lkml/[email protected]/
v2:
https://lore.kernel.org/lkml/[email protected]/
Changes since v2:
* Add missing compatibles to enum.
Changes since v1:
As per Rob's suggestion:
* Replaced oneOf+const with enum.
* Removed timeout-sec and included watchdog.yaml.
* Removed repeated use of const:qcom,kpss-wdt and made use of enum.
Sai Prakash Ranjan (2):
dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
    SM8150
Quoted 7 lines
 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
 .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644
Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml

Quoted 2 lines

Gentle ping!

This should better go through the watchdog tree, so I believe Guenter would be the one to pick this up.

Regards,
Bjorn

Quoted 6 lines

Thanks,
Sai

Signature · 2 lines

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Sai Prakash Ranjan

author

2020-06-22 06:20 UTC #6 lore raw

Quoted 40 lines · Bjorn Andersson

Quoted 2 lines · Sai Prakash Ranjan
Hi Bjorn,
Hi Sai,
Quoted 33 lines · Sai Prakash Ranjan
Quoted 30 lines
This series converts QCOM watchdog timer bindings to YAML. Also it adds the missing SoC-specific compatible for QCS404, SC7180, SDM845 and SM8150 SoCs.
v1:
https://lore.kernel.org/lkml/[email protected]/
v2:
https://lore.kernel.org/lkml/[email protected]/
Changes since v2:
* Add missing compatibles to enum.
Changes since v1:
As per Rob's suggestion:
* Replaced oneOf+const with enum.
* Removed timeout-sec and included watchdog.yaml.
* Removed repeated use of const:qcom,kpss-wdt and made use of enum.
Sai Prakash Ranjan (2):
dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
    SM8150
 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
 .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644
Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml

Quoted 6 lines

Quoted 2 lines
Gentle ping!
This should better go through the watchdog tree, so I believe Guenter would be the one to pick this up.

Ah right, then a gentle ping for Guenter.

Thanks,
Sai

Signature · 2 lines

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Guenter Roeck

maintainer

2020-06-25 16:00 UTC #7 lore raw

Quoted 41 lines · Sai Prakash Ranjan

Quoted 40 lines · Bjorn Andersson
Quoted 2 lines · Sai Prakash Ranjan
Hi Bjorn,
Hi Sai,
Quoted 33 lines · Sai Prakash Ranjan
Quoted 30 lines
This series converts QCOM watchdog timer bindings to YAML. Also it adds the missing SoC-specific compatible for QCS404, SC7180, SDM845 and SM8150 SoCs.
v1:
https://lore.kernel.org/lkml/[email protected]/
v2:
https://lore.kernel.org/lkml/[email protected]/
Changes since v2:
* Add missing compatibles to enum.
Changes since v1:
As per Rob's suggestion:
* Replaced oneOf+const with enum.
* Removed timeout-sec and included watchdog.yaml.
* Removed repeated use of const:qcom,kpss-wdt and made use of enum.
Sai Prakash Ranjan (2):
dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
    SM8150
 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
 .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644
Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml

Quoted 9 lines

Quoted 6 lines
Quoted 2 lines
Gentle ping!
This should better go through the watchdog tree, so I believe Guenter would be the one to pick this up.
Ah right, then a gentle ping for Guenter.

I don't think the watchdog mailing list has been copied on this series, meaning I don't have a copy that I could apply if I wanted to. I also see no evidence for a Reviewed-by: tag from Rob or any other DT maintainer.

Guenter

Sai Prakash Ranjan

author

2020-06-25 19:22 UTC #8 lore raw

Quoted 45 lines · Guenter Roeck

Quoted 44 lines · Sai Prakash Ranjan
Quoted 43 lines · Bjorn Andersson
Quoted 2 lines · Sai Prakash Ranjan
Hi Bjorn,
Hi Sai,
Quoted 35 lines · Sai Prakash Ranjan
Quoted 23 lines
This series converts QCOM watchdog timer bindings to YAML. Also it adds the missing SoC-specific compatible for QCS404, SC7180, SDM845 and SM8150 SoCs.
v1:
https://lore.kernel.org/lkml/[email protected]/
v2:
https://lore.kernel.org/lkml/[email protected]/
Changes since v2:
* Add missing compatibles to enum.
Changes since v1:
As per Rob's suggestion:
* Replaced oneOf+const with enum.
* Removed timeout-sec and included watchdog.yaml.
* Removed repeated use of const:qcom,kpss-wdt and made use of enum.
Sai Prakash Ranjan (2):
dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
    SM8150
Quoted 7 lines
 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
 .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644
Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
Gentle ping!

Quoted 8 lines

Quoted 6 lines
Quoted 3 lines
This should better go through the watchdog tree, so I believe Guenter would be the one to pick this up.
Ah right, then a gentle ping for Guenter.
I don't think the watchdog mailing list has been copied on this series, meaning I don't have a copy that I could apply if I wanted to.

I kept you in CC for all the revisions but missed adding watchdog list. Will resend with the appropriate lists added.

Quoted 3 lines

I also see
no evidence for a Reviewed-by: tag from Rob or any other DT maintainer.

Not sure why you think I would add reviewed-by tag from Rob without him giving one.
But here's the evidence - https://lore.kernel.org/lkml/[email protected]/
This link is also given v3 cover letter.

Thanks,
Sai

Signature · 2 lines

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Guenter Roeck

maintainer

2020-06-25 21:18 UTC #9 lore raw

Quoted 7 lines · Sai Prakash Ranjan

Quoted 3 lines
Quoted 1 line
I don't think the watchdog mailing list has been copied on this series, meaning I don't have a copy that I could apply if I wanted to.
I kept you in CC for all the revisions but missed adding watchdog list. Will resend with the appropriate lists added.

I use patchwork to track patches, tags, and my responses. No patchwork, no patch, no tags, and no tracking.

Quoted 6 lines

Quoted 3 lines
I also see
no evidence for a Reviewed-by: tag from Rob or any other DT maintainer.
Not sure why you think I would add reviewed-by tag from Rob without him giving one.

Same response as above.

Guenter

Sai Prakash Ranjan

author

2020-06-26 06:07 UTC #10 lore raw

Quoted 5 lines · Guenter Roeck

Quoted 4 lines · Sai Prakash Ranjan
Quoted 3 lines
Quoted 1 line
I don't think the watchdog mailing list has been copied on this series, meaning I don't have a copy that I could apply if I wanted to.

Quoted 7 lines

Quoted 3 lines
I kept you in CC for all the revisions but missed adding watchdog list. Will resend with the appropriate lists added.
I use patchwork to track patches, tags, and my responses. No patchwork, no patch, no tags, and no tracking.

Now resent with watchdog list added - https://lore.kernel.org/patchwork/cover/1263944/

Thanks,
Sai

Signature · 2 lines

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation