Skip to contentSkip to conversation

Smiapp driver cleanups, omap3isp fix

GIT PULL Sakari Ailus 2 participants 2 messages Feb 19, 2020 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Mauro,

Here's the usual set of cleanups for the smiapp driver. Also included is a fix for CCDC block handling in the imap3isp driver that completes the previous fix.

Please pull.

The following changes since commit bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9:

Linux 5.6-rc1 (2020-02-09 16:08:48 -0800)

are available in the Git repository at:

git://linuxtv.org/sailus/media_tree.git tags/for-5.7-2-signed

for you to fetch changes up to 0bc49fb661a2024b7dea91697496a303e458a7af:

smiapp: Move definitions under driver directory (2020-02-19 12:18:24 +0200)

----------------------------------------------------------------
Smiapp driver patches for 5.7

----------------------------------------------------------------
Sakari Ailus (7):
omap3isp: Prevent enabling CCDC when stopping streaming
smiapp: Simplify condition for choosing 8-bit access
smiapp: Use unaligned get and put functions
smiapp: Turn limit lookup into a function
smiapp: Move SMIA limit reading up
smiapp: Refactor reading SMIA limits
smiapp: Move definitions under driver directory

 drivers/media/i2c/smiapp/smiapp-core.c    | 259 +++++++++++++++---------------
 drivers/media/i2c/smiapp/smiapp-reg.h     |   4 +
 drivers/media/i2c/smiapp/smiapp-regs.c    |  71 +++-----
 drivers/media/i2c/smiapp/smiapp.h         |  44 ++++-
 drivers/media/platform/omap3isp/ispccdc.c |   4 +
 include/media/i2c/smiapp.h                |  63 --------
 6 files changed, 200 insertions(+), 245 deletions(-)
 delete mode 100644 include/media/i2c/smiapp.h
Signature · 1 line
Sakari Ailus
#1 lore raw

From: [email protected]

Pull request: https://patchwork.linuxtv.org/patch/61722/
Build log: https://builder.linuxtv.org/job/patchwork/38795/
Build time: 00:04:25

gpg: Signature made Wed 19 Feb 2020 10:24:28 AM UTC
gpg:                using DSA key F0D0377A0D4F25A79238EFE56D40361B6E28C193
gpg:                issuer "[email protected]"
gpg: Good signature from "Sakari Ailus <[email protected]>" [full]

Summary: 3 patches and/or PDF generation with issues, being 0 at build time

Error/warnings:

Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:

$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:24: CHECK: Alignment should match open parenthesis
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:84: WARNING: line over 80 characters
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:85: WARNING: line over 80 characters
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:86: WARNING: line over 80 characters
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:87: WARNING: line over 80 characters
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:93: WARNING: line over 80 characters
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:94: WARNING: line over 80 characters
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:95: WARNING: line over 80 characters
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:96: WARNING: line over 80 characters
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:98: WARNING: line over 80 characters
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:331: CHECK: Logical continuations should be on the previous line
patches/0004-smiapp-Turn-limit-lookup-into-a-function.patch:340: CHECK: Logical continuations should be on the previous line

Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0005-smiapp-Move-SMIA-limit-reading-up.patch:

$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0005-smiapp-Move-SMIA-limit-reading-up.patch
patches/0005-smiapp-Move-SMIA-limit-reading-up.patch:31: CHECK: Lines should not end with a '('

Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0007-smiapp-Move-definitions-under-driver-directory.patch:

$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0007-smiapp-Move-definitions-under-driver-directory.patch
patches/0007-smiapp-Move-definitions-under-driver-directory.patch:82: CHECK: Prefer kernel type 'u32' over 'uint32_t'
patches/0007-smiapp-Move-definitions-under-driver-directory.patch:85: CHECK: Prefer kernel type 'u32' over 'uint32_t'
patches/0007-smiapp-Move-definitions-under-driver-directory.patch:86: CHECK: Prefer kernel type 'u64' over 'uint64_t'
patches/0007-smiapp-Move-definitions-under-driver-directory.patch:97: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?