btrfs: remove set but not used variable 'parent'
PATCH 2/3 btrfs: remove set but not used variable 'parent'
Fixes gcc '-Wunused-but-set-variable' warning:
fs/btrfs/tree-log.c: In function ‘walk_down_log_tree’:fs/btrfs/tree-log.c:2702:24: warning: variable ‘parent’ set but not used [-Wunused-but-set-variable] fs/btrfs/tree-log.c: In function ‘walk_up_log_tree’:fs/btrfs/tree-log.c:2803:26: warning: variable ‘parent’ set but not used [-Wunused-but-set-variable]
They are never used, and so can be removed.
--- fs/btrfs/tree-log.c | 9 --------- 1 file changed, 9 deletions(-)
fs/btrfs/tree-log.c +0 -9
@@ -2699,7 +2699,6 @@ static noinline int walk_down_log_tree(struct btrfs_trans_handle *trans,u64 ptr_gen;struct extent_buffer *next;struct extent_buffer *cur; -struct extent_buffer *parent;u32 blocksize;int ret =0 ;
@@ -2719,8 +2718,6 @@ static noinline int walk_down_log_tree(struct btrfs_trans_handle *trans,btrfs_node_key_to_cpu (cur, &first_key, path->slots[*level]); blocksize = fs_info->nodesize; - parent = path->nodes[*level]; - next =btrfs_find_create_tree_block (fs_info, bytenr);if (IS_ERR (next))return PTR_ERR (next);
@@ -2800,12 +2797,6 @@ static noinline int walk_up_log_tree(struct btrfs_trans_handle *trans,WARN_ON (*level ==0 );return 0 ; }else { -struct extent_buffer *parent; -if (path->nodes[*level] == root->node) - parent = path->nodes[*level]; -else - parent = path->nodes[*level +1 ]; - ret = wc->process_func (root, path->nodes[*level], wc,btrfs_header_generation (path->nodes[*level]), *level);
Signature · 1 line
2.17.2
Quoted 9 lines · yu kuai
Fixes gcc '-Wunused-but-set-variable' warning:
fs/btrfs/tree-log.c: In function ‘walk_down_log_tree’:fs/btrfs/tree-log.c:2702:24: warning: variable ‘parent’ set but not used [-Wunused-but-set-variable]fs/btrfs/tree-log.c: In function ‘walk_up_log_tree’:fs/btrfs/tree-log.c:2803:26: warning: variable ‘parent’ set but not used [-Wunused-but-set-variable]
Quoted 3 lines
They are never used, and so can be removed.
Signed-off-by yu kuai <[email protected]>
Ah yes, those two are a result of my :
e084c5ab48f9 ("btrfs: Call btrfs_pin_reserved_extent only during active transaction") (in misc-next branch)
David perhaps you can squash the two var removals into the original patch?
Quoted 14 lines · Nikolay Borisov
Quoted 11 lines · yu kuai
Fixes gcc '-Wunused-but-set-variable' warning:
fs/btrfs/tree-log.c: In function ‘walk_down_log_tree’:fs/btrfs/tree-log.c:2702:24: warning: variable ‘parent’ set but not used [-Wunused-but-set-variable]fs/btrfs/tree-log.c: In function ‘walk_up_log_tree’:fs/btrfs/tree-log.c:2803:26: warning: variable ‘parent’ set but not used [-Wunused-but-set-variable]They are never used, and so can be removed.
Quoted 8 lines
Quoted 1 line
Signed-off-by yu kuai <[email protected]>Ah yes, those two are a result of my :
e084c5ab48f9("btrfs: Callbtrfs_pin_reserved_extentonly during active transaction") (in misc-next branch)David perhaps you can squash the two var removals into the original patch?
Yes I'll do that.