perf stat: Align the output for interval aggregation mode
PATCH 1/1 perf stat: Align the output for interval aggregation mode
There is a slight misalignment in -A -I output.
For example,
perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
# time CPU counts unit events
1.000440863 CPU0 1,068,388 cpu/event=cpu-cycles/
1.000440863 CPU1 875,954 cpu/event=cpu-cycles/
1.000440863 CPU2 3,072,538 cpu/event=cpu-cycles/
1.000440863 CPU3 4,026,870 cpu/event=cpu-cycles/
1.000440863 CPU4 5,919,630 cpu/event=cpu-cycles/
1.000440863 CPU5 2,714,260 cpu/event=cpu-cycles/
1.000440863 CPU6 2,219,240 cpu/event=cpu-cycles/
1.000440863 CPU7 1,299,232 cpu/event=cpu-cycles/The value of counts is not aligned with the column "counts" and the event name is not aligned with the column "events".
With this patch, the output is,
perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
# time CPU counts unit events
1.000423009 CPU0 997,421 cpu/event=cpu-cycles/
1.000423009 CPU1 1,422,042 cpu/event=cpu-cycles/
1.000423009 CPU2 484,651 cpu/event=cpu-cycles/
1.000423009 CPU3 525,791 cpu/event=cpu-cycles/
1.000423009 CPU4 1,370,100 cpu/event=cpu-cycles/
1.000423009 CPU5 442,072 cpu/event=cpu-cycles/
1.000423009 CPU6 205,643 cpu/event=cpu-cycles/
1.000423009 CPU7 1,302,250 cpu/event=cpu-cycles/Now output is aligned.
--- tools/perf/util/stat-display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/util/stat-display.c +3 -3
@@ -114,11 +114,11 @@ static void aggr_printout(struct perf_stat_config *config,fprintf (config->output,"S%d-D%d-C%*d%s" ,cpu_map__id_to_socket (id),cpu_map__id_to_die (id), - config->csv_output ?0 :-5 , + config->csv_output ?0 :-3 ,cpu_map__id_to_cpu (id), config->csv_sep); }else { -fprintf (config->output,"CPU%*d%s " , - config->csv_output ?0 :-5 , +fprintf (config->output,"CPU%*d%s" , + config->csv_output ?0 :-7 ,evsel__cpus (evsel)->map[id], config->csv_sep); }
Signature · 1 line
2.17.1
Quoted 33 lines · Jin Yao
There is a slight misalignment in -A -I output.
For example,
perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
# time CPU counts unit events
1.000440863 CPU0 1,068,388 cpu/event=cpu-cycles/ 1.000440863 CPU1 875,954 cpu/event=cpu-cycles/ 1.000440863 CPU2 3,072,538 cpu/event=cpu-cycles/ 1.000440863 CPU3 4,026,870 cpu/event=cpu-cycles/ 1.000440863 CPU4 5,919,630 cpu/event=cpu-cycles/ 1.000440863 CPU5 2,714,260 cpu/event=cpu-cycles/ 1.000440863 CPU6 2,219,240 cpu/event=cpu-cycles/ 1.000440863 CPU7 1,299,232 cpu/event=cpu-cycles/The value of counts is not aligned with the column "counts" and the event name is not aligned with the column "events".
With this patch, the output is,
perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
# time CPU counts unit events
1.000423009 CPU0 997,421 cpu/event=cpu-cycles/ 1.000423009 CPU1 1,422,042 cpu/event=cpu-cycles/ 1.000423009 CPU2 484,651 cpu/event=cpu-cycles/ 1.000423009 CPU3 525,791 cpu/event=cpu-cycles/ 1.000423009 CPU4 1,370,100 cpu/event=cpu-cycles/ 1.000423009 CPU5 442,072 cpu/event=cpu-cycles/ 1.000423009 CPU6 205,643 cpu/event=cpu-cycles/ 1.000423009 CPU7 1,302,250 cpu/event=cpu-cycles/
Quoted 3 lines
Now output is aligned.
Signed-off-by Jin Yao <[email protected]>
thanks,
jirka
Quoted 26 lines
--- tools/perf/util/stat-display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)tools/perf/util/stat-display.c +3
-3@@ -114,11 +114,11 @@ static void aggr_printout(struct perf_stat_config *config,fprintf (config->output,"S%d-D%d-C%*d%s" ,cpu_map__id_to_socket (id),cpu_map__id_to_die (id), - config->csv_output ?0 :-5 , + config->csv_output ?0 :-3 ,cpu_map__id_to_cpu (id), config->csv_sep); }else { -fprintf (config->output,"CPU%*d%s " , - config->csv_output ?0 :-5 , +fprintf (config->output,"CPU%*d%s" , + config->csv_output ?0 :-7 ,evsel__cpus (evsel)->map[id], config->csv_sep); }Signature · 1 line
2.17.1
Em Thu, Feb 20, 2020 at 11:53:55AM +0100, Jiri Olsa escreveu:
Quoted 34 lines · Jin Yao
Quoted 33 lines
There is a slight misalignment in -A -I output.
For example,
perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
# time CPU counts unit events
1.000440863 CPU0 1,068,388 cpu/event=cpu-cycles/ 1.000440863 CPU1 875,954 cpu/event=cpu-cycles/ 1.000440863 CPU2 3,072,538 cpu/event=cpu-cycles/ 1.000440863 CPU3 4,026,870 cpu/event=cpu-cycles/ 1.000440863 CPU4 5,919,630 cpu/event=cpu-cycles/ 1.000440863 CPU5 2,714,260 cpu/event=cpu-cycles/ 1.000440863 CPU6 2,219,240 cpu/event=cpu-cycles/ 1.000440863 CPU7 1,299,232 cpu/event=cpu-cycles/The value of counts is not aligned with the column "counts" and the event name is not aligned with the column "events".
With this patch, the output is,
perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
# time CPU counts unit events
1.000423009 CPU0 997,421 cpu/event=cpu-cycles/ 1.000423009 CPU1 1,422,042 cpu/event=cpu-cycles/ 1.000423009 CPU2 484,651 cpu/event=cpu-cycles/ 1.000423009 CPU3 525,791 cpu/event=cpu-cycles/ 1.000423009 CPU4 1,370,100 cpu/event=cpu-cycles/ 1.000423009 CPU5 442,072 cpu/event=cpu-cycles/ 1.000423009 CPU6 205,643 cpu/event=cpu-cycles/ 1.000423009 CPU7 1,302,250 cpu/event=cpu-cycles/
Quoted 5 lines
Quoted 3 lines
Now output is aligned.
Signed-off-by Jin Yao <[email protected]>Acked-by Jiri Olsa <[email protected]>
thanks, tested and applied.
- Arnaldo
The following commit has been merged into the perf/urgent branch of tip:
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: d13e9e413e5b470c4364bbbce559383081201811 Gitweb: https://git.kernel.org/tip/d13e9e413e5b470c4364bbbce559383081201811 Author: Jin Yao <[email protected]> AuthorDate: Tue, 18 Feb 2020 15:16:14 +08:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Tue, 24 Mar 2020 09:37:27 -03:00
perf stat: Align the output for interval aggregation mode
There is a slight misalignment in -A -I output.
For example:
# perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
# time CPU counts unit events
1.000440863 CPU0 1,068,388 cpu/event=cpu-cycles/
1.000440863 CPU1 875,954 cpu/event=cpu-cycles/
1.000440863 CPU2 3,072,538 cpu/event=cpu-cycles/
1.000440863 CPU3 4,026,870 cpu/event=cpu-cycles/
1.000440863 CPU4 5,919,630 cpu/event=cpu-cycles/
1.000440863 CPU5 2,714,260 cpu/event=cpu-cycles/
1.000440863 CPU6 2,219,240 cpu/event=cpu-cycles/
1.000440863 CPU7 1,299,232 cpu/event=cpu-cycles/The value of counts is not aligned with the column "counts" and the event name is not aligned with the column "events".
With this patch, the output is,
# perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
# time CPU counts unit events
1.000423009 CPU0 997,421 cpu/event=cpu-cycles/
1.000423009 CPU1 1,422,042 cpu/event=cpu-cycles/
1.000423009 CPU2 484,651 cpu/event=cpu-cycles/
1.000423009 CPU3 525,791 cpu/event=cpu-cycles/
1.000423009 CPU4 1,370,100 cpu/event=cpu-cycles/
1.000423009 CPU5 442,072 cpu/event=cpu-cycles/
1.000423009 CPU6 205,643 cpu/event=cpu-cycles/
1.000423009 CPU7 1,302,250 cpu/event=cpu-cycles/Now output is aligned.
--- tools/perf/util/stat-display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/util/stat-display.c +3 -3
@@ -115,11 +115,11 @@ static void aggr_printout(struct perf_stat_config *config,fprintf (config->output,"S%d-D%d-C%*d%s" ,cpu_map__id_to_socket (id),cpu_map__id_to_die (id), - config->csv_output ?0 :-5 , + config->csv_output ?0 :-3 ,cpu_map__id_to_cpu (id), config->csv_sep); }else { -fprintf (config->output,"CPU%*d%s " , - config->csv_output ?0 :-5 , +fprintf (config->output,"CPU%*d%s" , + config->csv_output ?0 :-7 ,evsel__cpus (evsel)->map[id], config->csv_sep); }