Skip to contentSkip to conversation

Reduce Docker images size

PATCH In review Ramotowski, Maciej 3 participants 3 messages Feb 20, 2020 – Feb 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Reduce Docker images size

Cc Arkadiusz Hiler <[email protected]>
Cc Oleg Vasilev <[email protected]>
Cc Petri Latvala <[email protected]>
---
 Dockerfile.build-debian         | 39 ++++++++----------
 Dockerfile.build-debian-arm64   | 68 +++++++++++++++-----------------
 Dockerfile.build-debian-armhf   | 67 +++++++++++++++----------------
 Dockerfile.build-debian-minimal | 44 ++++++++++-----------
 Dockerfile.build-debian-mips    | 70 +++++++++++++++------------------
 5 files changed, 132 insertions(+), 156 deletions(-)
Dockerfile.build-debian +17 -22
index b143a532..6cf7a1f0 100644
@@ -7,25 +7,20 @@ FROM $CI_REGISTRY_IMAGE/build-debian-minimal:commit-$CI_COMMIT_SHA
 # just few extra dependencies for building IGT with all the optional components
 # enabled
 
-RUN apt-get update
-RUN apt-get install -y \
-			libunwind-dev \
-			libgsl-dev \
-			libasound2-dev \
-			libxmlrpc-core-c3-dev \
-			libjson-c-dev \
-			libcurl4-openssl-dev \
-			python-docutils \
-			valgrind \
-			peg \
-			libdrm-intel1
-
-# autotools build deps
-RUN apt-get install -y \
-			autoconf \
-			automake \
-			xutils-dev \
-			libtool \
-			make
-
-RUN apt-get clean
+RUN apt-get update && apt-get install -y \
+    autoconf \
+    automake \
+    libasound2-dev \
+    libcurl4-openssl-dev \
+    libdrm-intel1 \
+    libgsl-dev \
+    libjson-c-dev \
+    libtool \
+    libunwind-dev \
+    libxmlrpc-core-c3-dev \
+    make \
+    peg \
+    python-docutils \
+    valgrind \
+    xutils-dev \
+ && rm -rf /var/lib/apt/lists/*
Dockerfile.build-debian-arm64 +31 -37

71 lines not on this page · raw message

Dockerfile.build-debian-armhf +31 -36

70 lines not on this page · raw message

Dockerfile.build-debian-minimal +21 -23

46 lines not on this page · raw message

Dockerfile.build-debian-mips +32 -38

74 lines not on this page · raw message

Signature · 5 lines
2.17.1
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Reduce Docker images size

== Series Details ==

== Series Details ==

Series: Reduce Docker images size
URL : https://patchwork.freedesktop.org/series/73717/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7973 -> IGTPW_4197
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/index.html

New tests
---------

New tests have been introduced between CI_DRM_7973 and IGTPW_4197:

### New IGT tests (4) ###

* igt@i915_pm_backlight@basic-brightness:
- Statuses : 1 dmesg-warn(s) 17 pass(s) 24 skip(s)
- Exec time: [0.0, 0.23] s

* igt@i915_pm_rpm@basic-pci-d3-state:
- Statuses : 1 dmesg-warn(s) 30 pass(s) 11 skip(s)
- Exec time: [0.0, 6.85] s

* igt@i915_pm_rpm@basic-rte:
- Statuses : 1 dmesg-warn(s) 30 pass(s) 11 skip(s)
- Exec time: [0.44, 24.41] s

* igt@i915_pm_rps@basic-api:
- Statuses : 37 pass(s) 5 skip(s)
- Exec time: [0.0, 0.02] s

Known issues
------------

Here are the changes found in IGTPW_4197 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_close_race@basic-threads:
- fi-hsw-4770: [PASS][1] -> [TIMEOUT][2] ([fdo#112271] / [i915#1084])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-hsw-4770/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/fi-hsw-4770/igt@[email protected]

* igt@i915_getparams_basic@basic-subslice-total:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([CI#94] / [i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/fi-tgl-y/igt@[email protected]

* igt@i915_selftest@live_gem_contexts:
- fi-cfl-guc: [PASS][5] -> [INCOMPLETE][6] ([fdo#106070] / [i915#424])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html

* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-bsw-n3050: [PASS][7] -> [FAIL][8] ([i915#34])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html

#### Possible fixes ####

* igt@i915_selftest@live_sanitycheck:
- fi-icl-u3: [DMESG-WARN][9] ([i915#585]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [FAIL][11] ([i915#217]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-icl-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/fi-icl-u2/igt@[email protected]
- fi-kbl-7500u: [FAIL][13] ([fdo#111407]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-kbl-7500u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/fi-kbl-7500u/igt@[email protected]

* igt@prime_self_import@basic-llseek-bad:
- fi-tgl-y: [DMESG-WARN][15] ([CI#94] / [i915#402]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-tgl-y/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/fi-tgl-y/igt@[email protected]

#### Warnings ####

* igt@amdgpu/amd_prime@amd-to-i915:
- fi-icl-u3: [SKIP][17] ([fdo#109315]) -> [SKIP][18] ([fdo#109315] / [i915#585])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-icl-u3/igt@amdgpu/[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/fi-icl-u3/igt@amdgpu/[email protected]

[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#585]: https://gitlab.freedesktop.org/drm/intel/issues/585

Participating hosts (49 -> 45)
------------------------------

Additional (4): fi-kbl-soraka fi-skl-lmem fi-ivb-3770 fi-pnv-d510
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5453 -> IGTPW_4197

CI-20190529: 20190529
CI_DRM_7973: 07350317e4b2be54b1de7f1e73f77875df5e43f3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4197: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/index.html
IGT_5453: cae9a5881ed2c5be2c2518a255740b612a927f9a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4197/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw
In reply to Ramotowski, Maciej

Prefix the title with ".gitlab-ci:". If you look at git log here or in the kernel repo you will notice that this is a common practice - it clarifies what part of the project you are touching.

Quoted 5 lines · Maciej
Cc Arkadiusz Hiler <[email protected]>
Cc Oleg Vasilev <[email protected]>
Cc Petri Latvala <[email protected]>

---

Some context in the commit message would be nice. Try to explain the reason for your changes addressing the explanation to people who know what docker is but are not very savvy in it.

Quoted 5 lines
 Dockerfile.build-debian         | 39 ++++++++----------
 Dockerfile.build-debian-arm64   | 68 +++++++++++++++-----------------
 Dockerfile.build-debian-armhf   | 67 +++++++++++++++----------------
 Dockerfile.build-debian-minimal | 44 ++++++++++-----------
 Dockerfile.build-debian-mips    | 70 +++++++++++++++------------------

What about Dockerfile.build-fedora ?

Quoted 39 lines
 5 files changed, 132 insertions(+), 156 deletions(-)
Dockerfile.build-debian +7 -22
index b143a532..6cf7a1f0 100644
@@ -7,25 +7,20 @@ FROM $CI_REGISTRY_IMAGE/build-debian-minimal:commit-$CI_COMMIT_SHA
 # just few extra dependencies for building IGT with all the optional components
 # enabled
 
-RUN apt-get update
-RUN apt-get install -y \
-			libunwind-dev \
-			libgsl-dev \
-			libasound2-dev \
-			libxmlrpc-core-c3-dev \
-			libjson-c-dev \
-			libcurl4-openssl-dev \
-			python-docutils \
-			valgrind \
-			peg \
-			libdrm-intel1
-
-# autotools build deps
-RUN apt-get install -y \
-			autoconf \
-			automake \
-			xutils-dev \
-			libtool \
-			make
-
-RUN apt-get clean
+RUN apt-get update && apt-get install -y \
+    autoconf \
+    automake \
+    libasound2-dev \
+    libcurl4-openssl-dev \
+    libdrm-intel1 \
+    libgsl-dev \

Dockerfile.build-debian FROM $CI_REGISTRY_IMAGE/build-debian-minimal:commit-$CI_COMMIT_SHA · line 26

Quoted 10 lines
Dockerfile.build-debian +10 -0
+    libjson-c-dev \
+    libtool \
+    libunwind-dev \
+    libxmlrpc-core-c3-dev \
+    make \
+    peg \
+    python-docutils \
+    valgrind \
+    xutils-dev \
+ && rm -rf /var/lib/apt/lists/*

So bundling all the commands in a single RUN instruction doesn't make much difference because the base images are build with --squash (see .gitlab-ci/pull-or-rebuild.sh) and there is no build cache enabled on freedesktop's gitlab.

However this change makes the desired behavior a bit more portable :-)

The main difference is this rm -fr ... which makes the image 327.47 MiB compared to the old 340.31 MiB (+/- the margin of error caused by having packages that are 3 months fresher).

It would be nice to have that captured in the commit message.

Signature · 7 lines
Cheers,
Arek

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev