Skip to contentSkip to conversation

docs: Fix empty parallelism argument

PATCH Applied Kees Cook 2 participants 2 messages Feb 22, 2020 – Feb 25, 2020

Subsystems (2)
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 docs: Fix empty parallelism argument

When there was no parallelism (no top-level -j arg and a pre-1.7 sphinx-build), the argument passed would be empty ("") instead of just being missing, which would (understandably) badly confuse sphinx-build. Fix this by removing the quotes.

Fixes 51e46c7a4007 ("docs, parallelism: Rearrange how jobserver reservations are made")
---
 Documentation/sphinx/parallel-wrapper.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/sphinx/parallel-wrapper.sh +1 -1
index 7daf5133bdd3..e54c44ce117d 100644
@@ -30,4 +30,4 @@ if [ -n "$parallel" ] ; then
 	parallel="-j$parallel"
 fi
 
-exec "$sphinx" "$parallel" "$@"
+exec "$sphinx" $parallel "$@"
Signature · 5 lines
2.20.1


-- 
Kees Cook
maintainer Applied
#1 lore raw
Quoted 8 lines · On Fri, 21 Feb 2020 16:02:39 -0800 Kees Cook <[email protected]> wrote:

When there was no parallelism (no top-level -j arg and a pre-1.7 sphinx-build), the argument passed would be empty ("") instead of just being missing, which would (understandably) badly confuse sphinx-build. Fix this by removing the quotes.

Fixes 51e46c7a4007 ("docs, parallelism: Rearrange how jobserver reservations are made")

Applied, thanks for fixing this.

jon