Skip to contentSkip to conversation

package/radvd: disable by default in systemd preset-all

PATCH New unixmania at gmail.com 2 participants 2 messages Feb 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/radvd: disable by default in systemd preset-all

From: Carlos Santos <[email protected]>

We don't provide a configuration file, so disable radvd by default.

Update the help message with instructions on how to enable radvd at build time with systemd.

---
 package/radvd/50-radvd.preset | 1 +
 package/radvd/Config.in       | 8 ++++++++
 package/radvd/radvd.mk        | 6 ++++++
 3 files changed, 15 insertions(+)
 create mode 100644 package/radvd/50-radvd.preset
package/radvd/50-radvd.preset new file +1 -0
new file mode 100644
index 0000000000..90d0ee4bbc
@@ -0,0 +1 @@
+disable radvd.service
package/radvd/Config.in +8 -0
index 48aeedc08f..fa5a20c4c1 100644
@@ -5,4 +5,12 @@ config BR2_PACKAGE_RADVD
 	help
 	  IPv6 Router Advertisement Daemon.
 
+	  On busybox and sysvinit systems, radvd will be started only if
+	  a /etc/radvd.conf exists.
+
+	  To enable it at build time with systemd, add /etc/radvd.conf
+	  and a /etc/systemd/system-preset/40-radvd.preset file with
+
+	    enable radvd.service
+
 	  http://www.litech.org/radvd/
package/radvd/radvd.mk +6 -0
index 5679e613d4..3358264f18 100644
@@ -17,6 +17,12 @@ RADVD_AUTORECONF = YES
 RADVD_LICENSE = BSD-4-Clause-like
 RADVD_LICENSE_FILES = COPYRIGHT
 
+# We don't provide /etc/radvd.conf, so disable the service by default.
+define RADVD_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 0644 package/radvd/50-radvd.preset \
+		$(TARGET_DIR)/usr/lib/systemd/system-preset/50-radvd.preset
+endef
+
 define RADVD_INSTALL_INIT_SYSV
 	$(INSTALL) -D -m 0755 package/radvd/S50radvd $(TARGET_DIR)/etc/init.d/S50radvd
 endef
Signature · 1 line
2.18.2
#1 lore raw

PATCH 1/1 package/radvd: disable by default in systemd preset-all

Carlos, All,

On 2020-02-22 11:47 -0300, unixmania at gmail.com spake thusly:

Quoted 8 lines

From: Carlos Santos <[email protected]>

We don't provide a configuration file, so disable radvd by default.

Update the help message with instructions on how to enable radvd at build time with systemd.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 55 lines
---
 package/radvd/50-radvd.preset | 1 +
 package/radvd/Config.in       | 8 ++++++++
 package/radvd/radvd.mk        | 6 ++++++
 3 files changed, 15 insertions(+)
 create mode 100644 package/radvd/50-radvd.preset
package/radvd/50-radvd.preset new file +1 -0
new file mode 100644
index 0000000000..90d0ee4bbc
@@ -0,0 +1 @@
+disable radvd.service
package/radvd/Config.in +8 -0
index 48aeedc08f..fa5a20c4c1 100644
@@ -5,4 +5,12 @@ config BR2_PACKAGE_RADVD
 	help
 	  IPv6 Router Advertisement Daemon.
 
+	  On busybox and sysvinit systems, radvd will be started only if
+	  a /etc/radvd.conf exists.
+
+	  To enable it at build time with systemd, add /etc/radvd.conf
+	  and a /etc/systemd/system-preset/40-radvd.preset file with
+
+	    enable radvd.service
+
 	  http://www.litech.org/radvd/
package/radvd/radvd.mk +6 -0
index 5679e613d4..3358264f18 100644
@@ -17,6 +17,12 @@ RADVD_AUTORECONF = YES
 RADVD_LICENSE = BSD-4-Clause-like
 RADVD_LICENSE_FILES = COPYRIGHT
 
+# We don't provide /etc/radvd.conf, so disable the service by default.
+define RADVD_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 0644 package/radvd/50-radvd.preset \
+		$(TARGET_DIR)/usr/lib/systemd/system-preset/50-radvd.preset
+endef
+
 define RADVD_INSTALL_INIT_SYSV
 	$(INSTALL) -D -m 0755 package/radvd/S50radvd $(TARGET_DIR)/etc/init.d/S50radvd
 endef
Signature · 6 lines
2.18.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'