package/libsvgtiny: fix parallel build
PATCH 1/1 package/libsvgtiny: fix parallel build
Fix previous commit[1] which purpose was to fix parallel build. It didn't work since it assigned $(MAKE1) to LIBSVGTINY_MAKE, but this is a generic-package and building is done using $(MAKE), then LIBSVGTINY_MAKE was ignored. Let's substitute instead $(MAKE) with $(MAKE1) in LIBSVGTINY_BUILD_CMDS.
[1]:
https://git.buildroot.net/buildroot/commit/?id=26d67a2599d6c88facd5178de853fa355244e7c2
Fixes:
http://autobuild.buildroot.net/results/67d/67d341c0cc272323d6e231a20796a6848c21d760/
--- package/libsvgtiny/libsvgtiny.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
package/libsvgtiny/libsvgtiny.mk +2 -3
@@ -12,8 +12,6 @@ LIBSVGTINY_DEPENDENCIES = \ libxml2 host-gperf host-pkgconf host-netsurf-buildsystem LIBSVGTINY_LICENSE = MIT LIBSVGTINY_LICENSE_FILES = README -# Package does not build in parallel due to improper make rules -LIBSVGTINY_MAKE = $(MAKE1) # The libsvgtiny build system cannot build both the shared and static # libraries. So when the Buildroot configuration requests to build
@@ -29,7 +27,8 @@ define LIBSVGTINY_CONFIGURE_CMDS endef define LIBSVGTINY_BUILD_CMDS - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=/usr \ +# Use $(MAKE1) since parallel build fails + $(TARGET_CONFIGURE_OPTS) $(MAKE1) -C $(@D) PREFIX=/usr \ COMPONENT_TYPE=$(LIBSVGTINY_COMPONENT_TYPE) endef
Signature · 1 line
2.20.1
PATCH 1/1 package/libsvgtiny: fix parallel build
Hi Giulio,
Le 22/02/2020 ? 22:44, Giulio Benetti a ?crit?:
Quoted 5 lines
Fix previous commit[1] which purpose was to fix parallel build. It didn't work since it assigned $(MAKE1) to
LIBSVGTINY_MAKE, but this is a generic-package and building is done using $(MAKE), thenLIBSVGTINY_MAKEwas ignored. Let's substitute instead $(MAKE) with $(MAKE1) inLIBSVGTINY_BUILD_CMDS.
Nice catch!
Quoted 26 lines
[1]:
https://git.buildroot.net/buildroot/commit/?id=26d67a2599d6c88facd5178de853fa355244e7c2Fixes:
http://autobuild.buildroot.net/results/67d/67d341c0cc272323d6e231a20796a6848c21d760/Signed-off-by Giulio Benetti <[email protected]>--- package/libsvgtiny/libsvgtiny.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)package/libsvgtiny/libsvgtiny.mk +0
-2@@ -12,8 +12,6 @@ LIBSVGTINY_DEPENDENCIES = \ libxml2 host-gperf host-pkgconf host-netsurf-buildsystem LIBSVGTINY_LICENSE = MIT LIBSVGTINY_LICENSE_FILES = README -# Package does not build in parallel due to improper make rules -LIBSVGTINY_MAKE = $(MAKE1) # The libsvgtiny build system cannot build both the shared and static # libraries. So when the Buildroot configuration requests to build
package/libsvgtiny/libsvgtiny.mk define LIBSVGTINY_CONFIGURE_CMDS · line 28
Quoted 2 lines
package/libsvgtiny/libsvgtiny.mk +0
-0@@ -29,7 +27,8 @@ define LIBSVGTINY_CONFIGURE_CMDS endef
(*) here.
package/libsvgtiny/libsvgtiny.mk define LIBSVGTINY_CONFIGURE_CMDS · line 32
Quoted 2 lines
package/libsvgtiny/libsvgtiny.mk +0
-1define LIBSVGTINY_BUILD_CMDS - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=/usr \
Usually comments are outside of the define (*)
package/libsvgtiny/libsvgtiny.mk define LIBSVGTINY_CONFIGURE_CMDS · line 32
Quoted 3 lines
package/libsvgtiny/libsvgtiny.mk +2
-0+# Use $(MAKE1) since parallel build fails + $(TARGET_CONFIGURE_OPTS) $(MAKE1) -C $(@D) PREFIX=/usr \ COMPONENT_TYPE=$(LIBSVGTINY_COMPONENT_TYPE)
I would add MAKE1 for other steps (LIBSVGTINY_INSTALL_STAGING_CMDS and LIBSVGTINY_INSTALL_TARGET_CMDS).
Best regards,
Romain
Quoted 3 lines
package/libsvgtiny/libsvgtiny.mk +0
-0endef
PATCH 1/1 package/libsvgtiny: fix parallel build
Quoted 10 lines · Romain Naour
Hi Giulio,
Le 22/02/2020 ? 22:44, Giulio Benetti a ?crit?:
Quoted 5 lines
Fix previous commit[1] which purpose was to fix parallel build. It didn't work since it assigned $(MAKE1) to
LIBSVGTINY_MAKE, but this is a generic-package and building is done using $(MAKE), thenLIBSVGTINY_MAKEwas ignored. Let's substitute instead $(MAKE) with $(MAKE1) inLIBSVGTINY_BUILD_CMDS.Nice catch!
Thanks for reviewing :-)
Quoted 32 lines
Quoted 26 lines
[1]:
https://git.buildroot.net/buildroot/commit/?id=26d67a2599d6c88facd5178de853fa355244e7c2Fixes:
http://autobuild.buildroot.net/results/67d/67d341c0cc272323d6e231a20796a6848c21d760/Signed-off-by Giulio Benetti <[email protected]>--- package/libsvgtiny/libsvgtiny.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)package/libsvgtiny/libsvgtiny.mk +0
-2@@ -12,8 +12,6 @@ LIBSVGTINY_DEPENDENCIES = \ libxml2 host-gperf host-pkgconf host-netsurf-buildsystem LIBSVGTINY_LICENSE = MIT LIBSVGTINY_LICENSE_FILES = README -# Package does not build in parallel due to improper make rules -LIBSVGTINY_MAKE = $(MAKE1) # The libsvgtiny build system cannot build both the shared and static # libraries. So when the Buildroot configuration requests to buildpackage/libsvgtiny/libsvgtiny.mk define LIBSVGTINY_CONFIGURE_CMDS · line 28
Quoted 2 lines
package/libsvgtiny/libsvgtiny.mk +0
-0@@ -29,7 +27,8 @@ define LIBSVGTINY_CONFIGURE_CMDS endef(*) here.
package/libsvgtiny/libsvgtiny.mk define LIBSVGTINY_CONFIGURE_CMDS · line 32
Quoted 2 lines
package/libsvgtiny/libsvgtiny.mk +0
-1define LIBSVGTINY_BUILD_CMDS - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=/usr \Usually comments are outside of the define (*)
Quoted 6 lines
package/libsvgtiny/libsvgtiny.mk define LIBSVGTINY_CONFIGURE_CMDS · line 32
Quoted 3 lines
package/libsvgtiny/libsvgtiny.mk +2
-0+# Use $(MAKE1) since parallel build fails + $(TARGET_CONFIGURE_OPTS) $(MAKE1) -C $(@D) PREFIX=/usr \ COMPONENT_TYPE=$(LIBSVGTINY_COMPONENT_TYPE)I would add MAKE1 for other steps (
LIBSVGTINY_INSTALL_STAGING_CMDSandLIBSVGTINY_INSTALL_TARGET_CMDS).
Yann already fixed everything and applied.
Best regards
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 13 lines
Best regards,
Romainpackage/libsvgtiny/libsvgtiny.mk define LIBSVGTINY_CONFIGURE_CMDS · line 34
Quoted 3 lines
package/libsvgtiny/libsvgtiny.mk +0
-0endef_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Yann E. MORIN
AppliedPATCH 1/1 package/libsvgtiny: fix parallel build
In reply to Giulio BenettiGiulio, All,
On 2020-02-22 22:44 +0100, Giulio Benetti spake thusly:
Quoted 6 lines
Fix previous commit[1] which purpose was to fix parallel build. It didn't work since it assigned $(MAKE1) to
LIBSVGTINY_MAKE, but this is a generic-package and building is done using $(MAKE), thenLIBSVGTINY_MAKEwas ignored. Let's substitute instead $(MAKE) with $(MAKE1) inLIBSVGTINY_BUILD_CMDS.
Quoted 7 lines
[1]:
https://git.buildroot.net/buildroot/commit/?id=26d67a2599d6c88facd5178de853fa355244e7c2Fixes:
http://autobuild.buildroot.net/results/67d/67d341c0cc272323d6e231a20796a6848c21d760/Signed-off-by Giulio Benetti <[email protected]>
Applied to master, after fixing the nits noticed by Romain. Thanks!
Regards,
Yann E. MORIN.
Quoted 34 lines
--- package/libsvgtiny/libsvgtiny.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)package/libsvgtiny/libsvgtiny.mk +2
-3@@ -12,8 +12,6 @@ LIBSVGTINY_DEPENDENCIES = \ libxml2 host-gperf host-pkgconf host-netsurf-buildsystem LIBSVGTINY_LICENSE = MIT LIBSVGTINY_LICENSE_FILES = README -# Package does not build in parallel due to improper make rules -LIBSVGTINY_MAKE = $(MAKE1) # The libsvgtiny build system cannot build both the shared and static # libraries. So when the Buildroot configuration requests to build@@ -29,7 +27,8 @@ define LIBSVGTINY_CONFIGURE_CMDS endef define LIBSVGTINY_BUILD_CMDS - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=/usr \ +# Use $(MAKE1) since parallel build fails + $(TARGET_CONFIGURE_OPTS) $(MAKE1) -C $(@D) PREFIX=/usr \ COMPONENT_TYPE=$(LIBSVGTINY_COMPONENT_TYPE) endefSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/libsvgtiny: fix parallel build
Quoted 12 lines · Yann E. MORIN
Giulio, All,
On 2020-02-22 22:44 +0100, Giulio Benetti spake thusly:
Quoted 9 lines
Fix previous commit[1] which purpose was to fix parallel build. It didn't work since it assigned $(MAKE1) to
LIBSVGTINY_MAKE, but this is a generic-package and building is done using $(MAKE), thenLIBSVGTINY_MAKEwas ignored. Let's substitute instead $(MAKE) with $(MAKE1) inLIBSVGTINY_BUILD_CMDS.[1]:
https://git.buildroot.net/buildroot/commit/?id=26d67a2599d6c88facd5178de853fa355244e7c2
Quoted 6 lines
Quoted 4 lines
Fixes:
http://autobuild.buildroot.net/results/67d/67d341c0cc272323d6e231a20796a6848c21d760/Signed-off-by Giulio Benetti <[email protected]>Applied to master, after fixing the nits noticed by Romain. Thanks!
Thank you for fixing!
Kinds regards
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 38 lines
Regards,
Yann E. MORIN.Quoted 34 lines
--- package/libsvgtiny/libsvgtiny.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)package/libsvgtiny/libsvgtiny.mk +2
-3@@ -12,8 +12,6 @@ LIBSVGTINY_DEPENDENCIES = \ libxml2 host-gperf host-pkgconf host-netsurf-buildsystem LIBSVGTINY_LICENSE = MIT LIBSVGTINY_LICENSE_FILES = README -# Package does not build in parallel due to improper make rules -LIBSVGTINY_MAKE = $(MAKE1) # The libsvgtiny build system cannot build both the shared and static # libraries. So when the Buildroot configuration requests to build@@ -29,7 +27,8 @@ define LIBSVGTINY_CONFIGURE_CMDS endef define LIBSVGTINY_BUILD_CMDS - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=/usr \ +# Use $(MAKE1) since parallel build fails + $(TARGET_CONFIGURE_OPTS) $(MAKE1) -C $(@D) PREFIX=/usr \ COMPONENT_TYPE=$(LIBSVGTINY_COMPONENT_TYPE) endefSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 package/libsvgtiny: fix parallel build
In reply to Giulio BenettiQuoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Giulio" == Giulio Benetti <[email protected]> writes:
Fix previous commit[1] which purpose was to fix parallel build. It didn't work since it assigned $(MAKE1) to
LIBSVGTINY_MAKE, but this is a generic-package and building is done using $(MAKE), thenLIBSVGTINY_MAKEwas ignored. Let's substitute instead $(MAKE) with $(MAKE1) inLIBSVGTINY_BUILD_CMDS.
Quoted 7 lines
[1]:
https://git.buildroot.net/buildroot/commit/?id=26d67a2599d6c88facd5178de853fa355244e7c2Fixes:
http://autobuild.buildroot.net/results/67d/67d341c0cc272323d6e231a20796a6848c21d760/Signed-off-by Giulio Benetti <[email protected]>
Committed to 2019.02.x and 2019.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard