Skip to contentSkip to conversation

docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee

PATCH New Baruch Siach 3 participants 3 messages Feb 21, 2020 – Mar 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee

Unlike <PKG>_DEPENDENCIES, <PKG>_PATCH_DEPENDENCIES only guarantees extract and patch of listed dependencies, not build. Make this subtlety more explicit in the documentation.

Cc Thomas De Schampheleire <[email protected]>
---
 docs/manual/adding-packages-generic.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
docs/manual/adding-packages-generic.txt +3 -3
index 59cdb7ffd72d..82d97854dde4 100644
@@ -374,9 +374,9 @@ not and can not work as people would expect it should:
 * +LIBFOO_PATCH_DEPENDENCIES+ lists the dependencies (in terms of
   package name) that are required for the current package to be
   patched. These dependencies are guaranteed to be extracted and
-  patched before the current package is patched. In a similar way,
-  +HOST_LIBFOO_PATCH_DEPENDENCIES+ lists the dependencies for the
-  current host package.
+  patched (but not necessarily be built) before the current package
+  is patched. In a similar way, +HOST_LIBFOO_PATCH_DEPENDENCIES+ lists
+  the dependencies for the current host package.
   This is seldom used; usually, +LIBFOO_DEPENDENCIES+ is what you
   really want to use.
 
Signature · 1 line
2.25.0
#1 lore raw

PATCH 1/1 docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee

Baruch, All,

On 2020-02-21 07:34 +0200, Baruch Siach spake thusly:

Quoted 15 lines

Unlike <PKG>_DEPENDENCIES, <PKG>_PATCH_DEPENDENCIES only guarantees extract and patch of listed dependencies, not build. Make this subtlety more explicit in the documentation.

Cc Thomas De Schampheleire <[email protected]>
---
 docs/manual/adding-packages-generic.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
docs/manual/adding-packages-generic.txt +0 -0
index 59cdb7ffd72d..82d97854dde4 100644

docs/manual/adding-packages-generic.txt not and can not work as people would expect it should: · line 377

Quoted 7 lines
docs/manual/adding-packages-generic.txt +1 -3
@@ -374,9 +374,9 @@ not and can not work as people would expect it should:
 * +LIBFOO_PATCH_DEPENDENCIES+ lists the dependencies (in terms of
   package name) that are required for the current package to be
   patched. These dependencies are guaranteed to be extracted and
-  patched before the current package is patched. In a similar way,
-  +HOST_LIBFOO_PATCH_DEPENDENCIES+ lists the dependencies for the
-  current host package.
+  patched (but not necessarily be built) before the current package

Here I dropped the 'be' in front of 'built'.

Applied to master, thanks! :-)

Regards,
Yann E. MORIN.

Quoted 12 lines
docs/manual/adding-packages-generic.txt +2 -0
+  is patched. In a similar way, +HOST_LIBFOO_PATCH_DEPENDENCIES+ lists
+  the dependencies for the current host package.
   This is seldom used; usually, +LIBFOO_DEPENDENCIES+ is what you
   really want to use.
 
Signature · 6 lines
2.25.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee

In reply to Baruch Siach
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Unlike <PKG>_DEPENDENCIES, <PKG>_PATCH_DEPENDENCIES only guarantees extract and patch of listed dependencies, not build. Make this subtlety more explicit in the documentation.

Cc Thomas De Schampheleire <[email protected]>

Committed to 2019.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard