image_types: fix checksum conversion dependencies
PATCH 1/1 image_types: fix checksum conversion dependencies
From: Bartosz Golaszewski <[email protected]>
Only md5sum and sha256sum tools are provided by HOSTTOOLS. For other checksum utils, the conversions need to depend on coreutils-native.
--- meta/classes/image_types.bbclass | 4 ++++ 1 file changed, 4 insertions(+)
meta/classes/image_types.bbclass +4 -0
@@ -315,6 +315,10 @@ CONVERSION_DEPENDS_lzo = "lzop-native" CONVERSION_DEPENDS_zip = "zip-native" CONVERSION_DEPENDS_zst = "zstd-native" CONVERSION_DEPENDS_sum = "mtd-utils-native" +CONVERSION_DEPENDS_sha1sum = "coreutils-native" +CONVERSION_DEPENDS_sha224sum = "coreutils-native" +CONVERSION_DEPENDS_sha384sum = "coreutils-native" +CONVERSION_DEPENDS_sha512sum = "coreutils-native" CONVERSION_DEPENDS_bmap = "bmap-tools-native" CONVERSION_DEPENDS_u-boot = "u-boot-tools-native" CONVERSION_DEPENDS_vmdk = "qemu-system-native"
Signature · 1 line
2.19.1
Quoted 16 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Only md5sum and sha256sum tools are provided by HOSTTOOLS. For other checksum utils, the conversions need to depend on coreutils-native.
Signed-off-by Bartosz Golaszewski <[email protected]>--- meta/classes/image_types.bbclass | 4 ++++ 1 file changed, 4 insertions(+)meta/classes/image_types.bbclass +0
-0
meta/classes/image_types.bbclass CONVERSION_DEPENDS_lzo = "lzop-native" · line 321
Quoted 7 lines
meta/classes/image_types.bbclass +4
-0@@ -315,6 +315,10 @@ CONVERSION_DEPENDS_lzo = "lzop-native" CONVERSION_DEPENDS_zip = "zip-native" CONVERSION_DEPENDS_zst = "zstd-native" CONVERSION_DEPENDS_sum = "mtd-utils-native" +CONVERSION_DEPENDS_sha1sum = "coreutils-native" +CONVERSION_DEPENDS_sha224sum = "coreutils-native" +CONVERSION_DEPENDS_sha384sum = "coreutils-native" +CONVERSION_DEPENDS_sha512sum = "coreutils-native"
If they are common enough on host distros then perhaps add them to HOSTTOOLS might be better
Quoted 7 lines
meta/classes/image_types.bbclass +0
-1CONVERSION_DEPENDS_bmap = "bmap-tools-native" CONVERSION_DEPENDS_u-boot = "u-boot-tools-native" CONVERSION_DEPENDS_vmdk = "qemu-system-native" --2.19.1
A message that is not in the archive (sent off-list or not yet received): CAMpxmJUQusczgCZro7YXFYB3NCmR_K7Zgk6sp7TDqcRfy=ZRMA@mail.gmail.com
Quoted 33 lines · Bartosz Golaszewski
pon., 24 lut 2020 o 17:07 Khem Raj <[email protected]> napisał(a):
Quoted 4 lines
On Mon, Feb 24, 2020 at 6:15 AM Bartosz Golaszewski <[email protected]>
Quoted 6 lines · wrote:
Quoted 6 lines
From: Bartosz Golaszewski <[email protected]>
Only md5sum and sha256sum tools are provided by HOSTTOOLS. For other checksum utils, the conversions need to depend on coreutils-native.
Quoted 6 lines
Review
Quoted 6 lines
Signed-off-by Bartosz Golaszewski <[email protected]>--- meta/classes/image_types.bbclass | 4 ++++ 1 file changed, 4 insertions(+)(quoted diff) +0
-0b/meta/classes/image_types.bbclass
Quoted 6 lines
Quoted 6 lines
index
f82f1d8862..63ffbac7e6100644meta/classes/image_types.bbclass +0
-0@@ -315,6 +315,10 @@ CONVERSION_DEPENDS_lzo = "lzop-native" CONVERSION_DEPENDS_zip = "zip-native" CONVERSION_DEPENDS_zst = "zstd-native"Quoted 8 lines
meta/classes/image_types.bbclass CONVERSION_DEPENDS_lzo = "lzop-native" · line 321
Quoted 5 lines
meta/classes/image_types.bbclass +4
-0CONVERSION_DEPENDS_sum = "mtd-utils-native" +CONVERSION_DEPENDS_sha1sum = "coreutils-native" +CONVERSION_DEPENDS_sha224sum = "coreutils-native" +CONVERSION_DEPENDS_sha384sum = "coreutils-native" +CONVERSION_DEPENDS_sha512sum = "coreutils-native"If they are common enough on host distros then perhaps add them to
Quoted 7 lines
HOSTTOOLS might be better
Quoted 1 line
They are part of coreutils although I'm not sure how common they are in distros. They're not commonly used in poky recipes so I'd say it's fine for them to use coreutils-native.
If they are in centos7 baseinstall then we should be fine to add it to hosttools
Quoted 3 lines
Bart