Skip to contentSkip to conversation

phy: tegra: xusb: Don't warn on probe defer

PATCH In review Jon Hunter 3 participants 3 messages Feb 24, 2020 – Feb 25, 2020

Subsystems (3)
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH 1/1 phy: tegra: xusb: Don't warn on probe defer

Deferred probe is an expected return value for tegra_fuse_readl(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users.

---
 drivers/phy/tegra/xusb-tegra186.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/phy/tegra/xusb-tegra186.c +3 -1
index 84c27394c181..12d0f3e30dbc 100644
@@ -802,7 +802,9 @@ tegra186_xusb_read_fuse_calibration(struct tegra186_xusb_padctl *padctl)
 
 	err = tegra_fuse_readl(TEGRA_FUSE_SKU_CALIB_0, &value);
 	if (err) {
-		dev_err(dev, "failed to read calibration fuse: %d\n", err);
+		if (err != -EPROBE_DEFER)
+			dev_err(dev, "failed to read calibration fuse: %d\n",
+				err);
 		return err;
 	}
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 8 lines · Jon Hunter

Deferred probe is an expected return value for tegra_fuse_readl(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users.

---
 drivers/phy/tegra/xusb-tegra186.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Kishon,

I already have a couple of PHY subsystem patches from JC and Nagarjuna in a branch in the Tegra tree that I need to resolve a dependency. Do you mind if I pick this up into that branch as well and send it to you as a pull request later on? Say around v5.6-rc6?

Alternatively you could provide an Acked-by and then I can take them all through ARM SoC.

Thierry

Quoted 18 lines
drivers/phy/tegra/xusb-tegra186.c +3 -1
index 84c27394c181..12d0f3e30dbc 100644
@@ -802,7 +802,9 @@ tegra186_xusb_read_fuse_calibration(struct tegra186_xusb_padctl *padctl)
 
 	err = tegra_fuse_readl(TEGRA_FUSE_SKU_CALIB_0, &value);
 	if (err) {
-		dev_err(dev, "failed to read calibration fuse: %d\n", err);
+		if (err != -EPROBE_DEFER)
+			dev_err(dev, "failed to read calibration fuse: %d\n",
+				err);
 		return err;
 	}
 
Signature · 1 line
2.17.1
#2 lore raw

Hi Thierry,

Quoted 10 lines · Thierry Reding
Quoted 8 lines · Jon Hunter

Deferred probe is an expected return value for tegra_fuse_readl(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users.

---
 drivers/phy/tegra/xusb-tegra186.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 6 lines

Kishon,

I already have a couple of PHY subsystem patches from JC and Nagarjuna in a branch in the Tegra tree that I need to resolve a dependency. Do you mind if I pick this up into that branch as well and send it to you as a pull request later on? Say around v5.6-rc6?

You can take this via Tegra tree itself.

-Kishon

Quoted 24 lines

Alternatively you could provide an Acked-by and then I can take them all through ARM SoC.

Thierry

Quoted 18 lines
drivers/phy/tegra/xusb-tegra186.c +3 -1
index 84c27394c181..12d0f3e30dbc 100644
@@ -802,7 +802,9 @@ tegra186_xusb_read_fuse_calibration(struct tegra186_xusb_padctl *padctl)
 
 	err = tegra_fuse_readl(TEGRA_FUSE_SKU_CALIB_0, &value);
 	if (err) {
-		dev_err(dev, "failed to read calibration fuse: %d\n", err);
+		if (err != -EPROBE_DEFER)
+			dev_err(dev, "failed to read calibration fuse: %d\n",
+				err);
 		return err;
 	}
 
Signature · 1 line
2.17.1