Skip to contentSkip to conversation

mmc: make <mmc.h> self-contained

PATCH New Masahiro Yamada 3 participants 3 messages Feb 24, 2020 – Mar 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: make <mmc.h> self-contained

This header uses bd_t without including its definition.

Change it to (struct bd_info), and add the forward declaration to specify it as a structure.

---

 include/mmc.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
include/mmc.h +5 -3
index 71e2e1735a..4bdeb929d7 100644
@@ -15,6 +15,8 @@
 #include <linux/dma-direction.h>
 #include <part.h>
 
+struct bd_info;
+
 #if CONFIG_IS_ENABLED(MMC_HS200_SUPPORT)
 #define MMC_SUPPORTS_TUNING
 #endif
@@ -712,7 +714,7 @@ void mmc_destroy(struct mmc *mmc);
  * @return 0 if OK, -ve on error
  */
 int mmc_unbind(struct udevice *dev);
-int mmc_initialize(bd_t *bis);
+int mmc_initialize(struct bd_info *bis);
 int mmc_init_device(int num);
 int mmc_init(struct mmc *mmc);
 int mmc_send_tuning(struct mmc *mmc, u32 opcode, int *cmd_error);
@@ -857,8 +859,8 @@ void mmc_set_preinit(struct mmc *mmc, int preinit);
 #endif
 
 void board_mmc_power_init(void);
-int board_mmc_init(bd_t *bis);
-int cpu_mmc_init(bd_t *bis);
+int board_mmc_init(struct bd_info *bis);
+int cpu_mmc_init(struct bd_info *bis);
 int mmc_get_env_addr(struct mmc *mmc, int copy, u32 *env_addr);
 # ifdef CONFIG_SYS_MMC_ENV_PART
 extern uint mmc_get_env_part(struct mmc *mmc);
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 mmc: make <mmc.h> self-contained

Quoted 6 lines · Masahiro Yamada

This header uses bd_t without including its definition.

Change it to (struct bd_info), and add the forward declaration to specify it as a structure.

Best Regards,
Jaehoon Chung

Quoted 39 lines

---

 include/mmc.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
include/mmc.h +5 -3
index 71e2e1735a..4bdeb929d7 100644
@@ -15,6 +15,8 @@
 #include <linux/dma-direction.h>
 #include <part.h>
 
+struct bd_info;
+
 #if CONFIG_IS_ENABLED(MMC_HS200_SUPPORT)
 #define MMC_SUPPORTS_TUNING
 #endif
@@ -712,7 +714,7 @@ void mmc_destroy(struct mmc *mmc);
  * @return 0 if OK, -ve on error
  */
 int mmc_unbind(struct udevice *dev);
-int mmc_initialize(bd_t *bis);
+int mmc_initialize(struct bd_info *bis);
 int mmc_init_device(int num);
 int mmc_init(struct mmc *mmc);
 int mmc_send_tuning(struct mmc *mmc, u32 opcode, int *cmd_error);
@@ -857,8 +859,8 @@ void mmc_set_preinit(struct mmc *mmc, int preinit);
 #endif
 
 void board_mmc_power_init(void);
-int board_mmc_init(bd_t *bis);
-int cpu_mmc_init(bd_t *bis);
+int board_mmc_init(struct bd_info *bis);
+int cpu_mmc_init(struct bd_info *bis);
 int mmc_get_env_addr(struct mmc *mmc, int copy, u32 *env_addr);
 # ifdef CONFIG_SYS_MMC_ENV_PART
 extern uint mmc_get_env_part(struct mmc *mmc);
#2 lore raw

PATCH 1/1 mmc: make <mmc.h> self-contained

In reply to Masahiro Yamada
Quoted 7 lines · Masahiro Yamada

This header uses bd_t without including its definition.

Change it to (struct bd_info), and add the forward declaration to specify it as a structure.

Applied to u-boot/next, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200317/d8ed80ad/attachment.sig>