Skip to contentSkip to conversation

xfstests: remove generic/484

PATCH In review Christoph Hellwig 5 participants 5 messages Feb 24, 2020 – Mar 1, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: remove generic/484

Generic/484 tests functionality that isn't really related to file systems, and has failed every since it was added. Remove it as it serves no puropse in xfstests.

---
 tests/generic/484     | 51 -------------------------------------------
 tests/generic/484.out |  2 --
 tests/generic/group   |  1 -
 3 files changed, 54 deletions(-)
 delete mode 100755 tests/generic/484
 delete mode 100644 tests/generic/484.out
tests/generic/484 deleted +0 -51
deleted file mode 100755
index d83380ac..00000000
@@ -1,51 +0,0 @@
-#! /bin/bash
-# SPDX-License-Identifier: GPL-2.0
-# Copyright (c) 2018 Red Hat Inc.  All Rights Reserved.
-#
-# FS QA Test 484
-#
-# POSIX requires that record locks are preserved across an execve(2). But
-# there's bug that record locks are released if process is multithreaded at the
-# time that execve is called.
-#
-# Fixed by patch from Jeff Layton:
-# locks: change POSIX lock ownership on execve when files_struct is displaced
-#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "QA output created by $seq"
-
-here=`pwd`
-tmp=/tmp/$$
-status=1	# failure is the default!
-trap "_cleanup; exit \$status" 0 1 2 3 15
-
-_cleanup()
-{
-	cd /
-	rm -f $tmp.*
-}
-
-# get standard environment, filters and checks
-. ./common/rc
-. ./common/filter
-
-# remove previous $seqres.full before test
-rm -f $seqres.full
-
-# real QA test starts here
-_supported_fs generic
-_supported_os Linux
-_require_test
-_require_test_program "t_locks_execve"
-
-# prepare a 4k testfile in TEST_DIR
-$XFS_IO_PROG -f -c "pwrite -S 0xFF 0 4096" \
-	$TEST_DIR/t_lock_execve_file >> $seqres.full 2>&1
-
-$here/src/t_locks_execve $TEST_DIR/t_lock_execve_file
-
-# success, all done
-echo "Silence is golden"
-status=0
-exit
tests/generic/484.out deleted +0 -2
deleted file mode 100644
index 94f2f0bd..00000000
@@ -1,2 +0,0 @@
-QA output created by 484
-Silence is golden
tests/generic/group +0 -1
index ff79a597..dc95b77b 100644
@@ -486,7 +486,6 @@
 481 auto quick log metadata
 482 auto metadata replay
 483 auto quick log metadata
-484 auto quick
 485 auto quick insert
 486 auto quick attr
 487 auto quick eio
Signature · 1 line
2.24.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Christoph Hellwig

Generic/484 tests functionality that isn't really related to file systems, and has failed every since it was added. Remove it as it serves no puropse in xfstests.

no complaints here,

--D

Quoted 88 lines
---
 tests/generic/484     | 51 -------------------------------------------
 tests/generic/484.out |  2 --
 tests/generic/group   |  1 -
 3 files changed, 54 deletions(-)
 delete mode 100755 tests/generic/484
 delete mode 100644 tests/generic/484.out
tests/generic/484 deleted +0 -51
deleted file mode 100755
index d83380ac..00000000
@@ -1,51 +0,0 @@
-#! /bin/bash
-# SPDX-License-Identifier: GPL-2.0
-# Copyright (c) 2018 Red Hat Inc.  All Rights Reserved.
-#
-# FS QA Test 484
-#
-# POSIX requires that record locks are preserved across an execve(2). But
-# there's bug that record locks are released if process is multithreaded at the
-# time that execve is called.
-#
-# Fixed by patch from Jeff Layton:
-# locks: change POSIX lock ownership on execve when files_struct is displaced
-#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "QA output created by $seq"
-
-here=`pwd`
-tmp=/tmp/$$
-status=1	# failure is the default!
-trap "_cleanup; exit \$status" 0 1 2 3 15
-
-_cleanup()
-{
-	cd /
-	rm -f $tmp.*
-}
-
-# get standard environment, filters and checks
-. ./common/rc
-. ./common/filter
-
-# remove previous $seqres.full before test
-rm -f $seqres.full
-
-# real QA test starts here
-_supported_fs generic
-_supported_os Linux
-_require_test
-_require_test_program "t_locks_execve"
-
-# prepare a 4k testfile in TEST_DIR
-$XFS_IO_PROG -f -c "pwrite -S 0xFF 0 4096" \
-	$TEST_DIR/t_lock_execve_file >> $seqres.full 2>&1
-
-$here/src/t_locks_execve $TEST_DIR/t_lock_execve_file
-
-# success, all done
-echo "Silence is golden"
-status=0
-exit
tests/generic/484.out deleted +0 -2
deleted file mode 100644
index 94f2f0bd..00000000
@@ -1,2 +0,0 @@
-QA output created by 484
-Silence is golden
tests/generic/group +0 -1
index ff79a597..dc95b77b 100644
@@ -486,7 +486,6 @@
 481 auto quick log metadata
 482 auto metadata replay
 483 auto quick log metadata
-484 auto quick
 485 auto quick insert
 486 auto quick attr
 487 auto quick eio
Signature · 1 line
2.24.1
#2 lore raw
In reply to Christoph Hellwig
Quoted 6 lines · Christoph Hellwig

Generic/484 tests functionality that isn't really related to file systems, and has failed every since it was added. Remove it as it serves no puropse in xfstests.

---

CC the original author of this case. To make sure if he has more opinions about this change, and if he'd like to shift it to LTP if xfstests decides to remove this case at last.

Quoted 87 lines
 tests/generic/484     | 51 -------------------------------------------
 tests/generic/484.out |  2 --
 tests/generic/group   |  1 -
 3 files changed, 54 deletions(-)
 delete mode 100755 tests/generic/484
 delete mode 100644 tests/generic/484.out
tests/generic/484 deleted +0 -51
deleted file mode 100755
index d83380ac..00000000
@@ -1,51 +0,0 @@
-#! /bin/bash
-# SPDX-License-Identifier: GPL-2.0
-# Copyright (c) 2018 Red Hat Inc.  All Rights Reserved.
-#
-# FS QA Test 484
-#
-# POSIX requires that record locks are preserved across an execve(2). But
-# there's bug that record locks are released if process is multithreaded at the
-# time that execve is called.
-#
-# Fixed by patch from Jeff Layton:
-# locks: change POSIX lock ownership on execve when files_struct is displaced
-#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "QA output created by $seq"
-
-here=`pwd`
-tmp=/tmp/$$
-status=1	# failure is the default!
-trap "_cleanup; exit \$status" 0 1 2 3 15
-
-_cleanup()
-{
-	cd /
-	rm -f $tmp.*
-}
-
-# get standard environment, filters and checks
-. ./common/rc
-. ./common/filter
-
-# remove previous $seqres.full before test
-rm -f $seqres.full
-
-# real QA test starts here
-_supported_fs generic
-_supported_os Linux
-_require_test
-_require_test_program "t_locks_execve"
-
-# prepare a 4k testfile in TEST_DIR
-$XFS_IO_PROG -f -c "pwrite -S 0xFF 0 4096" \
-	$TEST_DIR/t_lock_execve_file >> $seqres.full 2>&1
-
-$here/src/t_locks_execve $TEST_DIR/t_lock_execve_file
-
-# success, all done
-echo "Silence is golden"
-status=0
-exit
tests/generic/484.out deleted +0 -2
deleted file mode 100644
index 94f2f0bd..00000000
@@ -1,2 +0,0 @@
-QA output created by 484
-Silence is golden
tests/generic/group +0 -1
index ff79a597..dc95b77b 100644
@@ -486,7 +486,6 @@
 481 auto quick log metadata
 482 auto metadata replay
 483 auto quick log metadata
-484 auto quick
 485 auto quick insert
 486 auto quick attr
 487 auto quick eio
Signature · 1 line
2.24.1
#3 lore raw
Quoted 11 lines · Zorro Lang
Quoted 6 lines · Christoph Hellwig

Generic/484 tests functionality that isn't really related to file systems, and has failed every since it was added. Remove it as it serves no puropse in xfstests.

---

CC the original author of this case. To make sure if he has more opinions about this change, and if he'd like to shift it to LTP if xfstests decides to remove this case at last.

Okay for me to remove it. It seems very hard to fix.

I'll try LTP, :)

Thanks.

Quoted 88 lines
Quoted 88 lines
 tests/generic/484     | 51 -------------------------------------------
 tests/generic/484.out |  2 --
 tests/generic/group   |  1 -
 3 files changed, 54 deletions(-)
 delete mode 100755 tests/generic/484
 delete mode 100644 tests/generic/484.out
tests/generic/484 deleted +0 -51
deleted file mode 100755
index d83380ac..00000000
@@ -1,51 +0,0 @@
-#! /bin/bash
-# SPDX-License-Identifier: GPL-2.0
-# Copyright (c) 2018 Red Hat Inc.  All Rights Reserved.
-#
-# FS QA Test 484
-#
-# POSIX requires that record locks are preserved across an execve(2). But
-# there's bug that record locks are released if process is multithreaded at the
-# time that execve is called.
-#
-# Fixed by patch from Jeff Layton:
-# locks: change POSIX lock ownership on execve when files_struct is displaced
-#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "QA output created by $seq"
-
-here=`pwd`
-tmp=/tmp/$$
-status=1	# failure is the default!
-trap "_cleanup; exit \$status" 0 1 2 3 15
-
-_cleanup()
-{
-	cd /
-	rm -f $tmp.*
-}
-
-# get standard environment, filters and checks
-. ./common/rc
-. ./common/filter
-
-# remove previous $seqres.full before test
-rm -f $seqres.full
-
-# real QA test starts here
-_supported_fs generic
-_supported_os Linux
-_require_test
-_require_test_program "t_locks_execve"
-
-# prepare a 4k testfile in TEST_DIR
-$XFS_IO_PROG -f -c "pwrite -S 0xFF 0 4096" \
-	$TEST_DIR/t_lock_execve_file >> $seqres.full 2>&1
-
-$here/src/t_locks_execve $TEST_DIR/t_lock_execve_file
-
-# success, all done
-echo "Silence is golden"
-status=0
-exit
tests/generic/484.out deleted +0 -2
deleted file mode 100644
index 94f2f0bd..00000000
@@ -1,2 +0,0 @@
-QA output created by 484
-Silence is golden
tests/generic/group +0 -1
index ff79a597..dc95b77b 100644
@@ -486,7 +486,6 @@
 481 auto quick log metadata
 482 auto metadata replay
 483 auto quick log metadata
-484 auto quick
 485 auto quick insert
 486 auto quick attr
 487 auto quick eio
Signature · 1 line
2.24.1
Signature · 1 line
Murphy
#4 lore raw
In reply to Christoph Hellwig
Quoted 5 lines · Christoph Hellwig

Generic/484 tests functionality that isn't really related to file systems, and has failed every since it was added. Remove it as it serves no puropse in xfstests.

I also removed src/t_locks_execve.c which is used only by this test, and its entries in src/Makefile & .gitignore file.

Thanks,
Eryu