Skip to contentSkip to conversation

dmaengine: tegra-apb: fix platform_get_irq.cocci warnings

PATCH Applied Julia Lawall 3 participants 3 messages Feb 27, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: tegra-apb: fix platform_get_irq.cocci warnings

From: kbuild test robot <[email protected]>

Remove dev_err() messages after platform_get_irq*() failures. platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
CC Dmitry Osipenko <[email protected]>

---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST

:::::: branch date: 17 hours ago
:::::: commit date: 2 days ago

Please take the patch only if it's a positive warning. Thanks!

 tegra20-apb-dma.c |    1 -
 1 file changed, 1 deletion(-)
drivers/dma/tegra20-apb-dma.c +0 -1
@@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
 		irq = platform_get_irq(pdev, i);
 		if (irq < 0) {
 			ret = irq;
-			dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
 			goto err_pm_disable;
 		}
Reviewed-by on v1 1/1
#1 lore raw

27.02.2020 13:35, Julia Lawall пишет:

Quoted 27 lines

From: kbuild test robot <[email protected]>

Remove dev_err() messages after platform_get_irq*() failures. platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
CC Dmitry Osipenko <[email protected]>

---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST

:::::: branch date: 17 hours ago
:::::: commit date: 2 days ago

Please take the patch only if it's a positive warning. Thanks!

 tegra20-apb-dma.c |    1 -
 1 file changed, 1 deletion(-)

drivers/dma/tegra20-apb-dma.c static int tegra_dma_probe(struct platfo · line 1482

Quoted 7 lines
drivers/dma/tegra20-apb-dma.c +0 -1
@@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
 		irq = platform_get_irq(pdev, i);
 		if (irq < 0) {
 			ret = irq;
-			dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
 			goto err_pm_disable;
 		}
 
#2 lore raw
Quoted 25 lines · Dmitry Osipenko

27.02.2020 13:35, Julia Lawall пишет:

Quoted 24 lines

From: kbuild test robot <[email protected]>

Remove dev_err() messages after platform_get_irq*() failures. platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
CC Dmitry Osipenko <[email protected]>

---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST

:::::: branch date: 17 hours ago
:::::: commit date: 2 days ago

Please take the patch only if it's a positive warning. Thanks!

 tegra20-apb-dma.c |    1 -
 1 file changed, 1 deletion(-)
Quoted 12 lines

drivers/dma/tegra20-apb-dma.c static int tegra_dma_probe(struct platfo · line 1482

Quoted 10 lines
drivers/dma/tegra20-apb-dma.c +0 -1
@@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
 		irq = platform_get_irq(pdev, i);
 		if (irq < 0) {
 			ret = irq;
-			dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
 			goto err_pm_disable;
 		}