RMDA/cm: Fix missing ib_cm_destroy_id() in ib_cm_insert_listen()
PATCH 1/1 RMDA/cm: Fix missing ib_cm_destroy_id() in ib_cm_insert_listen()
The algorithm pre-allocates a cm_id since allocation cannot be done while holding the cm.lock spinlock, however it doesn't free it on one error path, leading to a memory leak.
Fixes 067b171b8679 ("IB/cm: Share listening CM IDs")
Signed-off-by Jason Gunthorpe <[email protected]>
--- drivers/infiniband/core/cm.c | 1 + 1 file changed, 1 insertion(+)
drivers/infiniband/core/cm.c +1 -0
@@ -1191,6 +1191,7 @@ struct ib_cm_id *ib_cm_insert_listen(struct ib_device *device,/* Sharing an ib_cm_id with different handlers is not * supported */ spin_unlock_irqrestore (&cm.lock, flags); +ib_destroy_cm_id (cm_id);return ERR_PTR (-EINVAL ); }refcount_inc (&cm_id_priv->refcount);
Signature · 1 line
2.25.0
Jason Gunthorpe
AppliedQuoted 9 lines · Jason Gunthorpe
The algorithm pre-allocates a
cm_idsince allocation cannot be done while holding the cm.lock spinlock, however it doesn't free it on one error path, leading to a memory leak.Fixes 067b171b8679 ("IB/cm: Share listening CM IDs")Signed-off-by Jason Gunthorpe <[email protected]>--- drivers/infiniband/core/cm.c | 1 + 1 file changed, 1 insertion(+)
Applied to for-rc
Jason