Skip to contentSkip to conversation

5.5.7-stable review

PATCH In review Greg Kroah-Hartman 9 participants 166 messages Feb 27, 2020 – Feb 28, 2020 Page 2 of 2

Subsystems (4)
Stable branch USB MIPS Tegra architecture support
lore
Share & tools
lore
author maintainer
#155 lore raw

PATCH 150/150 bpf: Selftests build error in sockmap_basic.c

In reply to Greg Kroah-Hartman

From: John Fastabend <[email protected]>

commit f2e97dc126b712c0d21219ed0c42710006c1cf52 upstream.

Fix following build error. We could push a tcp.h header into one of the include paths, but I think its easy enough to simply pull in the three defines we need here. If we end up using more of tcp.h at some point we can pull it in later.

/home/john/git/bpf/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c: In function ‘connected_socket_v4’:
/home/john/git/bpf/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c:20:11: error: ‘TCP_REPAIR_ON’ undeclared (first use in this function)

  repair = TCP_REPAIR_ON;
           ^

/home/john/git/bpf/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c:20:11: note: each undeclared identifier is reported only once for each function it appears in /home/john/git/bpf/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c:29:11: error: ‘TCP_REPAIR_OFF_NO_WP’ undeclared (first use in this function)
repair = TCP_REPAIR_OFF_NO_WP;

Then with fix,

$ ./test_progs -n 44
#44/1 sockmap create_update_free:OK
#44/2 sockhash create_update_free:OK
#44 sockmap_basic:OK
Fixes 5d3919a953c3c ("selftests/bpf: Test freeing sockmap/sockhash with a socket in it")
Signed-off-by John Fastabend <[email protected]>
Signed-off-by Alexei Starovoitov <[email protected]>
Reviewed-by Jakub Sitnicki <[email protected]>
Link https://lore.kernel.org/bpf/158131347731.21414.12120493483848386652.stgit@john-Precision-5820-Tower open here
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 tools/testing/selftests/bpf/prog_tests/sockmap_basic.c |    5 +++++
 1 file changed, 5 insertions(+)
tools/testing/selftests/bpf/prog_tests/sockmap_basic.c +5 -0
@@ -3,6 +3,11 @@
 
 #include "test_progs.h"
 
+#define TCP_REPAIR		19	/* TCP sock is under repair right now */
+
+#define TCP_REPAIR_ON		1
+#define TCP_REPAIR_OFF_NO_WP	-1	/* Turn off without window probes */
+
 static int connected_socket_v4(void)
 {
 	struct sockaddr_in addr = {
maintainer
#156 lore raw
In reply to Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.7 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 29 Feb 2020 13:21:24 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.5.7-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.5.y
and the diffstat can be found below.

thanks,

greg k-h

All tests are passing for Tegra ...

Test results for stable-v5.5:

    13 builds:	13 pass, 0 fail
    22 boots:	22 pass, 0 fail
    40 tests:	40 pass, 0 fail

Linux version: 5.5.7-rc1-g986ea77a7c44
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,

                tegra194-p2972-0000, tegra20-ventana,
                tegra210-p2371-2180, tegra210-p3450-0000,
                tegra30-cardhu-a04

Cheers
Jon

Signature · 1 line
nvpublic
author maintainer
#157 lore raw
Quoted 27 lines · Jon Hunter
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.7 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 29 Feb 2020 13:21:24 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.5.7-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.5.y
and the diffstat can be found below.

thanks,

greg k-h

All tests are passing for Tegra ...

Test results for stable-v5.5:

    13 builds:	13 pass, 0 fail
    22 boots:	22 pass, 0 fail
    40 tests:	40 pass, 0 fail
Quoted 5 lines

Linux version: 5.5.7-rc1-g986ea77a7c44
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,

                tegra194-p2972-0000, tegra20-ventana,
                tegra210-p2371-2180, tegra210-p3450-0000,
                tegra30-cardhu-a04

Thanks for testing all of these and letting me know.

greg k-h

#158 lore raw
In reply to Greg Kroah-Hartman
Quoted 8 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.7 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 29 Feb 2020 13:21:24 +0000. Anything received after that time might be too late.

Build results:

	total: 157 pass: 157 fail: 0
Qemu test results:
	total: 416 pass: 416 fail: 0

Guenter

#159 lore raw
In reply to Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.7 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 29 Feb 2020 13:21:24 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 9 lines
	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.5.7-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.5.y
and the diffstat can be found below.

thanks,

greg k-h

Compiled and booted on my test system. No dmesg regressions.

thanks,
-- Shuah

author maintainer
#160 lore raw
Quoted 15 lines · shuah
Quoted 14 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.7 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 29 Feb 2020 13:21:24 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.5.7-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.5.y
and the diffstat can be found below.

Quoted 6 lines
Quoted 4 lines

thanks,

greg k-h

Compiled and booted on my test system. No dmesg regressions.

Thanks for testing all of these and letting me know.

greg k-h

#161 lore raw
In reply to Greg Kroah-Hartman
Quoted 10 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.7 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 29 Feb 2020 13:21:24 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
        https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.5.7-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.5.y
and the diffstat can be found below.

thanks,

greg k-h

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Summary
------------------------------------------------------------------------

kernel: 5.5.7-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-5.5.y
git commit: 986ea77a7c4444449bba2f289b959786acef45cd
git describe: v5.5.6-151-g986ea77a7c44
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-5.5-oe/build/v5.5.6-151-g986ea77a7c44

No regressions (compared to build v5.5.6)

No fixes (compared to build v5.5.6)

Ran 29362 total tests in the following environments and test suites.

Environments
--------------
- dragonboard-410c
- hi6220-hikey
- i386
- juno-r2
- nxp-ls2088
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15
- x86

Test Suites
-----------
* build
* install-android-platform-tools-r2600
* kselftest
* libgpiod
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-cpuhotplug-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* perf
* spectre-meltdown-checker-test
* v4l2-compliance
* network-basic-tests
* ltp-fs-tests
* ltp-open-posix-tests
* kvm-unit-tests
* ltp-cap_bounds-64k-page_size-tests
* ltp-cap_bounds-kasan-tests
* ltp-commands-64k-page_size-tests
* ltp-commands-kasan-tests
* ltp-containers-64k-page_size-tests
* ltp-containers-kasan-tests
* ltp-cpuhotplug-64k-page_size-tests
* ltp-cpuhotplug-kasan-tests
* ltp-crypto-64k-page_size-tests
* ltp-crypto-kasan-tests
* ltp-crypto-tests
* ltp-cve-64k-page_size-tests
* ltp-cve-kasan-tests
* ltp-dio-64k-page_size-tests
* ltp-dio-kasan-tests
* ltp-fcntl-locktests-64k-page_size-tests
* ltp-fcntl-locktests-kasan-tests
* ltp-filecaps-64k-page_size-tests
* ltp-filecaps-kasan-tests
* ltp-fs-64k-page_size-tests
* ltp-fs-kasan-tests
* ltp-fs_bind-64k-page_size-tests
* ltp-fs_bind-kasan-tests
* ltp-fs_perms_simple-64k-page_size-tests
* ltp-fs_perms_simple-kasan-tests
* ltp-fsx-64k-page_size-tests
* ltp-fsx-kasan-tests
* ltp-hugetlb-64k-page_size-tests
* ltp-hugetlb-kasan-tests
* ltp-io-64k-page_size-tests
* ltp-io-kasan-tests
* ltp-ipc-64k-page_size-tests
* ltp-ipc-kasan-tests
* ltp-math-64k-page_size-tests
* ltp-math-kasan-tests
* ltp-mm-64k-page_size-tests
* ltp-mm-kasan-tests
* ltp-nptl-64k-page_size-tests
* ltp-nptl-kasan-tests
* ltp-pty-64k-page_size-tests
* ltp-pty-kasan-tests
* ltp-sched-64k-page_size-tests
* ltp-sched-kasan-tests
* ltp-securebits-64k-page_size-tests
* ltp-securebits-kasan-tests
* ltp-syscalls-64k-page_size-tests
* ltp-syscalls-compat-tests
* ltp-syscalls-kasan-tests
* ssuite
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none

Signature · 2 lines
Linaro LKFT
https://lkft.linaro.org
author maintainer
#162 lore raw
Quoted 17 lines · Naresh Kamboju
Quoted 15 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.7 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 29 Feb 2020 13:21:24 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

        https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.5.7-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.5.y
and the diffstat can be found below.

Quoted 6 lines
Quoted 3 lines

thanks,

greg k-h

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Wonderful, thanks for testing all of these and letting me know.

greg k-h

#163 lore raw
In reply to Greg Kroah-Hartman
Quoted 7 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.7 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 29 Feb 2020 13:21:24 +0000. Anything received after that time might be too late.

There is something going on with USB in this release. My AMD X570 board is constantly having ports stop working, while a older AMD X399 board seems fine (maybe, there is an ATEN USB extender involved on the X570 system)

I've only had time to do very rudimentary debugging, but reverting all usb and xhci related patches seems to have solved it, eg:

Quoted 11 lines

usb-dwc2-fix-in-isoc-request-length-checking.patch usb-gadget-composite-fix-bmaxpower-for-superspeedplus.patch usb-dwc3-debug-fix-string-position-formatting-mixup-with-ret-and-len.patch usb-dwc3-gadget-check-for-ioc-lst-bit-in-trb-ctrl-fields.patch usb-dwc2-fix-set-clear_feature-and-get_status-flows.patch usb-hub-fix-the-broken-detection-of-usb3-device-in-smsc-hub.patch usb-hub-don-t-record-a-connect-change-event-during-reset-resume.patch usb-fix-novation-sourcecontrol-xl-after-suspend.patch usb-uas-fix-a-plug-unplug-racing.patch usb-quirks-blacklist-duplicate-ep-on-sound-devices-usbpre2.patch usb-core-add-endpoint-blacklist-quirk.patch

Quoted 8 lines

xhci-fix-memory-leak-when-caching-protocol-extended-capability-psi-tables-take-2.patch xhci-apply-xhci_pme_stuck_quirk-to-intel-comet-lake-platforms.patch xhci-fix-runtime-pm-enabling-for-quirky-intel-hosts.patch xhci-force-maximum-packet-size-for-full-speed-bulk-devices-to-valid-range.patch usb-serial-ch341-fix-receiver-regression.patch usb-misc-iowarrior-add-support-for-the-100-device.patch usb-misc-iowarrior-add-support-for-the-28-and-28l-devices.patch usb-misc-iowarrior-add-support-for-2-oemed-devices.patch

I might be able to narrow it down in a day or two.

author maintainer
#164 lore raw
Quoted 36 lines · Andre Tomt
Quoted 7 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.7 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 29 Feb 2020 13:21:24 +0000. Anything received after that time might be too late.

There is something going on with USB in this release. My AMD X570 board is constantly having ports stop working, while a older AMD X399 board seems fine (maybe, there is an ATEN USB extender involved on the X570 system)

I've only had time to do very rudimentary debugging, but reverting all usb and xhci related patches seems to have solved it, eg:

Quoted 11 lines

usb-dwc2-fix-in-isoc-request-length-checking.patch usb-gadget-composite-fix-bmaxpower-for-superspeedplus.patch usb-dwc3-debug-fix-string-position-formatting-mixup-with-ret-and-len.patch usb-dwc3-gadget-check-for-ioc-lst-bit-in-trb-ctrl-fields.patch usb-dwc2-fix-set-clear_feature-and-get_status-flows.patch usb-hub-fix-the-broken-detection-of-usb3-device-in-smsc-hub.patch usb-hub-don-t-record-a-connect-change-event-during-reset-resume.patch usb-fix-novation-sourcecontrol-xl-after-suspend.patch usb-uas-fix-a-plug-unplug-racing.patch usb-quirks-blacklist-duplicate-ep-on-sound-devices-usbpre2.patch usb-core-add-endpoint-blacklist-quirk.patch

Quoted 8 lines

xhci-fix-memory-leak-when-caching-protocol-extended-capability-psi-tables-take-2.patch xhci-apply-xhci_pme_stuck_quirk-to-intel-comet-lake-platforms.patch xhci-fix-runtime-pm-enabling-for-quirky-intel-hosts.patch xhci-force-maximum-packet-size-for-full-speed-bulk-devices-to-valid-range.patch usb-serial-ch341-fix-receiver-regression.patch usb-misc-iowarrior-add-support-for-the-100-device.patch usb-misc-iowarrior-add-support-for-the-28-and-28l-devices.patch usb-misc-iowarrior-add-support-for-2-oemed-devices.patch

Quoted 1 line

I might be able to narrow it down in a day or two.

Narrowing it down would be good, try sticking with either the hub or xhci patches. And, 'git bisect' might make it easier.

Also, does Linus's current tree show the same problems for you?

thanks,

greg k-h

#165 lore raw
Quoted 17 lines · Greg Kroah-Hartman
Quoted 16 lines · Andre Tomt
Quoted 7 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.7 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 29 Feb 2020 13:21:24 +0000. Anything received after that time might be too late.

There is something going on with USB in this release. My AMD X570 board is constantly having ports stop working, while a older AMD X399 board seems fine (maybe, there is an ATEN USB extender involved on the X570 system)

I've only had time to do very rudimentary debugging, but reverting all usb and xhci related patches seems to have solved it, eg:

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

<snip>

I might be able to narrow it down in a day or two.

Narrowing it down would be good, try sticking with either the hub or xhci patches. And, 'git bisect' might make it easier.

It seems to be caused by "USB: hub: Don't record a connect-change event during reset-resume". Running 5.5.7-rc1 with only that patch reverted works fine.

Also happens with the X399. And only when the ATEN UCE260 USB extender is involved. Connecting a device is the problem, if it is connected at boot, things seem fine, until you connect something new. Then the port dies completely, dead even if you disconnect the extender and plug something in directly - until system is rebooted (perhaps driver reload would work too - have not tested.)

Aw well, the problem does seem a little narrower than I expected at first :)

There's no errors in the kernel log at all. The last thing logged is that whatever device was on the other end got disconnected.

Quoted 1 line

Also, does Linus's current tree show the same problems for you?

Yes, it does

Unfortunately, email deliverability will be terrible for me for a few days (there was a mishap), so if you could loop in the author/maintainers for me that would be good.