package/pkg-generic.mk: in image install, print message before pre-hooks
PATCH 1/1 package/pkg-generic.mk: in image install, print message before pre-hooks
In all steps, we print the message indicating the start of the step using the MESSAGE macro before running pre-hooks. Except in the image installation step, where the message is printed after the pre-hooks.
Let's fix this inconsistency.
--- package/pkg-generic.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-generic.mk +1 -1
@@ -347,8 +347,8 @@ $(BUILD_DIR)/%/.stamp_staging_installed: $(BUILD_DIR)/%/.stamp_images_installed: @$(call step_start,install-image) @mkdir -p $(BINARIES_DIR) - $(foreach hook,$($(PKG)_PRE_INSTALL_IMAGES_HOOKS),$(call $(hook))$(sep)) @$(call MESSAGE,"Installing to images directory") + $(foreach hook,$($(PKG)_PRE_INSTALL_IMAGES_HOOKS),$(call $(hook))$(sep)) +$($(PKG)_INSTALL_IMAGES_CMDS) $(foreach hook,$($(PKG)_POST_INSTALL_IMAGES_HOOKS),$(call $(hook))$(sep)) @$(call step_end,install-image)
Signature · 1 line
2.24.1
PATCH 1/1 package/pkg-generic.mk: in image install, print message before pre-hooks
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
In all steps, we print the message indicating the start of the step using the MESSAGE macro before running pre-hooks. Except in the image installation step, where the message is printed after the pre-hooks.
Let's fix this inconsistency.
Signed-off-by Thomas Petazzoni <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/pkg-generic.mk: in image install, print message before pre-hooks
In reply to Thomas PetazzoniQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
In all steps, we print the message indicating the start of the step using the MESSAGE macro before running pre-hooks. Except in the image installation step, where the message is printed after the pre-hooks.
Let's fix this inconsistency.
Signed-off-by Thomas Petazzoni <[email protected]>
Committed to 2019.02.x and 2019.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard