pinctrl: madera: Add missing call to pinctrl_unregister_mappings
Subsystems (3)
Charles Keepax
maintainerPATCH 1/1 pinctrl: madera: Add missing call to pinctrl_unregister_mappings
pinctrl_register_mappings is called in the pdata case, however a call to pinctrl_unregister_mappings is missing causing the mappings to be leaked on driver unbind. Add the missing call to correct this issue.
Signed-off-by Charles Keepax <[email protected]>
--- drivers/pinctrl/cirrus/pinctrl-madera-core.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
drivers/pinctrl/cirrus/pinctrl-madera-core.c +13 -0
@@ -1073,13 +1073,26 @@ static int madera_pin_probe(struct platform_device *pdev)return ret; } +platform_set_drvdata (pdev, priv); +dev_dbg (priv->dev,"pinctrl probed ok\n" );return 0 ; } +static int madera_pin_remove (struct platform_device *pdev) +{ +struct madera_pin_private *priv =platform_get_drvdata (pdev); + +if (priv->madera->pdata.gpio_configs) +pinctrl_unregister_mappings (priv->madera->pdata.gpio_configs); + +return 0 ; +} +static struct platform_driver madera_pin_driver = { .probe = madera_pin_probe, + .remove = madera_pin_remove, .driver = { .name ="madera-pinctrl" , },
Signature · 1 line
2.11.0
Quoted 5 lines · Charles Keepax
pinctrl_register_mappingsis called in the pdata case, however a call topinctrl_unregister_mappingsis missing causing the mappings to be leaked on driver unbind. Add the missing call to correct this issue.Signed-off-by Charles Keepax <[email protected]>
Patch applied for fixes.
Yours,
Linus Walleij