Skip to contentSkip to conversation

staging: iio: update TODO

PATCH Superseded Rohit Sarkar 2 participants 4 messages Feb 24, 2020 – Feb 28, 2020

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: iio: update TODO

[email protected], [email protected]
Bcc:
Subject: [PATCH] staging: iio: update TODO
Reply-To:

Since there are no more uses of the old GPIO API in iio staging drivers remove that work item from the TODO.

Add other work items with reference to the conversation in [1]

[1]: https://marc.info/?l=linux-iio&m=158256721009892&w=2

Thanks,
Rohit

---
 drivers/staging/iio/TODO | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/staging/iio/TODO +8 -6
index 1b8ebf2c1b69..783878f25f08 100644
@@ -1,11 +1,13 @@
-2018-04-15
+2020-02-25
 
-All affected drivers:
-Convert all uses of the old GPIO API from <linux/gpio.h> to the
-GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
-lines from device tree, ACPI or board files, board files should
-use <linux/gpio/machine.h>.
+- Documentation
+  - Binding docs for devices that are obviously used via device tree
+  - Yaml conversions for abandoned drivers
+  - ABI Documentation
+  - Audit driviers/iio/staging/Documentation
 
+- Replace iio_dev->mlock by either a local lock or use iio_claim_direct.
+(Requires analysis of the purpose of the lock.)
 
 ADI Drivers:
 CC the [email protected] mailing list when
Signature · 1 line
2.23.0.385.gbc12974a89
#1 lore raw

PATCH v2 1/1 staging: iio: update TODO

since there are no uses of the old GPIO API, remove the item from the TODO and some new items.

Changes from v1:
Add work item mentioned by Alexandru in https://marc.info/?l=linux-iio&m=158261515624212&w=2

---
 drivers/staging/iio/TODO | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/staging/iio/TODO +12 -6
index 1b8ebf2c1b69..e54510c2ef5f 100644
@@ -1,11 +1,17 @@
-2018-04-15
+2020-02-25
 
-All affected drivers:
-Convert all uses of the old GPIO API from <linux/gpio.h> to the
-GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
-lines from device tree, ACPI or board files, board files should
-use <linux/gpio/machine.h>.
+- Documentation
+  - Binding docs for devices that are obviously used via device tree
+  - Yaml conversions for abandoned drivers
+  - ABI Documentation
+  - Audit driviers/iio/staging/Documentation
 
+- Replace iio_dev->mlock by either a local lock or use iio_claim_direct.
+  (Requires analysis of the purpose of the lock.)
+
+- Converting drivers from device tree centric to more generic property handlers
+  Refactor old platform_data constructs from drivers and convert it to state
+  struct and using property handlers and readers.
 
 ADI Drivers:
 CC the [email protected] mailing list when
Signature · 1 line
2.23.0.385.gbc12974a89
#2 lore raw
Quoted 5 lines · On Tue, 25 Feb 2020 20:19:33 +0530 Rohit Sarkar <[email protected]>…

since there are no uses of the old GPIO API, remove the item from the TODO and some new items.

Changes from v1:
Add work item mentioned by Alexandru in https://marc.info/?l=linux-iio&m=158261515624212&w=2

My main issue here is we are adding to the "staging" todo, a list of tasks that are relevant to all drivers, not those in staging alone.

Please break this into a simple patch removing the gpio stuff that is no longer relevant and a second patch to propose additions. That way I can pick up the uncontroversial part and we can talk further about whether it makes sense to put system wide TODO entries in here.

Thanks,

Jonathan

Quoted 34 lines
---
 drivers/staging/iio/TODO | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/staging/iio/TODO +12 -6
index 1b8ebf2c1b69..e54510c2ef5f 100644
@@ -1,11 +1,17 @@
-2018-04-15
+2020-02-25
 
-All affected drivers:
-Convert all uses of the old GPIO API from <linux/gpio.h> to the
-GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
-lines from device tree, ACPI or board files, board files should
-use <linux/gpio/machine.h>.
+- Documentation
+  - Binding docs for devices that are obviously used via device tree
+  - Yaml conversions for abandoned drivers
+  - ABI Documentation
+  - Audit driviers/iio/staging/Documentation
 
+- Replace iio_dev->mlock by either a local lock or use iio_claim_direct.
+  (Requires analysis of the purpose of the lock.)
+
+- Converting drivers from device tree centric to more generic property handlers
+  Refactor old platform_data constructs from drivers and convert it to state
+  struct and using property handlers and readers.
 
 ADI Drivers:
 CC the [email protected] mailing list when
#3 lore raw
Quoted 6 lines · Jonathan Cameron
Quoted 3 lines · On Tue, 25 Feb 2020 20:19:33 +0530 Rohit Sarkar <[email protected]>…

since there are no uses of the old GPIO API, remove the item from the TODO and some new items.

Quoted 6 lines
Quoted 2 lines

Changes from v1:
Add work item mentioned by Alexandru in https://marc.info/?l=linux-iio&m=158261515624212&w=2

My main issue here is we are adding to the "staging" todo, a list of tasks that are relevant to all drivers, not those in staging alone.

While I was making this patch I actually had the same concerns.

Quoted 5 lines

Please break this into a simple patch removing the gpio stuff that is no longer relevant and a second patch to propose additions. That way I can pick up the uncontroversial part and we can talk further about whether it makes sense to put system wide TODO entries in here.

Makes sense, will do.

Quoted 4 lines

Thanks,

Jonathan

Thanks, Rohit

Quoted 36 lines
Quoted 34 lines
---
 drivers/staging/iio/TODO | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/staging/iio/TODO +12 -6
index 1b8ebf2c1b69..e54510c2ef5f 100644
@@ -1,11 +1,17 @@
-2018-04-15
+2020-02-25
 
-All affected drivers:
-Convert all uses of the old GPIO API from <linux/gpio.h> to the
-GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
-lines from device tree, ACPI or board files, board files should
-use <linux/gpio/machine.h>.
+- Documentation
+  - Binding docs for devices that are obviously used via device tree
+  - Yaml conversions for abandoned drivers
+  - ABI Documentation
+  - Audit driviers/iio/staging/Documentation
 
+- Replace iio_dev->mlock by either a local lock or use iio_claim_direct.
+  (Requires analysis of the purpose of the lock.)
+
+- Converting drivers from device tree centric to more generic property handlers
+  Refactor old platform_data constructs from drivers and convert it to state
+  struct and using property handlers and readers.
 
 ADI Drivers:
 CC the [email protected] mailing list when