ARM: cns3xxx: replace setup_irq() by request_irq()
Subsystems (2)
PATCH v3 1/1 ARM: cns3xxx: replace setup_irq() by request_irq()
request_irq() is preferred over setup_irq(). Invocations of setup_irq() occur after memory allocators are ready.
Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were initialized.
Hence replace setup_irq() by request_irq().
[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
---
Hi sub-arch maintainers,
If the patch is okay, please take it thr' your tree.
Regards
afzal
v3:
* Split out from series, also split out from ARM patch to subarch level as Thomas suggested to take it thr' respective maintainers
* Modify string displayed in case of error as suggested by Thomas
* Re-arrange code as required to improve readability
* Remove irrelevant parts from commit message & improve
v2:
* Replace pr_err("request_irq() on %s failed" by
pr_err("%s: request_irq() failed"* Commit message massage
arch/arm/mach-cns3xxx/core.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
arch/arm/mach-cns3xxx/core.c +3 -7
@@ -189,12 +189,6 @@ static irqreturn_t cns3xxx_timer_interrupt(int irq, void *dev_id)return IRQ_HANDLED ; } -static struct irqaction cns3xxx_timer_irq = { - .name ="timer" , - .flags =IRQF_TIMER |IRQF_IRQPOLL , - .handler = cns3xxx_timer_interrupt, -}; -/* * Set up the clock source and clock events devices */
@@ -245,7 +239,9 @@ static void __init __cns3xxx_timer_init(unsigned int timer_irq)writel (val, cns3xxx_tmr1 +TIMER1_2_CONTROL_OFFSET );/* Make irqs happen for the system timer */ -setup_irq (timer_irq, &cns3xxx_timer_irq); +if (request_irq (timer_irq, cns3xxx_timer_interrupt, +IRQF_TIMER |IRQF_IRQPOLL ,"timer" ,NULL )) +pr_err ("Failed to request irq %d (timer)\n" , timer_irq);cns3xxx_clockevents_init (timer_irq); }
Signature · 1 line
2.25.1