ARM: ebsa110: replace setup_irq() by request_irq()
Subsystems (2)
PATCH v3 1/1 ARM: ebsa110: replace setup_irq() by request_irq()
request_irq() is preferred over setup_irq(). Invocations of setup_irq() occur after memory allocators are ready.
Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were initialized.
Hence replace setup_irq() by request_irq().
[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
---
Hi sub-arch maintainers,
If the patch is okay, please take it thr' your tree.
Regards
afzal
v3:
* Split out from series, also split out from ARM patch to subarch level as Thomas suggested to take it thr' respective maintainers
* Modify string displayed in case of error as suggested by Thomas
* Re-arrange code as required to improve readability
* Remove irrelevant parts from commit message & improve
v2:
* Replace pr_err("request_irq() on %s failed" by
pr_err("%s: request_irq() failed"* Commit message massage
arch/arm/mach-ebsa110/core.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
arch/arm/mach-ebsa110/core.c +5 -7
@@ -201,17 +201,13 @@ ebsa110_timer_interrupt(int irq, void *dev_id)return IRQ_HANDLED ; } -static struct irqaction ebsa110_timer_irq = { - .name ="EBSA110 Timer Tick" , - .flags =IRQF_TIMER |IRQF_IRQPOLL , - .handler = ebsa110_timer_interrupt, -}; -/* * Set up timer interrupt. */ void __init ebsa110_timer_init (void ) { +int irq =IRQ_EBSA110_TIMER0 ; + arch_gettimeoffset = ebsa110_gettimeoffset;/*
@@ -221,7 +217,9 @@ void __init ebsa110_timer_init(void)__raw_writeb (COUNT &0xff ,PIT_T1 );__raw_writeb (COUNT >>8 ,PIT_T1 ); -setup_irq (IRQ_EBSA110_TIMER0 , &ebsa110_timer_irq); +if (request_irq (irq, ebsa110_timer_interrupt,IRQF_TIMER |IRQF_IRQPOLL , +"EBSA110 Timer Tick" ,NULL )) +pr_err ("Failed to request irq %d (EBSA110 Timer Tick)\n" , irq); }static struct plat_serial8250_port serial_platform_data[] = {
Signature · 1 line
2.25.1