package/libvorbis: fix CVE-2018-10392
PATCH 1/2 package/libvorbis: fix CVE-2018-10392
mapping0_forward in mapping0.c in Xiph.Org libvorbis 1.3.6 does not validate the number of channels, which allows remote attackers to cause a denial of service (heap-based buffer overflow or over-read) or possibly have unspecified other impact via a crafted file.
--- ...ty-check-number-of-channels-in-setup.patch | 28 +++++++++++++++++++ package/libvorbis/libvorbis.mk | 3 ++ 2 files changed, 31 insertions(+) create mode 100644 package/libvorbis/0002-Sanity-check-number-of-channels-in-setup.patch
package/libvorbis/0002-Sanity-check-number-of-channels-in-setup.patch new file +28 -0
@@ -0,0 +1,28 @@ +From 112d3bd0aaacad51305e1464d4b381dabad0e88b Mon Sep 17 00:00:00 2001 +From: Thomas Daede <[email protected]> +Date: Thu, 17 May 2018 16:19:19 -0700 +Subject: [PATCH] Sanity check number of channels in setup. + +Fixes #2335. +[Retrieved from: +https://gitlab.xiph.org/xiph/vorbis/commit/112d3bd0aaacad51305e1464d4b381dabad0e88b] +Signed-off-by: Fabrice Fontaine <[email protected]> +--- + lib/vorbisenc.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/lib/vorbisenc.c b/lib/vorbisenc.c +index 4fc7b62..64a51b5 100644 +--- a/lib/vorbisenc.c ++++ b/lib/vorbisenc.c +@@ -684,6 +684,7 @@ int vorbis_encode_setup_init(vorbis_info *vi){ + highlevel_encode_setup *hi=&ci->hi; + + if(ci==NULL)return(OV_EINVAL); ++ if(vi->channels<1||vi->channels>255)return(OV_EINVAL); + if(!hi->impulse_block_p)i0=1; + + /* too low/high an ATH floater is nonsensical, but doesn't break anything */ +-- +2.24.1 +
package/libvorbis/libvorbis.mk +3 -0
@@ -13,4 +13,7 @@ LIBVORBIS_DEPENDENCIES = host-pkgconf libogg LIBVORBIS_LICENSE = BSD-3-Clause LIBVORBIS_LICENSE_FILES = COPYING +# 0002-Sanity-check-number-of-channels-in-setup.patch +LIBVORBIS_IGNORE_CVES += CVE-2018-10392 + $(eval $(autotools-package))
Signature · 1 line
2.25.0
PATCH 2/2 package/libvorbis: annote CVE-2018-10393
bark_noise_hybridmp in psy.c in Xiph.Org libvorbis 1.3.6 has a stack-based buffer over-read.
Same patch as for CVE-2017-14160
--- package/libvorbis/libvorbis.mk | 3 +++ 1 file changed, 3 insertions(+)
package/libvorbis/libvorbis.mk +3 -0
@@ -13,6 +13,9 @@ LIBVORBIS_DEPENDENCIES = host-pkgconf libogg LIBVORBIS_LICENSE = BSD-3-Clause LIBVORBIS_LICENSE_FILES = COPYING +# 0001-CVE-2017-14160-fix-bounds-check-on-very-low-sample-rates.patch +LIBVORBIS_IGNORE_CVES += CVE-2018-10393 + # 0002-Sanity-check-number-of-channels-in-setup.patch LIBVORBIS_IGNORE_CVES += CVE-2018-10392
Signature · 1 line
2.25.0
PATCH 2/2 package/libvorbis: annote CVE-2018-10393
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
bark_noise_hybridmpinpsy.cin Xiph.Org libvorbis 1.3.6 has a stack-based buffer over-read.Same patch as for CVE-2017-14160
Signed-off-by Fabrice Fontaine <[email protected]>
Committed to 2019.02.x and 2019.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
Yann E. MORIN
AppliedPATCH 1/2 package/libvorbis: fix CVE-2018-10392
In reply to Fabrice FontaineFabrice, All,
On 2020-03-01 19:02 +0100, Fabrice Fontaine spake thusly:
Quoted 6 lines
mapping0_forwardinmapping0.cin Xiph.Org libvorbis 1.3.6 does not validate the number of channels, which allows remote attackers to cause a denial of service (heap-based buffer overflow or over-read) or possibly have unspecified other impact via a crafted file.Signed-off-by Fabrice Fontaine <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 59 lines
--- ...ty-check-number-of-channels-in-setup.patch | 28 +++++++++++++++++++ package/libvorbis/libvorbis.mk | 3 ++ 2 files changed, 31 insertions(+) create mode 100644 package/libvorbis/0002-Sanity-check-number-of-channels-in-setup.patchpackage/libvorbis/0002-Sanity-check-number-of-channels-in-setup.patch new file +28
-0@@ -0,0 +1,28 @@ +From 112d3bd0aaacad51305e1464d4b381dabad0e88b Mon Sep 17 00:00:00 2001 +From: Thomas Daede <[email protected]> +Date: Thu, 17 May 2018 16:19:19 -0700 +Subject: [PATCH] Sanity check number of channels in setup. + +Fixes #2335. +[Retrieved from: +https://gitlab.xiph.org/xiph/vorbis/commit/112d3bd0aaacad51305e1464d4b381dabad0e88b] +Signed-off-by: Fabrice Fontaine <[email protected]> +--- + lib/vorbisenc.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/lib/vorbisenc.c b/lib/vorbisenc.c +index 4fc7b62..64a51b5 100644 +--- a/lib/vorbisenc.c ++++ b/lib/vorbisenc.c +@@ -684,6 +684,7 @@ int vorbis_encode_setup_init(vorbis_info *vi){ + highlevel_encode_setup *hi=&ci->hi; + + if(ci==NULL)return(OV_EINVAL); ++ if(vi->channels<1||vi->channels>255)return(OV_EINVAL); + if(!hi->impulse_block_p)i0=1; + + /* too low/high an ATH floater is nonsensical, but doesn't break anything */ +-- +2.24.1 +package/libvorbis/libvorbis.mk +3
-0@@ -13,4 +13,7 @@ LIBVORBIS_DEPENDENCIES = host-pkgconf libogg LIBVORBIS_LICENSE = BSD-3-Clause LIBVORBIS_LICENSE_FILES = COPYING +# 0002-Sanity-check-number-of-channels-in-setup.patch +LIBVORBIS_IGNORE_CVES += CVE-2018-10392 + $(eval $(autotools-package))Signature · 6 lines
2.25.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/2 package/libvorbis: fix CVE-2018-10392
In reply to Fabrice FontaineQuoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
mapping0_forwardinmapping0.cin Xiph.Org libvorbis 1.3.6 does not validate the number of channels, which allows remote attackers to cause a denial of service (heap-based buffer overflow or over-read) or possibly have unspecified other impact via a crafted file.Signed-off-by Fabrice Fontaine <[email protected]>
Committed to 2019.02.x and 2019.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard