Skip to contentSkip to conversation

man: fix lnstat unresolved_discards description

PATCH In review Aleksei Zakharov 1 participant 2 messages Mar 2, 2020 – Mar 12, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 man: fix lnstat unresolved_discards description

---
 man/man8/lnstat.8 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man/man8/lnstat.8 +1 -1
index b98241bf..f25a9623 100644
@@ -121,7 +121,7 @@ How many forced garbage collection runs were executed. Happens when adding an
 entry and the table is too full.
 .sp
 .B unresolved_discards
-How many neighbor table entries were discarded due to lookup failure.
+How many packets were discarded due to lookup failure and arp queue overfill.
 .sp
 .B table_fulls
 Number of table overflows. Happens if table is full and forced GC run (see
Signature · 1 line
2.17.1
#1 lore raw

Hi all,
Could this be submitted or am i missing something?
lnstat's unresolved_discards field description looks unclear, as for me. And from the code it looks like it's a counter of dropped packets, not table entries, unless i'm not mistaken.

02.03.2020, 14:54, "Aleksei Zakharov" <[email protected]>:

Quoted 15 lines

---
 man/man8/lnstat.8 | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
man/man8/lnstat.8 +0 -0
index b98241bf..f25a9623 100644
@@ -121,7 +121,7 @@ How many forced garbage collection runs were executed. Happens when adding an

 entry and the table is too full.
 .sp
 .B unresolved_discards

man/man8/lnstat.8 +1 -1
-How many neighbor table entries were discarded due to lookup failure.
+How many packets were discarded due to lookup failure and arp queue overfill.
Quoted 5 lines

 .sp
 .B table_fulls
 Number of table overflows. Happens if table is full and forced GC run (see --
2.17.1

--
Regards,
Aleksei Zakharov