scsi: ufs-mediatek: fix HOST_PA_TACTIVATE quirk for Samsung UFS Devices
Subsystems (2)
PATCH 1/1 scsi: ufs-mediatek: fix HOST_PA_TACTIVATE quirk for Samsung UFS Devices
Device quirk "UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE" is enabled for all Samsung devices by default currently.
However MediaTek UFS host requires different host's PA_TACTIVATE configuration. Hence clear this quirk first and then apply vendor-specific value in vops callback.
--- drivers/scsi/ufs/ufs-mediatek.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/scsi/ufs/ufs-mediatek.c +3 -1
@@ -533,8 +533,10 @@ static int ufs_mtk_apply_dev_quirks(struct ufs_hba *hba)struct ufs_dev_info *dev_info = &hba->dev_info;u16 mid = dev_info->wmanufacturerid; -if (mid ==UFS_VENDOR_SAMSUNG ) +if (mid ==UFS_VENDOR_SAMSUNG ) { + hba->dev_quirks &= ~UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE ;ufshcd_dme_set (hba,UIC_ARG_MIB (PA_TACTIVATE ),6 ); + }/* * Decide waiting time before gating reference clock and
Signature · 1 line
2.18.0
Quoted 10 lines
Device quirk "
UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE" is enabled for all Samsung devices by default currently.However MediaTek UFS host requires different host's
PA_TACTIVATEconfiguration. Hence clear this quirk first and then apply vendor-specific value in vops callback.Signed-off-by Stanley Chu <[email protected]>
Quoted 23 lines
--- drivers/scsi/ufs/ufs-mediatek.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/scsi/ufs/ufs-mediatek.c +3
-1@@ -533,8 +533,10 @@ static int ufs_mtk_apply_dev_quirks(struct ufs_hba *hba)struct ufs_dev_info *dev_info = &hba->dev_info;u16 mid = dev_info->wmanufacturerid; -if (mid ==UFS_VENDOR_SAMSUNG ) +if (mid ==UFS_VENDOR_SAMSUNG ) { + hba->dev_quirks &= ~UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE ;ufshcd_dme_set (hba,UIC_ARG_MIB (PA_TACTIVATE ),6 ); + }/* * Decide waiting time before gating reference clock and
--
2.18.0
Martin K. Petersen
AppliedStanley,
Quoted 6 lines
Device quirk "
UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE" is enabled for all Samsung devices by default currently.However MediaTek UFS host requires different host's
PA_TACTIVATEconfiguration. Hence clear this quirk first and then apply vendor-specific value in vops callback.
Applied to 5.7/scsi-queue, thanks!
Signature · 6 lines
Martin K. Petersen Oracle Linux Engineering _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel