Skip to contentSkip to conversation

linux-tools: perf: Add dependencies for binutils and openssl

PATCH New Robert Hancock 3 participants 3 messages Mar 2, 2020 – Mar 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux-tools: perf: Add dependencies for binutils and openssl

perf auto-detects and uses the libbfd (from binutils) and openssl libraries if they are detected and happen to be built before perf is, but if they're not, or if per-package directories are enabled, it won't detect these libraries. Explicitly add dependencies on these packages if they are enabled, and disable the feature if not, so that the behavior is deterministic.

---
 package/linux-tools/linux-tool-perf.mk.in | 12 ++++++++++++
 1 file changed, 12 insertions(+)
package/linux-tools/linux-tool-perf.mk.in +12 -0
index 80e00c3c56..7106b622cb 100644
@@ -82,6 +82,18 @@ else
 PERF_MAKE_FLAGS += NO_LIBELF=1 NO_DWARF=1
 endif
 
+ifeq ($(BR2_PACKAGE_BINUTILS),y)
+PERF_DEPENDENCIES += binutils
+else
+PERF_MAKE_FLAGS += NO_DEMANGLE=1
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+PERF_DEPENDENCIES += openssl
+else
+PERF_MAKE_FLAGS += NO_LIBCRYPTO=1
+endif
+
 ifeq ($(BR2_PACKAGE_ZLIB),y)
 PERF_DEPENDENCIES += zlib
 else
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/1 linux-tools: perf: Add dependencies for binutils and openssl

Robert, All,

On 2020-03-02 16:49 -0600, Robert Hancock spake thusly:

Quoted 8 lines

perf auto-detects and uses the libbfd (from binutils) and openssl libraries if they are detected and happen to be built before perf is, but if they're not, or if per-package directories are enabled, it won't detect these libraries. Explicitly add dependencies on these packages if they are enabled, and disable the feature if not, so that the behavior is deterministic.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 30 lines
---
 package/linux-tools/linux-tool-perf.mk.in | 12 ++++++++++++
 1 file changed, 12 insertions(+)
package/linux-tools/linux-tool-perf.mk.in +12 -0
index 80e00c3c56..7106b622cb 100644
@@ -82,6 +82,18 @@ else
 PERF_MAKE_FLAGS += NO_LIBELF=1 NO_DWARF=1
 endif
 
+ifeq ($(BR2_PACKAGE_BINUTILS),y)
+PERF_DEPENDENCIES += binutils
+else
+PERF_MAKE_FLAGS += NO_DEMANGLE=1
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+PERF_DEPENDENCIES += openssl
+else
+PERF_MAKE_FLAGS += NO_LIBCRYPTO=1
+endif
+
 ifeq ($(BR2_PACKAGE_ZLIB),y)
 PERF_DEPENDENCIES += zlib
 else
Signature · 1 line
2.24.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 linux-tools: perf: Add dependencies for binutils and openssl

In reply to Robert Hancock
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Robert" == Robert Hancock <[email protected]> writes:

perf auto-detects and uses the libbfd (from binutils) and openssl libraries if they are detected and happen to be built before perf is, but if they're not, or if per-package directories are enabled, it won't detect these libraries. Explicitly add dependencies on these packages if they are enabled, and disable the feature if not, so that the behavior is deterministic.

Committed to 2019.02.x, 2019.11.x and 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard