Skip to contentSkip to conversation

Input: Add keycodes for keyboard backlight control

PATCH In review Rajat Jain 2 participants 4 messages Mar 3, 2020

Subsystems (2)
lore
Share & tools
lore

Rajat Jain

author
#0 lore raw

PATCH 1/2 Input: Add keycodes for keyboard backlight control

New keyboards can have backlight control keys. Allocating keycodes for them. Such keyboards are already available in ChromeOS.

---
 include/uapi/linux/input-event-codes.h | 4 ++++
 1 file changed, 4 insertions(+)
include/uapi/linux/input-event-codes.h +4 -0
index 0f1db1cccc3fd..e12a19dc30262 100644
@@ -652,6 +652,10 @@
 /* Electronic privacy screen control */
 #define KEY_PRIVACY_SCREEN_TOGGLE	0x279
 
+/* Keyboard Backlight control */
+#define KEY_KBD_BKLIGHT_UP              0x280
+#define KEY_KBD_BKLIGHT_DOWN            0x281
+
 /*
  * Some keyboards have keys which do not have a defined meaning, these keys
  * are intended to be programmed / bound to macros by the user. For most
Signature · 1 line
2.25.0.265.gbab2e86ba0-goog
author
#1 lore raw

PATCH 2/2 Input: Allocate keycode for SNIP key

New chromeos keyboards have a "snip" key that is basically a selective screenshot (allows a user to select an area of screen to be copied). Allocate a keyvode for it.

---
 include/uapi/linux/input-event-codes.h | 3 +++
 1 file changed, 3 insertions(+)
include/uapi/linux/input-event-codes.h +3 -0
index e12a19dc30262..51f419657d044 100644
@@ -656,6 +656,9 @@
 #define KEY_KBD_BKLIGHT_UP              0x280
 #define KEY_KBD_BKLIGHT_DOWN            0x281
 
+/* Selective Screenshot */
+#define KEY_SNIP                        0x282
+
 /*
  * Some keyboards have keys which do not have a defined meaning, these keys
  * are intended to be programmed / bound to macros by the user. For most
Signature · 1 line
2.25.0.265.gbab2e86ba0-goog
#2 lore raw
In reply to Rajat Jain
Quoted 14 lines · Rajat Jain

New keyboards can have backlight control keys. Allocating keycodes for them. Such keyboards are already available in ChromeOS.

---
 include/uapi/linux/input-event-codes.h | 4 ++++
 1 file changed, 4 insertions(+)
include/uapi/linux/input-event-codes.h +0 -0
index 0f1db1cccc3fd..e12a19dc30262 100644

include/uapi/linux/input-event-codes.h line 657

Quoted 6 lines
include/uapi/linux/input-event-codes.h +3 -0
@@ -652,6 +652,10 @@
 /* Electronic privacy screen control */
 #define KEY_PRIVACY_SCREEN_TOGGLE	0x279
 
+/* Keyboard Backlight control */
+#define KEY_KBD_BKLIGHT_UP              0x280
+#define KEY_KBD_BKLIGHT_DOWN            0x281

There's already KEY_KBDILLUMDOWN and KEY_KBDILLUMUP, used since the aluminium PowerBook G4 in 2005 (commit 146a4b3bdfb5641bfbf975e29680b482b8b343ba)

Quoted 6 lines
include/uapi/linux/input-event-codes.h +1 -0
+
 /*
  * Some keyboards have keys which do not have a defined meaning,

these keys
* are intended to be programmed / bound to macros by the user. For
most

author
#3 lore raw
Quoted 19 lines · Bastien Nocera
Quoted 17 lines · Rajat Jain

New keyboards can have backlight control keys. Allocating keycodes for them. Such keyboards are already available in ChromeOS.

---
 include/uapi/linux/input-event-codes.h | 4 ++++
 1 file changed, 4 insertions(+)
include/uapi/linux/input-event-codes.h +0 -0
index 0f1db1cccc3fd..e12a19dc30262 100644
@@ -652,6 +652,10 @@
 /* Electronic privacy screen control */
 #define KEY_PRIVACY_SCREEN_TOGGLE    0x279
 
Quoted 7 lines

include/uapi/linux/input-event-codes.h line 657

Quoted 3 lines
include/uapi/linux/input-event-codes.h +3 -0
+/* Keyboard Backlight control */
+#define KEY_KBD_BKLIGHT_UP              0x280
+#define KEY_KBD_BKLIGHT_DOWN            0x281

There's already KEY_KBDILLUMDOWN and KEY_KBDILLUMUP, used since the aluminium PowerBook G4 in 2005 (commit 146a4b3bdfb5641bfbf975e29680b482b8b343ba)

Thank you for pointing out. Yes, I think those key codes will work for me. I will use those instead.

Please consider this patch withdrawn.

Thanks & Best Regards,

Rajat Jain

Quoted 8 lines
Quoted 7 lines
include/uapi/linux/input-event-codes.h +1 -0
+
 /*
  * Some keyboards have keys which do not have a defined meaning,

these keys
* are intended to be programmed / bound to macros by the user. For
most