net/i40e: fix X722 performance drop
PATCH 1/1 net/i40e: fix X722 performance drop
GL_SWR_PM_UP_THR value lack in X722 caused configure register write not be called. This is the root cause of performance drop. This patch add support for:
Device-ID Value Comments
0x37D0 0x03030303 4x10G FPK
--- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value) { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) }, + { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
Signature · 1 line
2.9.5
Hi, Qiming
Quoted 3 lines · Qiming Yang
GL_SWR_PM_UP_THRvalue lack in X722 caused configure register write not be called. This is the root cause of performance drop. This patch add support for:
Could you elaborate what kind of performance drop caused by the missing register cfg?
Thanks,
Xiaolong
Quoted 27 lines
Device-ID Value Comments
0x37D00x030303034x10G FPKFixes 3320d4a240da ("net/i40e: workaround performance degradation")Signed-off-by Qiming Yang <[email protected]>---
drivers/net/i40e/i40e_ethdev.c| 1 +1 file changed, 1 insertion(+)drivers/net/i40e/i40e_ethdev.c +1
-0@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value) { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) }, + { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },Signature · 1 line
2.9.5
PATCH v2 1/1 net/i40e: fix X722 performance drop
In reply to Qiming YangLack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't reach line rate in one queue one core forwarding case. It's about 1% performance drop. This patch add value as:
Device-ID Value Comments
0x37D0 0x03030303 4x10G FPK
This value is hardware specific.
--- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value) { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) }, + { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
Signature · 1 line
2.9.5
Quoted 32 lines · Qiming Yang
Lack of
GL_SWR_PM_UP_THRvalue for mac type 4x10G X722 caused it can't reach line rate in one queue one core forwarding case. It's about 1% performance drop. This patch add value as:Device-ID Value Comments
0x37D00x030303034x10G FPKThis value is hardware specific.
Fixes 3320d4a240da ("net/i40e: workaround performance degradation")Signed-off-by Qiming Yang <[email protected]>---
drivers/net/i40e/i40e_ethdev.c| 1 +1 file changed, 1 insertion(+)drivers/net/i40e/i40e_ethdev.c +1
-0@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value) { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) }, + { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },Signature · 1 line
2.9.5
Applied to dpdk-next-net-intel, Thanks.