Skip to contentSkip to conversation

net/i40e: fix X722 performance drop

PATCH Superseded Qiming Yang 2 participants 4 messages Feb 26, 2020 – Mar 3, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/i40e: fix X722 performance drop

GL_SWR_PM_UP_THR value lack in X722 caused configure register write not be called. This is the root cause of performance drop. This patch add support for:

Device-ID Value Comments
0x37D0 0x03030303 4x10G FPK

Fixes 3320d4a240da ("net/i40e: workaround performance degradation")
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
index 9fbda1c..c09b9b9 100644
@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },
+		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) },
 
 		{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) },
 		{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
Signature · 1 line
2.9.5
#1 lore raw

Hi, Qiming

Quoted 3 lines · Qiming Yang

GL_SWR_PM_UP_THR value lack in X722 caused configure register write not be called. This is the root cause of performance drop. This patch add support for:

Could you elaborate what kind of performance drop caused by the missing register cfg?

Thanks,
Xiaolong

Quoted 27 lines

Device-ID Value Comments
0x37D0 0x03030303 4x10G FPK

Fixes 3320d4a240da ("net/i40e: workaround performance degradation")

---
drivers/net/i40e/i40e_ethdev.c | 1 +

1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
index 9fbda1c..c09b9b9 100644
@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },
+		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) },
 
 		{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) },
 		{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
Signature · 1 line
2.9.5
#2 lore raw

PATCH v2 1/1 net/i40e: fix X722 performance drop

In reply to Qiming Yang

Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't reach line rate in one queue one core forwarding case. It's about 1% performance drop. This patch add value as:

Device-ID Value Comments
0x37D0 0x03030303 4x10G FPK

This value is hardware specific.

Fixes 3320d4a240da ("net/i40e: workaround performance degradation")
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
index 9fbda1c..c09b9b9 100644
@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },
+		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) },
 
 		{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) },
 		{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
Signature · 1 line
2.9.5
Acked-by on v2 1/1 Applied
#3 lore raw
Quoted 32 lines · Qiming Yang

Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't reach line rate in one queue one core forwarding case. It's about 1% performance drop. This patch add value as:

Device-ID Value Comments
0x37D0 0x03030303 4x10G FPK

This value is hardware specific.

Fixes 3320d4a240da ("net/i40e: workaround performance degradation")

---
drivers/net/i40e/i40e_ethdev.c | 1 +

1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
index 9fbda1c..c09b9b9 100644
@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },
+		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) },
 
 		{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) },
 		{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
Signature · 1 line
2.9.5

Applied to dpdk-next-net-intel, Thanks.