xen/sched: fix error path in cpupool_unassign_cpu_start()
PATCH v2 1/1 xen/sched: fix error path in cpupool_unassign_cpu_start()
In case moving away all domains from the cpu to be removed is failing in cpupool_unassign_cpu_start() the error path is missing to release sched_res_rculock.
The normal exit path is releasing domlist_read_lock instead (this is currently no problem as the reference to the specific rcu lock is not used by rcu_read_unlock()).
While at it indent the present error label by one space.
---
V2:
- indent error labels (Jan Beulich)
--- xen/common/sched/cpupool.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
xen/common/sched/cpupool.c +4 -3
@@ -466,7 +466,7 @@ static int cpupool_unassign_cpu_start(struct cpupool *c, unsigned int cpu) }rcu_read_unlock (&domlist_read_lock);if ( ret ) - goto out; + goto out_rcu; } cpupool_moving_cpu = cpu;atomic_inc (&c->refcnt);
@@ -474,8 +474,9 @@ static int cpupool_unassign_cpu_start(struct cpupool *c, unsigned int cpu)cpumask_andnot (c->cpu_valid, c->cpu_valid, cpus);cpumask_and (c->res_valid, c->cpu_valid, &sched_res_mask); -rcu_read_unlock (&domlist_read_lock); -out: + out_rcu: +rcu_read_unlock (&sched_res_rculock); + out:spin_unlock (&cpupool_lock);return ret;
Signature · 7 lines
2.16.4 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 8 lines · Juergen Gross
In case moving away all domains from the cpu to be removed is failing in
cpupool_unassign_cpu_start()the error path is missing to releasesched_res_rculock.The normal exit path is releasing
domlist_read_lockinstead (this is currently no problem as the reference to the specific rcu lock is not used byrcu_read_unlock()).
Quoted 6 lines
While at it indent the present error label by one space.
Reported-by Igor Druzhinin <[email protected]>Signed-off-by Juergen Gross <[email protected]>Reviewed-by Jan Beulich <[email protected]>
Regards
Signature · 6 lines
Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <<This happens because _I_ choose it to happen!>> (Raistlin Majere)
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel