Skip to contentSkip to conversation

Makefile: remove bogus comment

PATCH New Thomas Petazzoni 2 participants 2 messages Mar 3, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: remove bogus comment

The comment "Check files that are touched by more than one package" was previously located right before the calls to the check-uniq-files script. However, this script and the logic calling it have been removed in commit 2496189a4207173e4cd5bbab90256f911175ee57 ("core:
drop check-uniq-files"), so the comment no longer makes any sense:
let's drop it.

---
 Makefile | 1 -
 1 file changed, 1 deletion(-)
Makefile +0 -1
index 10874e9b44..31624f77a2 100644
@@ -736,7 +736,6 @@ staging-finalize: $(STAGING_DIR_SYMLINK)
 target-finalize: $(PACKAGES) $(TARGET_DIR) host-finalize
 	@$(call MESSAGE,"Finalizing target directory")
 	$(call per-package-rsync,$(sort $(PACKAGES)),target,$(TARGET_DIR))
-	# Check files that are touched by more than one package
 	$(foreach hook,$(TARGET_FINALIZE_HOOKS),$($(hook))$(sep))
 	rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \
 		$(TARGET_DIR)/usr/lib/pkgconfig $(TARGET_DIR)/usr/share/pkgconfig \
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/1 Makefile: remove bogus comment

Thomas, All,

On 2020-03-03 22:09 +0100, Thomas Petazzoni spake thusly:

Quoted 8 lines

The comment "Check files that are touched by more than one package" was previously located right before the calls to the check-uniq-files script. However, this script and the logic calling it have been removed in commit 2496189a4207173e4cd5bbab90256f911175ee57 ("core:
drop check-uniq-files"), so the comment no longer makes any sense:
let's drop it.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 19 lines
---
 Makefile | 1 -
 1 file changed, 1 deletion(-)
Makefile +0 -1
index 10874e9b44..31624f77a2 100644
@@ -736,7 +736,6 @@ staging-finalize: $(STAGING_DIR_SYMLINK)
 target-finalize: $(PACKAGES) $(TARGET_DIR) host-finalize
 	@$(call MESSAGE,"Finalizing target directory")
 	$(call per-package-rsync,$(sort $(PACKAGES)),target,$(TARGET_DIR))
-	# Check files that are touched by more than one package
 	$(foreach hook,$(TARGET_FINALIZE_HOOKS),$($(hook))$(sep))
 	rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \
 		$(TARGET_DIR)/usr/lib/pkgconfig $(TARGET_DIR)/usr/share/pkgconfig \
Signature · 1 line
2.24.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'