Skip to contentSkip to conversation

package/nodejs: bump version to v12.16.1

PATCH New aduskett at gmail.com 3 participants 6 messages Mar 3, 2020 – Mar 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/nodejs: bump version to v12.16.1

From: Adam Duskett <[email protected]>

Tested on Debian 9 and Ubuntu 18.04

Fixes:
http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5

---
 package/nodejs/nodejs.hash | 4 ++--
 package/nodejs/nodejs.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
package/nodejs/nodejs.hash +2 -2
index 8a56c04713..992040d391 100644
@@ -1,5 +1,5 @@
-# From https://nodejs.org/dist/v12.16.0/SHASUMS256.txt
-sha256  b8c90637473fce4444a0b4fdae2c1560a1cf9f5959fdf9670541fc52868cf925  node-v12.16.0.tar.xz
+# From https://nodejs.org/dist/v12.16.1/SHASUMS256.txt
+sha256  0a95845ba02c46102b5671d0c5732460073f2d397488337e18d1fc30146d412d  node-v12.16.1.tar.xz
 
 # Hash for license file
 sha256  3f5749f7a58edaadd77843057a90063a18067f472d8b26c0a76905cafa1063e3  LICENSE
package/nodejs/nodejs.mk +1 -1
index 0de3495df9..7f875058b3 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-NODEJS_VERSION = 12.16.0
+NODEJS_VERSION = 12.16.1
 NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.xz
 NODEJS_SITE = http://nodejs.org/dist/v$(NODEJS_VERSION)
 NODEJS_DEPENDENCIES = host-python host-nodejs c-ares \
Signature · 1 line
2.21.1 (Apple Git-122.3)
#1 lore raw

PATCH 1/1 package/nodejs: bump version to v12.16.1

Hello Adam,

Quoted 7 lines · On Tue, 3 Mar 2020 11:11:33 -0800 aduskett at gmail.com wrote:

From: Adam Duskett <[email protected]>

Tested on Debian 9 and Ubuntu 18.04

Fixes:
http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5

Are you positive that this bump fixes the ICU issues? I.e did you reproduce the ICU issues before this version bump, and confirm they disappeared solely because of the version bump?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/nodejs: bump version to v12.16.1

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello Adam,

Quoted 4 lines · On Tue, 3 Mar 2020 11:11:33 -0800 aduskett at gmail.com wrote:

From: Adam Duskett <[email protected]>

Tested on Debian 9 and Ubuntu 18.04

Quoted 7 lines
Quoted 3 lines

Fixes:
http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5

Are you positive that this bump fixes the ICU issues? I.e did you reproduce the ICU issues before this version bump, and confirm they disappeared solely because of the version bump?

It sounds unlikely, given the very few commits between 12.16.0 and 12.16.1, and nothing mentioned in the changelog about icu:

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#12.16.1

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 package/nodejs: bump version to v12.16.1

Quoted 4 lines · On Tue, 03 Mar 2020 23:31:55 +0100 Peter Korsgaard <[email protected]> wrote:
Quoted 3 lines
Quoted 3 lines

Fixes:
http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5

Quoted 8 lines
Quoted 3 lines

Are you positive that this bump fixes the ICU issues? I.e did you reproduce the ICU issues before this version bump, and confirm they disappeared solely because of the version bump?

It sounds unlikely, given the very few commits between 12.16.0 and 12.16.1, and nothing mentioned in the changelog about icu:

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#12.16.1

Right, so I'm quite doubtful about the "Fixes" tag. I suppose Adam did not reproduce the issue after the bump, but also did not have the issue before the bump.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/nodejs: bump version to v12.16.1

In reply to Thomas Petazzoni
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello Adam,

Quoted 4 lines · On Tue, 3 Mar 2020 11:11:33 -0800 aduskett at gmail.com wrote:

From: Adam Duskett <[email protected]>

Tested on Debian 9 and Ubuntu 18.04

Quoted 7 lines
Quoted 3 lines

Fixes:
http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5

Are you positive that this bump fixes the ICU issues? I.e did you reproduce the ICU issues before this version bump, and confirm they disappeared solely because of the version bump?

Committed to master after dropping the fixes as discussed on IRC and extending the commit message info about the regressions fixed in 12.16.1, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 package/nodejs: bump version to v12.16.1

Quoted 15 lines
Quoted 14 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

"Peter" == Peter Korsgaard <[email protected]> writes:

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello Adam,

Quoted 7 lines · On Tue, 3 Mar 2020 11:11:33 -0800 aduskett at gmail.com wrote:

From: Adam Duskett <[email protected]>

Tested on Debian 9 and Ubuntu 18.04

Fixes:
http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5

Quoted 7 lines
Quoted 3 lines

Are you positive that this bump fixes the ICU issues? I.e did you reproduce the ICU issues before this version bump, and confirm they disappeared solely because of the version bump?

Committed to master after dropping the fixes as discussed on IRC and extending the commit message info about the regressions fixed in 12.16.1, thanks.

Committed to 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard