Skip to contentSkip to conversation

memcg/stress: Lower swap memory use

PATCH New Petr Vorel 3 participants 4 messages Jan 17, 2020 – Mar 4, 2020

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/1 memcg/stress: Lower swap memory use

Fix freeze on systems, where where swap size is more or less equal to a system RAM.

Fixes #632
---
 testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh +1 -1
index ad8605e16..a48d21e6e 100755
@@ -33,7 +33,7 @@ setup()
 	local swap_free=`cat /proc/meminfo | grep SwapFree | awk '{ print $2 }'`
 	local pgsize=`tst_getconf PAGESIZE`
 
-	MEM=$(( $mem_free + $swap_free / 2 ))
+	MEM=$(( $mem_free + $swap_free / 1O ))
 	MEM=$(( $MEM / 1024 ))
 	RUN_TIME=$(( 15 * 60 ))
 	[ "$pgsize" = "4096" ] && THREAD_SPARE_MB=1 || THREAD_SPARE_MB=8
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/1 memcg/stress: Lower swap memory use

Ack.

Quoted 33 lines · On Fri, Jan 17, 2020, 07:36 Petr Vorel <[email protected]> wrote:

Fix freeze on systems, where where swap size is more or less equal to a system RAM.

Fixes #632
---
 testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh b/testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh index ad8605e16..a48d21e6e 100755

testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh +0 -0
@@ -33,7 +33,7 @@ setup()
        local swap_free=`cat /proc/meminfo | grep SwapFree | awk '{ print

$2 }'`
local pgsize=tst_getconf PAGESIZE

testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh +1 -2
-       MEM=$(( $mem_free + $swap_free / 2 ))
+       MEM=$(( $mem_free + $swap_free / 1O ))
        MEM=$(( $MEM / 1024 ))
        RUN_TIME=$(( 15 * 60 ))
        [ "$pgsize" = "4096" ] && THREAD_SPARE_MB=1 || THREAD_SPARE_MB=8
--

2.24.1

Quoted 4 lines

--
Mailing list info: https://lists.linux.it/listinfo/ltp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200119/b33cf33a/attachment.htm>

#2 lore raw

PATCH 1/1 memcg/stress: Lower swap memory use

In reply to Petr Vorel

Hi!

Quoted 18 lines

Fix freeze on systems, where where swap size is more or less equal to a system RAM.

Fixes #632
---
 testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh +0 -0
index ad8605e16..a48d21e6e 100755

testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh setup() · line 36

Quoted 5 lines
testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh +1 -1
@@ -33,7 +33,7 @@ setup()
 	local swap_free=`cat /proc/meminfo | grep SwapFree | awk '{ print $2 }'`
 	local pgsize=`tst_getconf PAGESIZE`
 
-	MEM=$(( $mem_free + $swap_free / 2 ))
+	MEM=$(( $mem_free + $swap_free / 1O ))

I wonder if we can be a bit smarter about this. Maybe we should add some percentage of RAM if enough swap is present.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#3 lore raw

PATCH 1/1 memcg/stress: Lower swap memory use

In reply to Petr Vorel

ji,

testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh setup() · line 36

Quoted 2 lines
testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh +1 -1
-	MEM=$(( $mem_free + $swap_free / 2 ))
+	MEM=$(( $mem_free + $swap_free / 1O ))

Sorry, this is a typo, it's "o", but it must be 0. MEM=$(( $mem_free + $swap_free / 10 ))

Kind regards,
Petr