Skip to contentSkip to conversation

Makefile: work around a bug in newly released make 4.3

PATCH New Yann E. MORIN 3 participants 4 messages Mar 4, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: work around a bug in newly released make 4.3

Several users of rolling-release distributions have been reporting on IRC that Buildroot is broken now that they have switched to the newly released make 4.3.

It turns out that the constructs we use to generated and ionclude the internal br2-external related fragments is no longer working with make-4.3.

Indeed, an upstream bug report [0] seems to imply that it so far was working by chance. There has been no further feedback, whether this is really considered a fix or a regression...

In the meantime, we add a workaround that fixes the issue, and should not break on older make versions either (verified on all relevant
versions: 3.81, 3.82, 4.0, 4.1, and 4.2).

---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)
Makefile +3 -0
index 31624f77a2..c22c1d8980 100644
@@ -188,6 +188,9 @@ ifneq ($(BR2_EXTERNAL_ERROR),)
 $(error $(BR2_EXTERNAL_ERROR))
 endif
 
+# Workaround bug #57676 in make-4.3
+$(BASE_DIR)/.br2-external.mk:;
+
 # To make sure that the environment variable overrides the .config option,
 # set this before including .config.
 ifneq ($(BR2_DL_DIR),)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 Makefile: work around a bug in newly released make 4.3

Hello,

Quoted 11 lines · On Wed, 4 Mar 2020 13:53:30 +0100 "Yann E. MORIN" <[email protected]>…

Several users of rolling-release distributions have been reporting on IRC that Buildroot is broken now that they have switched to the newly released make 4.3.

It turns out that the constructs we use to generated and ionclude the internal br2-external related fragments is no longer working with make-4.3.

Indeed, an upstream bug report [0] seems to imply that it so far was working by chance. There has been no further feedback, whether this is really considered a fix or a regression...

What does [0] points to ?

Quoted 4 lines

In the meantime, we add a workaround that fixes the issue, and should not break on older make versions either (verified on all relevant
versions: 3.81, 3.82, 4.0, 4.1, and 4.2).

Could you give more details about how the workaround fixes the issue ?

Quoted 11 lines
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)
Makefile +0 -0
index 31624f77a2..c22c1d8980 100644

Makefile ifneq ($(BR2_EXTERNAL_ERROR),) · line 191

Quoted 4 lines
Makefile +1 -0
@@ -188,6 +188,9 @@ ifneq ($(BR2_EXTERNAL_ERROR),)
 $(error $(BR2_EXTERNAL_ERROR))
 endif
 
+# Workaround bug #57676 in make-4.3

Perhaps an http:// link instead of just #57676 ?

Makefile ifneq ($(BR2_EXTERNAL_ERROR),) · line 196

Quoted 5 lines
Makefile +2 -0
+$(BASE_DIR)/.br2-external.mk:;
+
 # To make sure that the environment variable overrides the .config option,
 # set this before including .config.
 ifneq ($(BR2_DL_DIR),)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 Makefile: work around a bug in newly released make 4.3

Thomas, All,

On 2020-03-04 14:04 +0100, Thomas Petazzoni spake thusly:

Quoted 7 lines
Quoted 4 lines · On Wed, 4 Mar 2020 13:53:30 +0100 "Yann E. MORIN" <[email protected]>…

Several users of rolling-release distributions have been reporting on IRC that Buildroot is broken now that they have switched to the newly released make 4.3.

Quoted 8 lines
Quoted 7 lines

It turns out that the constructs we use to generated and ionclude the internal br2-external related fragments is no longer working with make-4.3.

Indeed, an upstream bug report [0] seems to imply that it so far was working by chance. There has been no further feedback, whether this is really considered a fix or a regression...

What does [0] points to ?

Well, to the upstream bug report, obviously! ;-]
Fixed, thanks.

Quoted 4 lines
Quoted 3 lines

In the meantime, we add a workaround that fixes the issue, and should not break on older make versions either (verified on all relevant
versions: 3.81, 3.82, 4.0, 4.1, and 4.2).

Could you give more details about how the workaround fixes the issue ?

Oh yes, I surely can: it was suggested in that bug report! ;-)

Honestly, I am not sure I totally understood the reason, or the workaround...

Quoted 13 lines
Quoted 13 lines
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)
Makefile +0 -0
index 31624f77a2..c22c1d8980 100644
@@ -188,6 +188,9 @@ ifneq ($(BR2_EXTERNAL_ERROR),)
 $(error $(BR2_EXTERNAL_ERROR))
 endif
 
Quoted 2 lines

Makefile ifneq ($(BR2_EXTERNAL_ERROR),) · line 191

Quoted 1 line
Makefile +1 -0
+# Workaround bug #57676 in make-4.3

Perhaps an http:// link instead of just #57676 ?

Even if it is in the commit log now?

Regards,
Yann E. MORIN.

Quoted 13 lines

Makefile ifneq ($(BR2_EXTERNAL_ERROR),) · line 196

Quoted 5 lines
Makefile +2 -0
+$(BASE_DIR)/.br2-external.mk:;
+
 # To make sure that the environment variable overrides the .config option,
 # set this before including .config.
 ifneq ($(BR2_DL_DIR),)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 Makefile: work around a bug in newly released make 4.3

In reply to Yann E. MORIN

Hi Yann,

I've tested the patch against master and using a br2-external tree and it works.
I've also tested it against buildroot-2019.02.9, but there it needs to be adjusted: $(BASE_DIR)/.br-external.mk:;

Mircea

________________________________________
From: buildroot <[email protected]> on behalf of Yann E. MORIN <[email protected]>
Sent: Wednesday, March 4, 2020 14:53
To: buildroot at buildroot.org
Cc: Yann E. MORIN
Subject: [Buildroot] [PATCH] Makefile: work around a bug in newly released make 4.3

Several users of rolling-release distributions have been reporting on IRC that Buildroot is broken now that they have switched to the newly released make 4.3.

It turns out that the constructs we use to generated and ionclude the internal br2-external related fragments is no longer working with make-4.3.

Indeed, an upstream bug report [0] seems to imply that it so far was working by chance. There has been no further feedback, whether this is really considered a fix or a regression...

In the meantime, we add a workaround that fixes the issue, and should not break on older make versions either (verified on all relevant
versions: 3.81, 3.82, 4.0, 4.1, and 4.2).

---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)
Makefile +3 -0
index 31624f77a2..c22c1d8980 100644
@@ -188,6 +188,9 @@ ifneq ($(BR2_EXTERNAL_ERROR),)
 $(error $(BR2_EXTERNAL_ERROR))
 endif
 
+# Workaround bug #57676 in make-4.3
+$(BASE_DIR)/.br2-external.mk:;
+
 # To make sure that the environment variable overrides the .config option,
 # set this before including .config.
 ifneq ($(BR2_DL_DIR),)

--
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

________________________
This email was scanned by Bitdefender