Support stop state version quirk and firmware enabled stop
RFC 1/1 Support stop state version quirk and firmware enabled stop
A concept patch in Skiboot to illustrate the case wherein handling of stop states for different DD versions of a CPU can be achieved by a simple modification in the list of cpu_features.
As an example idle-stop1 is defined which uses P9_CPU_DD1 to define the cpu feature.
Along with that, an implementation is being worked upon the LE OPAL series which helps OPAL handle the stop state entry and exit.
This patch advertises this capability of the firmware which can be availed if the quirk-version-setting is not cognizable.
The firmware-enabled stop is being worked by Abhishek Goel <[email protected]> building upon the LE OPAL series.
--- core/cpufeatures.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
core/cpufeatures.c +22 -0
@@ -510,6 +510,25 @@ static const struct cpu_feature cpu_features_table[] = { -1, -1, -1, NULL, }, +/* +* QUIRK for ISAv3.0B stop idle instructions and registers +* Helps us determine if there are any quirks +* XXX: Same of idle-stop +*/ + {"idle-stop-v1" , +CPU_P9_DD1 , +ISA_V3_0B ,USABLE_HV |USABLE_OS , +HV_CUSTOM ,OS_CUSTOM , +-1 ,-1 ,-1 , + NULL, }, + + { "firmware-stop-supported", +CPU_P9 , +ISA_V3_0B ,USABLE_HV |USABLE_OS , +HV_CUSTOM ,OS_CUSTOM , +-1 ,-1 ,-1 , + NULL, }, +/* * ISAv3.0B Hypervisor Virtualization Interrupt * Also associated system registers, LPCR EE, HEIC, HVICE,
@@ -883,6 +902,9 @@ static void add_cpufeatures(struct dt_node *cpus,const struct cpu_feature *f = &cpu_features_table[i];if (f->cpus_supported & cpu_feature_cpu) { +if (!strcmp (f->name,"firmware-stop-supported" ) && +HAVE_BIG_ENDIAN ) +continue ;DBG (" '%s'\n" , f->name);add_cpu_feature_nodeps (features, f); }
Signature · 1 line
2.24.1
Hi Pratik,
Quoted 29 lines · Pratik Rajesh Sampat
A concept patch in Skiboot to illustrate the case wherein handling of stop states for different DD versions of a CPU can be achieved by a simple modification in the list of
cpu_features.
As an example idle-stop1 is defined which usesP9_CPU_DD1to define the cpu feature.Along with that, an implementation is being worked upon the LE OPAL series which helps OPAL handle the stop state entry and exit.
This patch advertises this capability of the firmware which can be availed if the quirk-version-setting is not cognizable.
The firmware-enabled stop is being worked by Abhishek Goel <[email protected]> building upon the LE OPAL series.
Signed-off-by Pratik Rajesh Sampat <[email protected]>--- core/cpufeatures.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)core/cpufeatures.c +1
-0@@ -510,6 +510,25 @@ static const struct cpu_feature cpu_features_table[] = {-1 ,-1 ,-1 , NULL, }, +/*
core/cpufeatures.c static const struct cpu_feature cpu_features_table[] = { · line 523
Quoted 10 lines
core/cpufeatures.c +10
-0+* QUIRK for ISAv3.0B stop idle instructions and registers +* Helps us determine if there are any quirks +* XXX: Same of idle-stop +*/ + {"idle-stop-v1" , +CPU_P9_DD1 , +ISA_V3_0B ,USABLE_HV |USABLE_OS , +HV_CUSTOM ,OS_CUSTOM , +-1 ,-1 ,-1 , + NULL, },
So, at this point, we don't need any such quirk for any of the DD version right ? This is to demonstrate that if say P9_DD1 had a quirk w.r.t stop-state handling, then this is how we would advertise it to the kernel.
core/cpufeatures.c static const struct cpu_feature cpu_features_table[] = { · line 531
Quoted 8 lines
core/cpufeatures.c +8
-0+ + {"firmware-stop-supported" , +CPU_P9 , +ISA_V3_0B ,USABLE_HV |USABLE_OS , +HV_CUSTOM ,OS_CUSTOM , +-1 ,-1 ,-1 , + NULL, }, +
I suppose this is for the opal-cpuidle driver support posted here:
https://lists.ozlabs.org/pipermail/skiboot/2020-April/016726.html
core/cpufeatures.c static void add_cpufeatures(struct dt_node *cpus, · line 907
Quoted 10 lines
core/cpufeatures.c +3
-0/* * ISAv3.0B Hypervisor Virtualization Interrupt * Also associated system registers, LPCR EE, HEIC, HVICE, @@ -883,6 +902,9 @@ static void add_cpufeatures(struct dt_node *cpus,const struct cpu_feature *f = &cpu_features_table[i];if (f->cpus_supported & cpu_feature_cpu) { +if (!strcmp (f->name,"firmware-stop-supported" ) && +HAVE_BIG_ENDIAN ) +continue ;
In OPAL do we have an macro defining BIG_ENDIAN ? If yes, you could wrap the "firmware-stop-supported" in cpu_features_table[] within #ifndef BIG_ENDIAN. That way you won't need a special case here.
Quoted 6 lines
core/cpufeatures.c +0
-0DBG (" '%s'\n" , f->name);add_cpu_feature_nodeps (features, f); }Signature · 1 line
2.24.1
--
Thanks and Regards
gautham.
Hello Gautham,
Quoted 31 lines · Gautham R Shenoy
Hi Pratik,
Quoted 28 lines · Pratik Rajesh Sampat
A concept patch in Skiboot to illustrate the case wherein handling of stop states for different DD versions of a CPU can be achieved by a simple modification in the list of
cpu_features.
As an example idle-stop1 is defined which usesP9_CPU_DD1to define the cpu feature.Along with that, an implementation is being worked upon the LE OPAL series which helps OPAL handle the stop state entry and exit.
This patch advertises this capability of the firmware which can be availed if the quirk-version-setting is not cognizable.
The firmware-enabled stop is being worked by Abhishek Goel <[email protected]> building upon the LE OPAL series.
Signed-off-by Pratik Rajesh Sampat <[email protected]>--- core/cpufeatures.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)core/cpufeatures.c +0
-0@@ -510,6 +510,25 @@ static const struct cpu_feature cpu_features_table[] = {-1 ,-1 ,-1 , NULL, },
Quoted 16 lines
core/cpufeatures.c static const struct cpu_feature cpu_features_table[] = { · line 523
Quoted 11 lines
core/cpufeatures.c +11
-0+/* +* QUIRK for ISAv3.0B stop idle instructions and registers +* Helps us determine if there are any quirks +* XXX: Same of idle-stop +*/ + {"idle-stop-v1" , +CPU_P9_DD1 , +ISA_V3_0B ,USABLE_HV |USABLE_OS , +HV_CUSTOM ,OS_CUSTOM , +-1 ,-1 ,-1 , + NULL, },So, at this point, we don't need any such quirk for any of the DD version right ? This is to demonstrate that if say
P9_DD1had a quirk w.r.t stop-state handling, then this is how we would advertise it to the kernel.
Absolutely, A dummy property has been added to show how quirk handling with stop-states.
Quoted 11 lines
core/cpufeatures.c static const struct cpu_feature cpu_features_table[] = { · line 531
Quoted 8 lines
core/cpufeatures.c +8
-0+ + {"firmware-stop-supported" , +CPU_P9 , +ISA_V3_0B ,USABLE_HV |USABLE_OS , +HV_CUSTOM ,OS_CUSTOM , +-1 ,-1 ,-1 , + NULL, }, +I suppose this is for the opal-cpuidle driver support posted here:
https://lists.ozlabs.org/pipermail/skiboot/2020-April/016726.html
Right, this complements in usage of the opal-cpuidle driver
Quoted 6 lines
Quoted 6 lines
core/cpufeatures.c +0
-0/* * ISAv3.0B Hypervisor Virtualization Interrupt * Also associated system registers, LPCR EE, HEIC, HVICE, @@ -883,6 +902,9 @@ static void add_cpufeatures(struct dt_node *cpus,const struct cpu_feature *f = &cpu_features_table[i];
Quoted 8 lines
core/cpufeatures.c static void add_cpufeatures(struct dt_node *cpus, · line 907
Quoted 4 lines
core/cpufeatures.c +3
-0if (f->cpus_supported & cpu_feature_cpu) { +if (!strcmp (f->name,"firmware-stop-supported" ) && +HAVE_BIG_ENDIAN ) +continue ;In OPAL do we have an macro defining
BIG_ENDIAN? If yes, you could wrap the "firmware-stop-supported" in cpu_features_table[] within #ifndefBIG_ENDIAN. That way you won't need a special case here.
HAVE_BIG_ENDIAN is actually a macro. Its a good idea to wrap it in the declaration itself.
Quoted 10 lines
Quoted 7 lines
core/cpufeatures.c +0
-0DBG (" '%s'\n" , f->name);add_cpu_feature_nodeps (features, f); }Signature · 1 line
2.24.1--
Thanks and Regards
gautham.