Skip to contentSkip to conversation

PCI: hv: Replace zero-length array with flexible-array member

PATCH In review Gustavo A. R. Silva 4 participants 6 messages Feb 13, 2020 – Mar 4, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: hv: Replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by this change:

"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

---
 drivers/pci/controller/pci-hyperv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pci/controller/pci-hyperv.c +3 -3
index 9977abff92fc..be957268f9d6 100644
@@ -260,7 +260,7 @@ struct pci_packet {
 				int resp_packet_size);
 	void *compl_ctxt;
 
-	struct pci_message message[0];
+	struct pci_message message[];
 };
 
 /*
@@ -296,7 +296,7 @@ struct pci_bus_d0_entry {
 struct pci_bus_relations {
 	struct pci_incoming_message incoming;
 	u32 device_count;
-	struct pci_function_description func[0];
+	struct pci_function_description func[];
 } __packed;
 
 struct pci_q_res_req_response {
@@ -508,7 +508,7 @@ struct hv_dr_work {
 struct hv_dr_state {
 	struct list_head list_entry;
 	u32 device_count;
-	struct pci_function_description func[0];
+	struct pci_function_description func[];
 };
 
 enum hv_pcichild_state {
Signature · 1 line
2.23.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines

From: [email protected] <[email protected]> On Behalf Of Gustavo A. R. Silva
Sent: Wednesday, February 12, 2020 4:51 PM
...
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.

Quoted 8 lines

Also, notice that, dynamic memory allocations won't be affected by this change:

"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

Looks good to me. Thanks, Gustavo!

FWIW, it looks there are a lot of more to fix in the kernel tree: the below commands return 1373 for me:

grep -nr '\[0\];$' * | grep '\.h:' | grep -v = | wc -l

Running the commands against the kernel/ directory returns 3.

Thanks,
-- Dexuan

maintainer
#2 lore raw
Quoted 26 lines · Dexuan Cui
Quoted 26 lines

From: [email protected] <[email protected]> On Behalf Of Gustavo A. R. Silva
Sent: Wednesday, February 12, 2020 4:51 PM
...
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by this change:

"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]

Quoted 6 lines
Quoted 1 line

This issue was found with the help of Coccinelle.

Looks good to me. Thanks, Gustavo!

Lorenzo, will you be picking up this patch? It seems to me you've been handling patches to pci-hyperv.c. This patch is not yet in pci/hv branch in your repository.

Let me know what you think.

Wei.

#3 lore raw
Quoted 31 lines · Wei Liu
Quoted 30 lines · Dexuan Cui
Quoted 19 lines

From: [email protected] <[email protected]> On Behalf Of Gustavo A. R. Silva
Sent: Wednesday, February 12, 2020 4:51 PM
...
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.

Quoted 8 lines

Also, notice that, dynamic memory allocations won't be affected by this change:

"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

Looks good to me. Thanks, Gustavo!

Quoted 8 lines
Quoted 2 lines

Lorenzo, will you be picking up this patch? It seems to me you've been handling patches to pci-hyperv.c. This patch is not yet in pci/hv branch in your repository.

Let me know what you think.

I shall pick it up, I checked patchwork and it was erroneously assigned to Bjorn, that's why I have not taken it yet.

Fixed now, apologies, I will merge it shortly.

Lorenzo

maintainer
#4 lore raw
Quoted 39 lines · Lorenzo Pieralisi
Quoted 38 lines · Wei Liu
Quoted 26 lines · Dexuan Cui
Quoted 26 lines

From: [email protected] <[email protected]> On Behalf Of Gustavo A. R. Silva
Sent: Wednesday, February 12, 2020 4:51 PM
...
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by this change:

"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]

Quoted 6 lines
Quoted 1 line

This issue was found with the help of Coccinelle.

Looks good to me. Thanks, Gustavo!

Lorenzo, will you be picking up this patch? It seems to me you've been handling patches to pci-hyperv.c. This patch is not yet in pci/hv branch in your repository.

Quoted 6 lines
Quoted 1 line

Let me know what you think.

I shall pick it up, I checked patchwork and it was erroneously assigned to Bjorn, that's why I have not taken it yet.

Fixed now, apologies, I will merge it shortly.

Thanks for picking it up.

Wei.

Quoted 2 lines

Lorenzo

#5 lore raw
Quoted 10 lines · Wei Liu
Quoted 10 lines
Quoted 10 lines
Quoted 5 lines

Looks good to me. Thanks, Gustavo!

Lorenzo, will you be picking up this patch? It seems to me you've been handling patches to pci-hyperv.c. This patch is not yet in pci/hv branch in your repository.

Quoted 9 lines
Quoted 6 lines
Quoted 1 line

Let me know what you think.

I shall pick it up, I checked patchwork and it was erroneously assigned to Bjorn, that's why I have not taken it yet.

Fixed now, apologies, I will merge it shortly.

Thanks for picking it up.

Thank you all, guys. :)
--
Gustavo