Skip to contentSkip to conversation

virt_wifi: implement ndo_get_iflink

PATCH In review Taehee Yoo 2 participants 2 messages Mar 5, 2020 – Mar 11, 2020 Networking drivers (wireless)

lore
Share & tools
lore

Taehee Yoo

author
#0 lore raw

PATCH 1/1 virt_wifi: implement ndo_get_iflink

->ndo_get_iflink() is useful for finding lower interface.

Test commands:
ip link add dummy0 type dummy
ip link add vw1 link dummy0 type virt_wifi
ip link show vw1

Before:

    9: vw1: <BROADCAST,MULTICAST> ...
After:
    9: vw1@dummy0: <BROADCAST,MULTICAST> ...
---
 drivers/net/wireless/virt_wifi.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/net/wireless/virt_wifi.c +10 -2
index 01305ba2d3aa..c878097f0dda 100644
@@ -436,10 +436,18 @@ static int virt_wifi_net_device_stop(struct net_device *dev)
 	return 0;
 }
 
+static int virt_wifi_net_device_get_iflink(const struct net_device *dev)
+{
+	struct virt_wifi_netdev_priv *priv = netdev_priv(dev);
+
+	return priv->lowerdev->ifindex;
+}
+
 static const struct net_device_ops virt_wifi_ops = {
 	.ndo_start_xmit = virt_wifi_start_xmit,
-	.ndo_open = virt_wifi_net_device_open,
-	.ndo_stop = virt_wifi_net_device_stop,
+	.ndo_open	= virt_wifi_net_device_open,
+	.ndo_stop	= virt_wifi_net_device_stop,
+	.ndo_get_iflink = virt_wifi_net_device_get_iflink,
 };
 
 /* Invoked as part of rtnl lock release. */
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 11 lines · Taehee Yoo

->ndo_get_iflink() is useful for finding lower interface.

Test commands:
ip link add dummy0 type dummy
ip link add vw1 link dummy0 type virt_wifi
ip link show vw1

Before:

    9: vw1: <BROADCAST,MULTICAST> ...
After:
    9: vw1@dummy0: <BROADCAST,MULTICAST> ...

So I guess from a netdev layering perspective that makes sense, but I'd like to hear from Cody if that's really desired from a testing perspective?

This driver is fundamentally a testing tool and doesn't really have a place in a production system, so I'd be more likely to look at the testing needs for this.

Thanks,
johannes