drm: etnaviv_gem.h: Replace zero-length array with flexible-array member
Subsystems (2)
PATCH 1/1 drm: etnaviv_gem.h: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo {
int stuff;
struct boo array[];
};By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
--- drivers/gpu/drm/etnaviv/etnaviv_gem.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/etnaviv/etnaviv_gem.h +1 -1
@@ -105,7 +105,7 @@ struct etnaviv_gem_submit {unsigned int nr_pmrs;struct etnaviv_perfmon_request *pmrs;unsigned int nr_bos; -struct etnaviv_gem_submit_bo bos[0 ]; +struct etnaviv_gem_submit_bo bos[];/* No new members here, the previous one is variable-length! */ };
Signature · 1 line
2.25.0
Lucas Stach
maintainerHi Gustavo,
I've adjusted the subject a bit to match the style of the other etnaviv driver commits and applied this to the etnaviv/next branch.
Regards,
Lucas
Quoted 38 lines · Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo { int stuff; struct boo array[]; };By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit76497732932f("cxgb3/l2t: Fix undefined behaviour")Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/gpu/drm/etnaviv/etnaviv_gem.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/etnaviv/etnaviv_gem.h +0
-0
drivers/gpu/drm/etnaviv/etnaviv_gem.h struct etnaviv_gem_submit { · line 111
Quoted 8 lines
drivers/gpu/drm/etnaviv/etnaviv_gem.h +1
-1@@ -105,7 +105,7 @@ struct etnaviv_gem_submit {unsigned int nr_pmrs;struct etnaviv_perfmon_request *pmrs;unsigned int nr_bos; -struct etnaviv_gem_submit_bo bos[0 ]; +struct etnaviv_gem_submit_bo bos[];/* No new members here, the previous one is variable-length! */ };
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Lucas,
Quoted 5 lines · Lucas Stach
Hi Gustavo,
I've adjusted the subject a bit to match the style of the other etnaviv driver commits and applied this to the etnaviv/next branch.
Great. Thanks a lot for that. :)
--
Gustavo
Quoted 37 lines
Regards,
LucasQuoted 33 lines · Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo { int stuff; struct boo array[]; };By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit76497732932f("cxgb3/l2t: Fix undefined behaviour")Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/gpu/drm/etnaviv/etnaviv_gem.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
drivers/gpu/drm/etnaviv/etnaviv_gem.h struct etnaviv_gem_submit { · line 111
Quoted 13 lines
drivers/gpu/drm/etnaviv/etnaviv_gem.h +1
-1@@ -105,7 +105,7 @@ struct etnaviv_gem_submit {unsigned int nr_pmrs;struct etnaviv_perfmon_request *pmrs;unsigned int nr_bos; -struct etnaviv_gem_submit_bo bos[0 ]; +struct etnaviv_gem_submit_bo bos[];/* No new members here, the previous one is variable-length! */ };
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel