Skip to contentSkip to conversation

package/jpeg-turbo: fix build with SIMD

PATCH New Fabrice Fontaine 2 participants 2 messages Feb 11, 2020 – Mar 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/jpeg-turbo: fix build with SIMD

Add -fPIC as requested by upstream in
https://github.com/libjpeg-turbo/libjpeg-turbo/pull/366

Fixes:
- http://autobuild.buildroot.org/results/5b7ce0a8f8d1f485bd7104ac2b40257bb17b284b

---
Changes v1 -> v2:
- Fix typo in title: without -> with

 package/jpeg-turbo/jpeg-turbo.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/jpeg-turbo/jpeg-turbo.mk +3 -1
index 2767ce6de4..1d24406e0f 100644
@@ -13,7 +13,9 @@ JPEG_TURBO_INSTALL_STAGING = YES
 JPEG_TURBO_PROVIDES = jpeg
 JPEG_TURBO_DEPENDENCIES = host-pkgconf
 
-JPEG_TURBO_CONF_OPTS = -DWITH_JPEG8=ON
+JPEG_TURBO_CONF_OPTS = \
+	-DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -fPIC" \
+	-DWITH_JPEG8=ON
 
 ifeq ($(BR2_STATIC_LIBS),y)
 JPEG_TURBO_CONF_OPTS += -DENABLE_STATIC=ON -DENABLE_SHARED=OFF
Signature · 1 line
2.24.1
#1 lore raw

PATCH v2 1/1 package/jpeg-turbo: fix build with SIMD

Fabrice, All,

On 2020-02-11 21:40 +0100, Fabrice Fontaine spake thusly:

Quoted 2 lines

Add -fPIC as requested by upstream in
https://github.com/libjpeg-turbo/libjpeg-turbo/pull/366

The comment from upstream does not seem entirely correct, as I can understand...

Quoted 2 lines

Fixes:
- http://autobuild.buildroot.org/results/5b7ce0a8f8d1f485bd7104ac2b40257bb17b284b

I was unable to reproduce this build failure on current master...

It seems that 37f3d09d46a (package/jpeg-turbo: force fPIC for shared libraries) fixed it in a different manner (I reverted said commit, and got the faillure back).

Regards,
Yann E. MORIN.

Quoted 30 lines

---
Changes v1 -> v2:
- Fix typo in title: without -> with

 package/jpeg-turbo/jpeg-turbo.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/jpeg-turbo/jpeg-turbo.mk +3 -1
index 2767ce6de4..1d24406e0f 100644
@@ -13,7 +13,9 @@ JPEG_TURBO_INSTALL_STAGING = YES
 JPEG_TURBO_PROVIDES = jpeg
 JPEG_TURBO_DEPENDENCIES = host-pkgconf
 
-JPEG_TURBO_CONF_OPTS = -DWITH_JPEG8=ON
+JPEG_TURBO_CONF_OPTS = \
+	-DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -fPIC" \
+	-DWITH_JPEG8=ON
 
 ifeq ($(BR2_STATIC_LIBS),y)
 JPEG_TURBO_CONF_OPTS += -DENABLE_STATIC=ON -DENABLE_SHARED=OFF
Signature · 6 lines
2.24.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'