wait_task_inactive() spend too much time on system startup
v3 cover wait_task_inactive() spend too much time on system startup
From: Liang Chen <[email protected]>
Changelog:
v1: wait_task_inactive() frequently call schedule_hrtimeout() and spend a lot of time, i am trying to optimize it on rockchip platform.
v2: Use atomic_flags(PFA) instead of TIF flag, and add some comments.
v3: Use a new method fix this issue to make the code simple.
Liang Chen (1):
kthread: do not preempt current task if it is going to call schedule()
kernel/kthread.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
PATCH v3 1/1 kthread: do not preempt current task if it is going to call schedule()
From: Liang Chen <[email protected]>
when we create a kthread with ktrhead_create_on_cpu(),the child thread entry is ktread.c:ktrhead() which will be preempted by the parent after call complete(done) while schedule() is not called yet,then the parent will call wait_task_inactive(child) but the child is still on the runqueue, so the parent will schedule_hrtimeout() for 1 jiffy,it will waste a lot of time,especially on startup.
parent childktrhead_create_on_cpu()
wait_fo_completion(&done) -----> ktread.c:ktrhead()
|----- complete(done);--wakeup and preempted by parent
kthread_bind() <------------| |-> schedule();--dequeue here wait_task_inactive(child) | schedule_hrtimeout(1 jiffy) -|
So we hope the child just wakeup parent but not preempted by parent, and the child is going to call schedule() soon,then the parent will not call schedule_hrtimeout(1 jiffy) as the child is already dequeue.
The same issue for ktrhead_park()&&kthread_parkme(). This patch can save 120ms on rk312x startup with CONFIG_HZ=300.
--- kernel/kthread.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
kernel/kthread.c +15 -2
@@ -199,8 +199,15 @@ static void __kthread_parkme(struct kthread *self)if (!test_bit (KTHREAD_SHOULD_PARK , &self->flags))break ; +/* +* Thread is going to call schedule(), do not preempt it, +* or the caller of kthread_park() may spend more time in +* wait_task_inactive(). +*/ +preempt_disable ();complete (&self->parked); -schedule (); +schedule_preempt_disabled (); +preempt_enable (); }__set_current_state (TASK_RUNNING ); }
@@ -245,8 +252,14 @@ static int kthread(void *_create)/* OK, tell user we're spawned, wait for stop or wakeup */ __set_current_state (TASK_UNINTERRUPTIBLE ); create->result = current; +/* +* Thread is going to call schedule(), do not preempt it, +* or the creator may spend more time in wait_task_inactive(). +*/ +preempt_disable ();complete (done); -schedule (); +schedule_preempt_disabled (); +preempt_enable (); ret = -EINTR ;if (!test_bit (KTHREAD_SHOULD_STOP , &self->flags)) {
Signature · 1 line
2.17.1
Re: [PATCH v3 1/1] kthread: do not preempt current task if it is going to call schedule()
Quoted 34 lines · On Fri, 6 Mar 2020 15:01:33 +0800 <[email protected]> wrote:
From: Liang Chen <[email protected]>
when we create a kthread with ktrhead_create_on_cpu(),the child thread entry is ktread.c:ktrhead() which will be preempted by the parent after call complete(done) while
schedule()is not called yet,then the parent will callwait_task_inactive(child)but the child is still on the runqueue, so the parent willschedule_hrtimeout()for 1 jiffy,it will waste a lot of time,especially on startup.parent child
ktrhead_create_on_cpu()
wait_fo_completion(&done)-----> ktread.c:ktrhead()
|----- complete(done);--wakeup and preempted by parentkthread_bind() <------------| |-> schedule();--dequeue here wait_task_inactive(child) | schedule_hrtimeout(1 jiffy) -|So we hope the child just wakeup parent but not preempted by parent, and the child is going to call
schedule()soon,then the parent will not callschedule_hrtimeout(1 jiffy)as the child is already dequeue.The same issue for ktrhead_park()&&kthread_parkme(). This patch can save 120ms on rk312x startup with
CONFIG_HZ=300.Signed-off-by Liang Chen <[email protected]>--- kernel/kthread.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)kernel/kthread.c +0
-0
kernel/kthread.c static void __kthread_parkme(struct kthread *self) · line 208
Quoted 10 lines
kernel/kthread.c +6
-0@@ -199,8 +199,15 @@ static void __kthread_parkme(struct kthread *self)if (!test_bit (KTHREAD_SHOULD_PARK , &self->flags))break ; +/* +* Thread is going to call schedule(), do not preempt it, +* or the caller of kthread_park() may spend more time in +* wait_task_inactive(). +*/ +preempt_disable ();complete (&self->parked);
I first was concerned that this could break PREEMPT_RT, as complete() calls spin_locks() which are turned into sleeping locks when PREEMPT_RT is enabled. But looking at the latest PREEMPT_RT patch, it appears that it converts the locks in complete() into raw_spin_locks (and using swake).
I don't see any other issue with this patch.
-- Steve
Quoted 22 lines
kernel/kthread.c +9
-2-schedule (); +schedule_preempt_disabled (); +preempt_enable (); }__set_current_state (TASK_RUNNING ); }@@ -245,8 +252,14 @@ static int kthread(void *_create)/* OK, tell user we're spawned, wait for stop or wakeup */ __set_current_state (TASK_UNINTERRUPTIBLE ); create->result = current; +/* +* Thread is going to call schedule(), do not preempt it, +* or the creator may spend more time in wait_task_inactive(). +*/ +preempt_disable ();complete (done); -schedule (); +schedule_preempt_disabled (); +preempt_enable (); ret = -EINTR ;if (!test_bit (KTHREAD_SHOULD_STOP , &self->flags)) {
Re: [PATCH v3 1/1] kthread: do not preempt current task if it is going to call schedule()
In reply to [email protected]Quoted 17 lines · On Fri, Mar 06, 2020 at 03:01:33PM +0800, [email protected] wrote:
From: Liang Chen <[email protected]>
when we create a kthread with ktrhead_create_on_cpu(),the child thread entry is ktread.c:ktrhead() which will be preempted by the parent after call complete(done) while
schedule()is not called yet,then the parent will callwait_task_inactive(child)but the child is still on the runqueue, so the parent willschedule_hrtimeout()for 1 jiffy,it will waste a lot of time,especially on startup.parent child
ktrhead_create_on_cpu()
wait_fo_completion(&done)-----> ktread.c:ktrhead()
|----- complete(done);--wakeup and preempted by parentkthread_bind() <------------| |-> schedule();--dequeue here wait_task_inactive(child) | schedule_hrtimeout(1 jiffy) -|
Quoted 8 lines
So we hope the child just wakeup parent but not preempted by parent, and the child is going to call
schedule()soon,then the parent will not callschedule_hrtimeout(1 jiffy)as the child is already dequeue.The same issue for ktrhead_park()&&kthread_parkme(). This patch can save 120ms on rk312x startup with
CONFIG_HZ=300.Signed-off-by Liang Chen <[email protected]>
Thanks!
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[tip: sched/core] kthread: Do not preempt current task if it is going to call schedule()
In reply to [email protected]The following commit has been merged into the sched/core branch of tip:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 26c7295be0c5e6da3fa45970e9748be983175b1b Gitweb: https://git.kernel.org/tip/26c7295be0c5e6da3fa45970e9748be983175b1b Author: Liang Chen <[email protected]> AuthorDate: Fri, 06 Mar 2020 15:01:33 +08:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Fri, 20 Mar 2020 13:06:20 +01:00
kthread: Do not preempt current task if it is going to call schedule()
when we create a kthread with ktrhead_create_on_cpu(),the child thread entry is ktread.c:ktrhead() which will be preempted by the parent after call complete(done) while schedule() is not called yet,then the parent will call wait_task_inactive(child) but the child is still on the runqueue, so the parent will schedule_hrtimeout() for 1 jiffy,it will waste a lot of time,especially on startup.
parent childktrhead_create_on_cpu()
wait_fo_completion(&done) -----> ktread.c:ktrhead()
|----- complete(done);--wakeup and preempted by parent
kthread_bind() <------------| |-> schedule();--dequeue here wait_task_inactive(child) | schedule_hrtimeout(1 jiffy) -|
So we hope the child just wakeup parent but not preempted by parent, and the child is going to call schedule() soon,then the parent will not call schedule_hrtimeout(1 jiffy) as the child is already dequeue.
The same issue for ktrhead_park()&&kthread_parkme(). This patch can save 120ms on rk312x startup with CONFIG_HZ=300.
--- kernel/kthread.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
kernel/kthread.c +15 -2
@@ -199,8 +199,15 @@ static void __kthread_parkme(struct kthread *self)if (!test_bit (KTHREAD_SHOULD_PARK , &self->flags))break ; +/* +* Thread is going to call schedule(), do not preempt it, +* or the caller of kthread_park() may spend more time in +* wait_task_inactive(). +*/ +preempt_disable ();complete (&self->parked); -schedule (); +schedule_preempt_disabled (); +preempt_enable (); }__set_current_state (TASK_RUNNING ); }
@@ -245,8 +252,14 @@ static int kthread(void *_create)/* OK, tell user we're spawned, wait for stop or wakeup */ __set_current_state (TASK_UNINTERRUPTIBLE ); create->result = current; +/* +* Thread is going to call schedule(), do not preempt it, +* or the creator may spend more time in wait_task_inactive(). +*/ +preempt_disable ();complete (done); -schedule (); +schedule_preempt_disabled (); +preempt_enable (); ret = -EINTR ;if (!test_bit (KTHREAD_SHOULD_STOP , &self->flags)) {