Skip to contentSkip to conversation

rtc: ds1305: set range

PATCH New Alexandre Belloni 1 participant 2 messages Mar 6, 2020 Real time clock (RTC)

lore
Share & tools
lore

Alexandre Belloni

author maintainer
#0 lore raw

PATCH 1/2 rtc: ds1305: set range

The ds1305 is a BCD rtc valid from 2000 to 2099.

---
 drivers/rtc/rtc-ds1305.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/rtc/rtc-ds1305.c +2 -0
index 4420fbf2f8fe..ca55ebab24fb 100644
@@ -694,6 +694,8 @@ static int ds1305_probe(struct spi_device *spi)
 		return PTR_ERR(ds1305->rtc);
 
 	ds1305->rtc->ops = &ds1305_ops;
+	ds1305->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
+	ds1305->rtc->range_max = RTC_TIMESTAMP_END_2099;
 
 	ds1305_nvmem_cfg.priv = ds1305;
 	ds1305->rtc->nvram_old_abi = true;
Signature · 1 line
2.24.1
author maintainer
#1 lore raw

PATCH 2/2 rtc: ds1305: switch to rtc_tm_to_time64

Call the 64bit version of rtc_tm to time conversion.

---
 drivers/rtc/rtc-ds1305.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/rtc/rtc-ds1305.c +2 -6
index ca55ebab24fb..a3d790889eea 100644
@@ -325,17 +325,13 @@ static int ds1305_set_alarm(struct device *dev, struct rtc_wkalrm *alm)
 	u8		buf[1 + DS1305_ALM_LEN];
 
 	/* convert desired alarm to time_t */
-	status = rtc_tm_to_time(&alm->time, &later);
-	if (status < 0)
-		return status;
+	later = rtc_tm_to_time64(&alm->time);
 
 	/* Read current time as time_t */
 	status = ds1305_get_time(dev, &tm);
 	if (status < 0)
 		return status;
-	status = rtc_tm_to_time(&tm, &now);
-	if (status < 0)
-		return status;
+	now = rtc_tm_to_time64(&tm);
 
 	/* make sure alarm fires within the next 24 hours */
 	if (later <= now)
Signature · 1 line
2.24.1