Skip to contentSkip to conversation

arm64: dts: imx8mq-phanbell: Fix Ethernet PHY post-reset duration

PATCH In review Alifer Moraes 2 participants 3 messages Mar 6, 2020 – Mar 13, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: imx8mq-phanbell: Fix Ethernet PHY post-reset duration

i.MX8MQ Phanbell board uses Realtek RTL8211FD as Ethernet PHY.
Its datasheet states that the proper post reset duration should be at least 50 ms.

Fixes f34d4bfab354 ("arm64: dts: imx8mq-phanbell: Add support for ethernet")
---
 arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts +1 -1
index 16ed13c44a47..06e248b95ada 100644
@@ -207,7 +207,7 @@
 	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
 	phy-reset-duration = <10>;
-	phy-reset-post-delay = <30>;
+	phy-reset-post-delay = <50>;
 	phy-handle = <&ethphy0>;
 	fsl,magic-packet;
 	status = "okay";
Signature · 1 line
2.17.1
reviewer
#1 lore raw

Hi Alifer,

Quoted 3 lines · Alifer Moraes

i.MX8MQ Phanbell board uses Realtek RTL8211FD as Ethernet PHY.
Its datasheet states that the proper post reset duration should be at least 50 ms.

The datasheet I found in the web states:

"The RTL8211F(I)/RTL8211FD(I) has a PHYRSTB pin to reset the chip. For a complete PHY reset, this pin must be asserted low for at least 10ms (Tgap in Figure 9) for the internal regulator. Wait for a further 30ms (for internal circuits settling time) before accessing the PHY register"

Where does the 50ms requirement come from? Do you have an updated datasheet that says 50ms instead?

Please clarify.

Thanks

reviewer Reviewed-by
#2 lore raw
Quoted 10 lines · Fabio Estevam

Hi Alifer,

Quoted 3 lines · Alifer Moraes

i.MX8MQ Phanbell board uses Realtek RTL8211FD as Ethernet PHY.
Its datasheet states that the proper post reset duration should be at least 50 ms.

The datasheet I found in the web states:

Quoted 8 lines

"The RTL8211F(I)/RTL8211FD(I) has a PHYRSTB pin to reset the chip. For a complete PHY reset, this pin must be asserted low for at least 10ms (Tgap in Figure 9) for the internal regulator. Wait for a further 30ms (for internal circuits settling time) before accessing the PHY register"

Where does the 50ms requirement come from? Do you have an updated datasheet that says 50ms instead?

Just found this one:
https://datasheet.lcsc.com/szlcsc/1909021205_Realtek-Semicon-RTL8211F-CG_C187932.pdf

Which says "Wait for at least 50ms* (for internal circuits settling time) before accessing the PHY register.", so your patch is correct, thanks.

This also fixes Ethernet in U-Boot, so: