Skip to contentSkip to conversation

sercon: vbe modeset is int 10h function 4f02 not 4f00

PATCH In review Gerd Hoffmann 3 participants 3 messages Mar 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sercon: vbe modeset is int 10h function 4f02 not 4f00

Fixes console redirection for NetBSD primary bootloader.

https://bugs.launchpad.net/bugs/1743191

---
 src/sercon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/sercon.c +1 -1
index a5dadb7261af..66a1f2412e77 100644
@@ -464,7 +464,7 @@ static void sercon_104f(struct bregs *regs)
         regs->ax = 0x0100;
     } else {
         // Disable sercon entry point on any vesa modeset
-        if (regs->al == 0x00)
+        if (regs->al == 0x02)
             SET_LOW(sercon_enable, 0);
     }
 }
Signature · 1 line
2.18.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Gerd Hoffmann

Fixes console redirection for NetBSD primary bootloader.

https://bugs.launchpad.net/bugs/1743191

---
 src/sercon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/sercon.c +0 -0
index a5dadb7261af..66a1f2412e77 100644

src/sercon.c static void sercon_104f(struct bregs *regs) · line 470

Quoted 8 lines
src/sercon.c +1 -1
@@ -464,7 +464,7 @@ static void sercon_104f(struct bregs *regs)
         regs->ax = 0x0100;
     } else {
         // Disable sercon entry point on any vesa modeset
-        if (regs->al == 0x00)
+        if (regs->al == 0x02)
             SET_LOW(sercon_enable, 0);
     }
 }

-Kevin

Reviewed-by on v1 1/1
#2 lore raw
In reply to Gerd Hoffmann

Dear Gerd,

Maybe in imperative mood:

Quoted 1 line

Correct VBE modeset to int 10h function 4f02 not 4f00

Quoted 1 line · Gerd Hoffmann

Fixes console redirection for NetBSD primary bootloader.

Add how to reproduce this:

wget http://ftp.netbsd.org/pub/NetBSD/NetBSD-7.1.1/amd64/installation/cdrom/boot-com.iso
qemu-system-x86_64 -nographic -cdrom boot-com.iso

For backports add:

Fixes d6728f30 ("add serial console support")
Quoted 11 lines

https://bugs.launchpad.net/bugs/1743191

---
 src/sercon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/sercon.c +0 -0
index a5dadb7261af..66a1f2412e77 100644

src/sercon.c static void sercon_104f(struct bregs *regs) · line 470

Quoted 8 lines
src/sercon.c +1 -1
@@ -464,7 +464,7 @@ static void sercon_104f(struct bregs *regs)
         regs->ax = 0x0100;
     } else {
         // Disable sercon entry point on any vesa modeset
-        if (regs->al == 0x00)
+        if (regs->al == 0x02)
             SET_LOW(sercon_enable, 0);
     }
 }

Kind regards,

Paul