Skip to contentSkip to conversation

dmaengine: move .device_release missing log warning to debug level

PATCH In review Vinod Koul 1 participant 2 messages Mar 6, 2020 – Mar 11, 2020 dmaengine

lore
Share & tools
lore

Vinod Koul

author maintainer
#0 lore raw

PATCH 1/1 dmaengine: move .device_release missing log warning to debug level

Dmaengine core warns the drivers registering for missing .device_release implementation. The warning is accurate for dmaengine controllers which hotplug but not for rest.

So reduce this to a debug log.

---
 drivers/dma/dmaengine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/dmaengine.c +1 -1
index c3b1283b6d31..17909fd1820f 100644
@@ -1151,7 +1151,7 @@ int dma_async_device_register(struct dma_device *device)
 	}
 
 	if (!device->device_release)
-		dev_warn(device->dev,
+		dev_dbg(device->dev,
 			 "WARN: Device release is not defined so it is not safe to unbind this driver while in use\n");
 
 	kref_init(&device->ref);
Signature · 1 line
2.24.1
author maintainer
#1 lore raw
Quoted 5 lines · Vinod Koul

Dmaengine core warns the drivers registering for missing .device_release implementation. The warning is accurate for dmaengine controllers which hotplug but not for rest.

So reduce this to a debug log.

Applied now

Signature · 1 line
~Vinod