Skip to contentSkip to conversation

package/gst1-plugins-base: add tools option

PATCH New Peter Seiderer 2 participants 3 messages Mar 3, 2020 – Mar 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gst1-plugins-base: add tools option

Add tools option to disable building/installing of gst-discoverer, gst-device-monitor and gst-play commandline tools (analog BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS).

---
 package/gstreamer1/gst1-plugins-base/Config.in            | 7 +++++++
 package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk | 6 ++++++
 2 files changed, 13 insertions(+)
package/gstreamer1/gst1-plugins-base/Config.in +7 -0
index f60d540337..3a3694b72e 100644
@@ -10,6 +10,13 @@ menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE
 
 if BR2_PACKAGE_GST1_PLUGINS_BASE
 
+config BR2_PACKAGE_GST1_PLUGINS_BASE_INSTALL_TOOLS
+	bool "install gst-discoverer & gst-device-monitor & gst-play
+	default y
+	help
+	  Install the gst-discoverer, gst-device-monitor and gst-play
+	  tools.
+
 comment "dependency-less plugins"
 
 config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ADDER
package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk +6 -0
index 1781a5d461..ccecbb3c08 100644
@@ -26,6 +26,12 @@ GST1_PLUGINS_BASE_CONF_OPTS += \
 	-Dlibvisual=disabled \
 	-Diso-codes=disabled
 
+ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_INSTALL_TOOLS),y)
+GST1_PLUGINS_BASE_CONF_OPTS += -Dtools=enabled
+else
+GST1_PLUGINS_BASE_CONF_OPTS += -Dtools=disabled
+endif
+
 GST1_PLUGINS_BASE_DEPENDENCIES = gstreamer1 $(TARGET_NLS_DEPENDENCIES)
 
 GST1_PLUGINS_BASE_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/gst1-plugins-base: add tools option

Quoted 15 lines · On Tue, 3 Mar 2020 17:47:02 +0100 Peter Seiderer <[email protected]> wrote:

Add tools option to disable building/installing of gst-discoverer, gst-device-monitor and gst-play commandline tools (analog BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS).

---
 package/gstreamer1/gst1-plugins-base/Config.in            | 7 +++++++
 package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk | 6 ++++++
 2 files changed, 13 insertions(+)
package/gstreamer1/gst1-plugins-base/Config.in +0 -0
index f60d540337..3a3694b72e 100644

package/gstreamer1/gst1-plugins-base/Config.in menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE · line 14

Quoted 5 lines
package/gstreamer1/gst1-plugins-base/Config.in +2 -0
@@ -10,6 +10,13 @@ menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE
 
 if BR2_PACKAGE_GST1_PLUGINS_BASE
 
+config BR2_PACKAGE_GST1_PLUGINS_BASE_INSTALL_TOOLS
+	bool "install gst-discoverer & gst-device-monitor & gst-play

Missing closing double quote. Also, I changed this to "install tools", to keep the prompt shorter.

package/gstreamer1/gst1-plugins-base/Config.in menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE · line 15

Quoted 1 line
package/gstreamer1/gst1-plugins-base/Config.in +1 -0
+	default y

I know gstreamer1 does this, but this "default y" is really not in line with the typical Buildroot policy of minimalism, so I dropped this.

Applied to next with those changes.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/gst1-plugins-base: add tools option

Hello Thomas,

Quoted 19 lines · Thomas Petazzoni
Quoted 16 lines · On Tue, 3 Mar 2020 17:47:02 +0100 Peter Seiderer <[email protected]> wrote:

Add tools option to disable building/installing of gst-discoverer, gst-device-monitor and gst-play commandline tools (analog BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS).

---
 package/gstreamer1/gst1-plugins-base/Config.in            | 7 +++++++
 package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk | 6 ++++++
 2 files changed, 13 insertions(+)
package/gstreamer1/gst1-plugins-base/Config.ihttps://github.com/octo/liboping/pull/50/commits/664414123a3fe89984abfa0917946c513bf47163n renamed from package/gstreamer1/gst1-plugins-base/Config.in +0 -0
index f60d540337..3a3694b72e 100644
@@ -10,6 +10,13 @@ menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE
 
Quoted 7 lines

package/gstreamer1/gst1-plugins-base/Config.ihttps://github.com/octo/liboping/pull/50/commits/664414123a3fe89984abfa0917946c513bf47163n menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE · line 14

Quoted 4 lines
package/gstreamer1/gst1-plugins-base/Config.ihttps://github.com/octo/liboping/pull/50/commits/664414123a3fe89984abfa0917946c513bf47163n renamed from package/gstreamer1/gst1-plugins-base/Config.in +2 -0
 if BR2_PACKAGE_GST1_PLUGINS_BASE
 
+config BR2_PACKAGE_GST1_PLUGINS_BASE_INSTALL_TOOLS
+	bool "install gst-discoverer & gst-device-monitor & gst-play

Missing closing double quote. Also, I changed this to "install tools", to keep the prompt shorter.

Thanks for fixing it...

Quoted 5 lines

package/gstreamer1/gst1-plugins-base/Config.ihttps://github.com/octo/liboping/pull/50/commits/664414123a3fe89984abfa0917946c513bf47163n menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE · line 15

Quoted 2 lines
package/gstreamer1/gst1-plugins-base/Config.ihttps://github.com/octo/liboping/pull/50/commits/664414123a3fe89984abfa0917946c513bf47163n renamed from package/gstreamer1/gst1-plugins-base/Config.in +1 -0
+	default y

I know gstreamer1 does this, but this "default y" is really not in line with the typical Buildroot policy of minimalism, so I dropped this.

The reasoning was to do the same as for BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS (which defaults to y) but I am although o.k. with this one...

Regards,
Peter

Quoted 6 lines

Applied to next with those changes.

Thanks!

Thomas