fs_parse: Remove pr_notice() about each validation
PATCH 1/1 fs_parse: Remove pr_notice() about each validation
This notice fills my boot logs with scary-looking asterisks but doesn't really tell me anything. Let's just remove it; validation errors are already reported separately, so this is just a redundant list of filesystems.
$ dmesg | grep VALIDATE [ 0.306256] *** VALIDATE tmpfs *** [ 0.307422] *** VALIDATE proc *** [ 0.308355] *** VALIDATE cgroup *** [ 0.308741] *** VALIDATE cgroup2 *** [ 0.813256] *** VALIDATE bpf *** [ 0.815272] *** VALIDATE ramfs *** [ 0.815665] *** VALIDATE hugetlbfs *** [ 0.876970] *** VALIDATE nfs *** [ 0.877383] *** VALIDATE nfs4 ***
--- fs/fs_parser.c | 2 -- 1 file changed, 2 deletions(-)
fs/fs_parser.c +0 -2
@@ -368,8 +368,6 @@ bool fs_validate_description(const char *name,const struct fs_parameter_spec *param, *p2;bool good = true; -pr_notice ("*** VALIDATE %s ***\n" , name); -for (param = desc; param->name; param++) {/* Check for duplicate parameter names */ for (p2 = desc; p2 < param; p2++) {
Signature · 5 lines
2.20.1 -- Kees Cook
Hi Andrew,
Can you pick this up in -mm?
Thanks!
-Kees
Quoted 40 lines · Kees Cook
This notice fills my boot logs with scary-looking asterisks but doesn't really tell me anything. Let's just remove it; validation errors are already reported separately, so this is just a redundant list of filesystems.
$ dmesg | grep VALIDATE [ 0.306256] *** VALIDATE tmpfs *** [ 0.307422] *** VALIDATE proc *** [ 0.308355] *** VALIDATE cgroup *** [ 0.308741] *** VALIDATE cgroup2 *** [ 0.813256] *** VALIDATE bpf *** [ 0.815272] *** VALIDATE ramfs *** [ 0.815665] *** VALIDATE hugetlbfs *** [ 0.876970] *** VALIDATE nfs *** [ 0.877383] *** VALIDATE nfs4 ***Signed-off-by Kees Cook <[email protected]>--- fs/fs_parser.c | 2 -- 1 file changed, 2 deletions(-)fs/fs_parser.c +0
-2@@ -368,8 +368,6 @@ bool fs_validate_description(const char *name,const struct fs_parameter_spec *param, *p2;bool good = true; -pr_notice ("*** VALIDATE %s ***\n" , name); -for (param = desc; param->name; param++) {/* Check for duplicate parameter names */ for (p2 = desc; p2 < param; p2++) {Signature · 5 lines
2.20.1 -- Kees Cook
Signature · 1 line
Kees Cook
Quoted 16 lines · Kees Cook
This notice fills my boot logs with scary-looking asterisks but doesn't really tell me anything. Let's just remove it; validation errors are already reported separately, so this is just a redundant list of filesystems.
$ dmesg | grep VALIDATE [ 0.306256] *** VALIDATE tmpfs *** [ 0.307422] *** VALIDATE proc *** [ 0.308355] *** VALIDATE cgroup *** [ 0.308741] *** VALIDATE cgroup2 *** [ 0.813256] *** VALIDATE bpf *** [ 0.815272] *** VALIDATE ramfs *** [ 0.815665] *** VALIDATE hugetlbfs *** [ 0.876970] *** VALIDATE nfs *** [ 0.877383] *** VALIDATE nfs4 ***
Quoted 1 line
Signed-off-by Kees Cook <[email protected]>
Excellent, these messages haven't been useful in helping users diagnose problems and they look quite noisy considering how mundane they are.
Thanks
Quoted 23 lines
--- fs/fs_parser.c | 2 -- 1 file changed, 2 deletions(-)fs/fs_parser.c +0
-2@@ -368,8 +368,6 @@ bool fs_validate_description(const char *name,const struct fs_parameter_spec *param, *p2;bool good = true; -pr_notice ("*** VALIDATE %s ***\n" , name); -for (param = desc; param->name; param++) {/* Check for duplicate parameter names */ for (p2 = desc; p2 < param; p2++) {Signature · 5 lines
2.20.1 -- Kees Cook