Skip to contentSkip to conversation

lib/igt_pm: Adjust pm status check timeout and log timing

PATCH In review [email protected] 3 participants 5 messages Mar 6, 2020 – Mar 9, 2020 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/igt_pm: Adjust pm status check timeout and log timing

From: Don Hiatt <[email protected]>

Increase the overall time we wait to achieve the desired runtime status to 15 seconds to fix an occasional timeout and do so in 1 second increments to speed up exiting. Also log the amount of time we waited to get a handle on how much variation we run into.

---
 lib/igt_pm.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)
lib/igt_pm.c +13 -5
index 9d441e1b76ff..13675fca0c9d 100644
@@ -747,8 +747,8 @@ static const char *_pm_status_name(enum igt_runtime_pm_status status)
  * igt_wait_for_pm_status:
  * @status: desired runtime PM status
  *
- * Waits until for the driver to switch to into the desired runtime PM status,
- * with a 10 second timeout.
+ * Waits for the driver to switch into the desired runtime PM status,
+ * with up to a 15 second timeout in 1 second increments.
  *
  * Returns:
  * True if the desired runtime PM status was attained, false if the operation
@@ -758,7 +758,7 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
 {
 	enum igt_runtime_pm_status expected = status;
 	bool ret;
-	int fd;
+	int fd, i;
 
 	if (__igt_pm_power < 0)
 		return false;
@@ -766,8 +766,16 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
 	fd = openat(__igt_pm_power, "runtime_status", O_RDONLY);
 	igt_assert_f(fd >= 0, "Can't open runtime_status\n");
 
-	ret = igt_wait((status = __igt_get_runtime_pm_status(fd)) == expected,
-		       10000, 100);
+	for (i=1; i < 16; ++i) {
+		ret = igt_wait((status = __igt_get_runtime_pm_status(fd)) == expected,
+				1000, 100);
+
+		if (ret) {
+			igt_info("Got expected (%s) runtime pm status in %d second(s)\n",
+				 _pm_status_name(expected), i);
+			break;
+		}
+	}
 	close(fd);
 
 	if (!ret)
Signature · 6 lines
2.25.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_pm: Adjust pm status check timeout and log timing

== Series Details ==

== Series Details ==

Series: lib/igt_pm: Adjust pm status check timeout and log timing
URL : https://patchwork.freedesktop.org/series/74398/
State : success

== Summary ==

CI Bug Log - changes from IGT_5498 -> IGTPW_4274
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/index.html

Known issues
------------

Here are the changes found in IGTPW_4274 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@gem_contexts:
- fi-cml-s: [PASS][1] -> [DMESG-FAIL][2] ([i915#877])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/fi-cml-s/igt@i915_selftest@live@gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/fi-cml-s/igt@i915_selftest@live@gem_contexts.html

* igt@kms_addfb_basic@bad-pitch-128:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([CI#94] / [i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/fi-tgl-y/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [PASS][5] -> [FAIL][6] ([i915#217])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/fi-icl-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/fi-icl-u2/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [FAIL][7] ([CI#94]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/fi-tgl-y/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/fi-tgl-y/igt@[email protected]

* igt@kms_addfb_basic@addfb25-x-tiled:
- fi-tgl-y: [DMESG-WARN][9] ([CI#94] / [i915#402]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/fi-tgl-y/igt@[email protected]

[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877

Participating hosts (51 -> 45)
------------------------------

Additional (1): fi-kbl-soraka
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5498 -> IGTPW_4274

CI-20190529: 20190529
CI_DRM_8085: f731492964aa6510672f43292d4b2216b73eddeb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4274: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/index.html
IGT_5498: 1bb7a25a09fe3e653d310e8bdfbdde4a1934b326 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/1
#2 lore raw
In reply to [email protected]
Quoted 46 lines · On 3/6/20 9:28 AM, [email protected] wrote:

From: Don Hiatt <[email protected]>

Increase the overall time we wait to achieve the desired runtime status to 15 seconds to fix an occasional timeout and do so in 1 second increments to speed up exiting. Also log the amount of time we waited to get a handle on how much variation we run into.

---
  lib/igt_pm.c | 18 +++++++++++++-----
  1 file changed, 13 insertions(+), 5 deletions(-)
lib/igt_pm.c +6 -5
index 9d441e1b76ff..13675fca0c9d 100644
@@ -747,8 +747,8 @@ static const char *_pm_status_name(enum igt_runtime_pm_status status)
   * igt_wait_for_pm_status:
   * @status: desired runtime PM status
   *
- * Waits until for the driver to switch to into the desired runtime PM status,
- * with a 10 second timeout.
+ * Waits for the driver to switch into the desired runtime PM status,
+ * with up to a 15 second timeout in 1 second increments.
   *
   * Returns:
   * True if the desired runtime PM status was attained, false if the operation
@@ -758,7 +758,7 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
  {
  	enum igt_runtime_pm_status expected = status;
  	bool ret;
-	int fd;
+	int fd, i;
 
  	if (__igt_pm_power < 0)
  		return false;
@@ -766,8 +766,16 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
  	fd = openat(__igt_pm_power, "runtime_status", O_RDONLY);
  	igt_assert_f(fd >= 0, "Can't open runtime_status\n");
 
-	ret = igt_wait((status = __igt_get_runtime_pm_status(fd)) == expected,
-		       10000, 100);
+	for (i=1; i < 16; ++i) {
+		ret = igt_wait((status = __igt_get_runtime_pm_status(fd)) == expected,
+				1000, 100);

lib/igt_pm.c bool igt_wait_for_pm_status(enum igt_runtime_pm_status status) · line 781

Quoted 10 lines
lib/igt_pm.c +7 -0
+
+		if (ret) {
+			igt_info("Got expected (%s) runtime pm status in %d second(s)\n",
+				 _pm_status_name(expected), i);
+			break;
+		}
+	}
  	close(fd);
 
  	if (!ret)

We are still not sure as to why the status switch is taking longer now but having this change and allowing the

time to be logged, should help in further understanding this failure seen on various pm tests.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_pm: Adjust pm status check timeout and log timing

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: lib/igt_pm: Adjust pm status check timeout and log timing
URL : https://patchwork.freedesktop.org/series/74398/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5498_full -> IGTPW_4274_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4274_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4274_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4274_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_ctx_persistence@close-replace-race:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb3/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_persistence@close-replace-race:
- shard-apl: [INCOMPLETE][3] ([fdo#103927]) -> [TIMEOUT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-apl2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-apl3/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy@gtt}:
- shard-hsw: NOTRUN -> [DMESG-WARN][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-hsw1/igt@gem_userptr_blits@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4274_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#112080]) +11 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb3/igt@[email protected]

* igt@gem_ctx_persistence@close-replace-race:
- shard-kbl: [PASS][8] -> [INCOMPLETE][9] ([fdo#103665]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-kbl6/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-kbl4/igt@[email protected]

* igt@gem_exec_schedule@implicit-write-read-bsd1:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#109276] / [i915#677]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb4/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb3/igt@[email protected]

* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#109276]) +22 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb1/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb7/igt@[email protected]

* igt@gem_exec_schedule@pi-common-bsd:
- shard-iclb: [PASS][14] -> [SKIP][15] ([i915#677])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb6/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][16] -> [SKIP][17] ([fdo#112146]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb7/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb2/igt@[email protected]

* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [PASS][18] -> [DMESG-WARN][19] ([i915#118] / [i915#95])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-glk3/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-glk9/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][20] -> [FAIL][21] ([i915#454])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb4/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][22] -> [DMESG-WARN][23] ([i915#180]) +4 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-kbl3/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-kbl2/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled:
- shard-glk: [PASS][24] -> [FAIL][25] ([i915#52] / [i915#54])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-glk1/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-glk8/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled:
- shard-hsw: [PASS][26] -> [DMESG-WARN][27] ([i915#478])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-hsw1/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-hsw4/igt@[email protected]
- shard-snb: [PASS][28] -> [DMESG-WARN][29] ([i915#478])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-snb2/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-snb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff:
- shard-glk: [PASS][30] -> [FAIL][31] ([i915#49])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-glk5/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-glk7/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][32] -> [DMESG-WARN][33] ([i915#180]) +5 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-apl2/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-apl6/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-glk: [PASS][34] -> [FAIL][35] ([i915#899]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-glk6/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-glk8/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][36] -> [SKIP][37] ([fdo#109441]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html

* igt@perf@gen12-mi-rpc:
- shard-tglb: [PASS][38] -> [FAIL][39] ([i915#1085])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-tglb3/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-tglb3/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_persistence@close-replace-race:
- shard-tglb: [TIMEOUT][40] -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-tglb6/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-tglb7/igt@[email protected]

* igt@gem_exec_balancer@hang:
- shard-tglb: [FAIL][42] ([i915#1277]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-tglb6/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-tglb6/igt@[email protected]

* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][44] ([fdo#112080]) -> [PASS][45] +10 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb7/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb1/igt@[email protected]

* igt@gem_exec_schedule@implicit-both-bsd1:
- shard-iclb: [SKIP][46] ([fdo#109276] / [i915#677]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb6/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [SKIP][48] ([i915#677]) -> [PASS][49] +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb2/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb8/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][50] ([fdo#112146]) -> [PASS][51] +5 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb2/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb5/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [FAIL][52] ([i915#644]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-apl7/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-apl8/igt@[email protected]
- shard-kbl: [FAIL][54] ([i915#644]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-kbl3/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-kbl3/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [DMESG-WARN][56] ([fdo#111870] / [i915#478]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-snb6/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-snb5/igt@[email protected]
- shard-hsw: [DMESG-WARN][58] ([fdo#111870]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-hsw6/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-hsw4/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][60] ([i915#454]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb3/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb7/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [FAIL][62] ([i915#79]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-glk3/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-glk5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][64] ([i915#180]) -> [PASS][65] +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-apl6/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-apl3/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-WARN][66] ([i915#180]) -> [PASS][67] +4 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-kbl1/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-kbl4/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [INCOMPLETE][68] ([fdo#103665]) -> [PASS][69] +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-kbl1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-kbl1/igt@[email protected]

* igt@kms_setmode@basic:
- shard-apl: [FAIL][70] ([i915#31]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-apl3/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-apl6/igt@[email protected]
- shard-glk: [FAIL][72] ([i915#31]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-glk7/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-glk8/igt@[email protected]

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][74] ([fdo#109276]) -> [PASS][75] +15 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb8/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb4/igt@[email protected]

#### Warnings ####

* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [SKIP][76] ([i915#468]) -> [FAIL][77] ([i915#454])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-tglb2/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-tglb1/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][78] ([i915#1226]) -> [SKIP][79] ([fdo#109349])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5498/shard-iclb2/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/shard-iclb7/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1277]: https://gitlab.freedesktop.org/drm/intel/issues/1277
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (8 -> 8)
------------------------------

No changes in participating hosts

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5498 -> IGTPW_4274

CI-20190529: 20190529
CI_DRM_8085: f731492964aa6510672f43292d4b2216b73eddeb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4274: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/index.html
IGT_5498: 1bb7a25a09fe3e653d310e8bdfbdde4a1934b326 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4274/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw
In reply to [email protected]
Quoted 46 lines · On 3/6/20 9:28 AM, [email protected] wrote:

From: Don Hiatt <[email protected]>

Increase the overall time we wait to achieve the desired runtime status to 15 seconds to fix an occasional timeout and do so in 1 second increments to speed up exiting. Also log the amount of time we waited to get a handle on how much variation we run into.

---
  lib/igt_pm.c | 18 +++++++++++++-----
  1 file changed, 13 insertions(+), 5 deletions(-)
lib/igt_pm.c +6 -5
index 9d441e1b76ff..13675fca0c9d 100644
@@ -747,8 +747,8 @@ static const char *_pm_status_name(enum igt_runtime_pm_status status)
   * igt_wait_for_pm_status:
   * @status: desired runtime PM status
   *
- * Waits until for the driver to switch to into the desired runtime PM status,
- * with a 10 second timeout.
+ * Waits for the driver to switch into the desired runtime PM status,
+ * with up to a 15 second timeout in 1 second increments.
   *
   * Returns:
   * True if the desired runtime PM status was attained, false if the operation
@@ -758,7 +758,7 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
  {
  	enum igt_runtime_pm_status expected = status;
  	bool ret;
-	int fd;
+	int fd, i;
 
  	if (__igt_pm_power < 0)
  		return false;
@@ -766,8 +766,16 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
  	fd = openat(__igt_pm_power, "runtime_status", O_RDONLY);
  	igt_assert_f(fd >= 0, "Can't open runtime_status\n");
 
-	ret = igt_wait((status = __igt_get_runtime_pm_status(fd)) == expected,
-		       10000, 100);
+	for (i=1; i < 16; ++i) {
+		ret = igt_wait((status = __igt_get_runtime_pm_status(fd)) == expected,
+				1000, 100);

lib/igt_pm.c bool igt_wait_for_pm_status(enum igt_runtime_pm_status status) · line 781

Quoted 10 lines
lib/igt_pm.c +7 -0
+
+		if (ret) {
+			igt_info("Got expected (%s) runtime pm status in %d second(s)\n",
+				 _pm_status_name(expected), i);
+			break;
+		}
+	}
  	close(fd);
 
  	if (!ret)

Don, could you add the information about the tests issues that this helps to resolve to the commit message ?

Suja

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev