Skip to contentSkip to conversation

bareudp: several code cleanup for bareudp module

PATCH In review Taehee Yoo 2 participants 2 messages Mar 8, 2020 – Mar 9, 2020

Subsystems (2)
lore
Share & tools
lore

Taehee Yoo

author
#0 lore raw

cover bareudp: several code cleanup for bareudp module

This patchset is to cleanup bareudp module code.

1. The first patch is to add module alias
In the current bareudp code, there is no module alias. So, RTNL couldn't load bareudp module automatically.

2. The second patch is to add extack message.
The extack error message is useful for noticing specific errors when command is failed.

3. The third patch is to remove unnecessary udp_encap_enable(). In the bareudp_socket_create(), udp_encap_enable() is called. But, the it's already called in the setup_udp_tunnel_sock(). So, it could be removed.

Taehee Yoo (3):
bareudp: add module alias
bareudp: print error message when command fails
bareudp: remove unnecessary udp_encap_enable() in
bareudp_socket_create()

 drivers/net/bareudp.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
Signature · 1 line
2.17.1
maintainer
#1 lore raw

From: Taehee Yoo <[email protected]>
Date: Sun, 8 Mar 2020 01:18:49 +0000

Quoted 6 lines

This patchset is to cleanup bareudp module code.

1. The first patch is to add module alias
In the current bareudp code, there is no module alias. So, RTNL couldn't load bareudp module automatically.

Quoted 8 lines

2. The second patch is to add extack message.
The extack error message is useful for noticing specific errors when command is failed.

3. The third patch is to remove unnecessary udp_encap_enable(). In the bareudp_socket_create(), udp_encap_enable() is called. But, the it's already called in the setup_udp_tunnel_sock(). So, it could be removed.

Series applied, thanks.